eden-miror/src/video_core
xbzk ec2b9b0400
Some checks are pending
tx-src / sources (push) Waiting to run
Check Strings / check-strings (push) Waiting to run
[vk, renderdoc] fixed zero-sized streambuffer bug on old heap-absent GPUs (#4052)
This fix a bug in which eden crashes when renderdoc is attached to vulkan.
that kept me away from renderdoc for around a year now.

the bug:

in video_core\renderer_vulkan\vk_staging_buffer_pool.cpp
in GetStreamBufferSize(...)
if device.HasDebuggingToolAttached()
but heap is empty/unavailable <-- Case in my old nvidia kepler gpu

the original method returns size 0, right?
the change honors same original behavior, while covers my case properly, returning MAX_STREAM_BUFFER_SIZE.

addl some log tip and some minimal doc. fully safe. let it rip.

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4052
Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Reviewed-by: Lizzie <lizzie@eden-emu.dev>
2026-06-03 05:02:13 +02:00
..
buffer_cache [video,buffer] rewrite storagebufferbinding size() lambda to be full data driven instead of cbuf_index based (#4041) 2026-06-02 03:31:59 +02:00
control
engines [video_core] fix std::bitset<> dirty tracker OOB, fix slightly wrong index format estimate (#4006) 2026-05-27 00:04:27 +02:00
gpu_logging
host1x [core/core_timing] better MWAITX and WAITPKG delays (#3984) 2026-05-30 21:59:10 +02:00
host_shaders [video_core/host_shaders] add Snapdragon GSRv1 fragment shaders (#3307) 2026-05-24 01:38:19 +02:00
query_cache
renderer_null
renderer_opengl [video_core] fix redundant resize-copy overload and just use default-init resize, to reduce stutter on Mario BP (#3874) 2026-05-29 03:28:47 +02:00
renderer_vulkan [vk, renderdoc] fixed zero-sized streambuffer bug on old heap-absent GPUs (#4052) 2026-06-03 05:02:13 +02:00
texture_cache [vk] fix oversight with #3874 with invalid image ids (#4026) 2026-05-30 21:59:18 +02:00
textures
vulkan_common [vk, renderdoc] fixed zero-sized streambuffer bug on old heap-absent GPUs (#4052) 2026-06-03 05:02:13 +02:00
cache_types.h
capture.h
cdma_pusher.cpp
cdma_pusher.h
CMakeLists.txt [video_core/host_shaders] add Snapdragon GSRv1 fragment shaders (#3307) 2026-05-24 01:38:19 +02:00
compatible_formats.cpp
compatible_formats.h
delayed_destruction_ring.h
dirty_flags.cpp
dirty_flags.h
dma_pusher.cpp [video_core] fix std::bitset<> dirty tracker OOB, fix slightly wrong index format estimate (#4006) 2026-05-27 00:04:27 +02:00
dma_pusher.h
fence_manager.h [vk,fence_manager] improvement for antiflicker showed bad for some games, so it was removed from balanced/accurate and kept for antiflicker toggle only (#4010) 2026-05-26 01:41:11 +02:00
framebuffer_config.cpp
framebuffer_config.h
fsr.cpp
fsr.h
gpu.cpp [hle/service{nvdrv,apm}] fixes for TetrisSwitch (#3983) 2026-05-24 01:04:32 +02:00
gpu.h
gpu_thread.cpp
gpu_thread.h
guest_memory.h
invalidation_accumulator.h
macro.cpp
macro.h
memory_manager.cpp
memory_manager.h
present.h
pte_kind.h
query_cache.h
rasterizer_download_area.h
rasterizer_interface.h
renderer_base.cpp
renderer_base.h
shader_cache.cpp
shader_cache.h
shader_environment.cpp [core/core_timing] better MWAITX and WAITPKG delays (#3984) 2026-05-30 21:59:10 +02:00
shader_environment.h
shader_notify.cpp
shader_notify.h
smaa_area_tex.h
smaa_search_tex.h
surface.cpp [vk, opengl] recognize and use ETC2 (if available) textures natively (#3237) 2026-05-15 22:08:09 +02:00
surface.h [video_core] fix odr violation in formatter for pixelFormat (#3504) 2026-05-18 23:54:07 +02:00
transform_feedback.cpp
transform_feedback.h
video_core.cpp
video_core.h