mirror of
https://git.eden-emu.dev/eden-emu/eden
synced 2026-10-22 18:41:00 +02:00
85d77f636c
There are still some other issues not addressed here, but it's a start. Workarounds for false-positive reports: - `RasterizerAccelerated`: Put a gigantic array behind a `unique_ptr`, because UBSan has a [hardcoded limit](https://stackoverflow.com/questions/64531383/c-runtime-error-using-fsanitize-undefined-object-has-a-possibly-invalid-vp) of how big it thinks objects can be, specifically when dealing with offset-to-top values used with multiple inheritance. Hopefully this doesn't have a performance impact. - `QueryCacheBase::QueryCacheBase`: Avoid an operation that UBSan thinks is UB even though it at least arguably isn't. See the link in the comment for more information. Fixes for correct reports: - `PageTable`, `Memory`: Use `uintptr_t` values instead of pointers to avoid UB from pointer overflow (when pointer arithmetic wraps around the address space). - `KScheduler::Reload`: `thread->GetOwnerProcess()` can be `nullptr`; avoid calling methods on it in this case. (The existing code returns a garbage reference to a field, which is then passed into `LoadWatchpointArray`, and apparently it's never used, so it's harmless in practice but still triggers UBSan.) - `KAutoObject::Close`: This function calls `this->Destroy()`, which overwrites the beginning of the object with junk (specifically a free list pointer). Then it calls `this->UnregisterWithKernel()`. UBSan complains about a type mismatch because the vtable has been overwritten, and I believe this is indeed UB. `UnregisterWithKernel` also loads `m_kernel` from the 'freed' object, which seems to be technically safe (the overwriting doesn't extend as far as that field), but seems dubious. Switch to a `static` method and load `m_kernel` in advance. |
||
|---|---|---|
| .. | ||
| buffer_cache | ||
| control | ||
| engines | ||
| host1x | ||
| host_shaders | ||
| macro | ||
| renderer_null | ||
| renderer_opengl | ||
| renderer_vulkan | ||
| texture_cache | ||
| textures | ||
| vulkan_common | ||
| cache_types.h | ||
| cdma_pusher.cpp | ||
| cdma_pusher.h | ||
| CMakeLists.txt | ||
| compatible_formats.cpp | ||
| compatible_formats.h | ||
| delayed_destruction_ring.h | ||
| dirty_flags.cpp | ||
| dirty_flags.h | ||
| dma_pusher.cpp | ||
| dma_pusher.h | ||
| fence_manager.h | ||
| framebuffer_config.h | ||
| fsr.cpp | ||
| fsr.h | ||
| gpu.cpp | ||
| gpu.h | ||
| gpu_thread.cpp | ||
| gpu_thread.h | ||
| invalidation_accumulator.h | ||
| memory_manager.cpp | ||
| memory_manager.h | ||
| precompiled_headers.h | ||
| pte_kind.h | ||
| query_cache.h | ||
| rasterizer_accelerated.cpp | ||
| rasterizer_accelerated.h | ||
| rasterizer_download_area.h | ||
| rasterizer_interface.h | ||
| renderer_base.cpp | ||
| renderer_base.h | ||
| shader_cache.cpp | ||
| shader_cache.h | ||
| shader_environment.cpp | ||
| shader_environment.h | ||
| shader_notify.cpp | ||
| shader_notify.h | ||
| smaa_area_tex.h | ||
| smaa_search_tex.h | ||
| surface.cpp | ||
| surface.h | ||
| transform_feedback.cpp | ||
| transform_feedback.h | ||
| video_core.cpp | ||
| video_core.h | ||