diff --git a/.gitignore b/.gitignore
index 0be76d85cd..67bdd8adf4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -63,3 +63,4 @@ artifacts
*.AppImage*
/install*
vulkansdk*.exe
+*.tar.zst
diff --git a/README.md b/README.md
index 3ae31151f7..44a2b4c28b 100644
--- a/README.md
+++ b/README.md
@@ -61,6 +61,10 @@ See the [sign-up instructions](docs/SIGNUP.md) for information on registration.
Alternatively, if you wish to add translations, go to the [Eden project on Transifex](https://app.transifex.com/edenemu/eden-emulator) and review [the translations README](./dist/languages).
+## Documentation
+
+We have a user manual! See our [User Handbook](./docs/user/README.md).
+
## Building
See the [General Build Guide](docs/Build.md)
@@ -69,7 +73,9 @@ For information on provided development tooling, see the [Tools directory](./too
## Download
-You can download the latest releases from [here](https://github.com/eden-emulator/Releases/releases).
+You can download the latest releases from [here](https://git.eden-emu.dev/eden-emu/eden/releases).
+
+Save us some bandwidth! We have [mirrors available](./docs/user/ThirdParty.md#mirrors) as well.
## Support
diff --git a/docs/README.md b/docs/README.md
index 01727ae4dc..4ea532be8e 100644
--- a/docs/README.md
+++ b/docs/README.md
@@ -1,5 +1,7 @@
# Eden Build Documentation
+Are you just a casual user? Take a look at our [User Handbook](./user) then!
+
This contains documentation created by developers. This contains build instructions, guidelines, instructions/layouts for [cool stuff we made](./CPMUtil), and more.
- **[General Build Instructions](Build.md)**
@@ -11,7 +13,6 @@ This contains documentation created by developers. This contains build instructi
- **[CPM - CMake Package Manager](./CPMUtil)**
- **[Platform-Specific Caveats](Caveats.md)**
- **[The NVIDIA SM86 (Maxwell) GPU](./NvidiaGpu.md)**
-- **[User Handbook](./user)**
- **[Dynarmic](./dynarmic)**
- **[Cross compilation](./CrossCompile.md)**
- **[Driver Bugs](./DriverBugs.md)**
diff --git a/docs/user/AddGamesToSRM.md b/docs/user/AddGamesToSRM.md
deleted file mode 100644
index 433999c9b6..0000000000
--- a/docs/user/AddGamesToSRM.md
+++ /dev/null
@@ -1,100 +0,0 @@
-# Importing Games into Steam with Steam Rom Manager
-
-Use this when you want to import your games inside Eden into Steam to launch with artwork from Steam Game Mode without needing to launch Eden first.
-
-**Click [Here](https://evilperson1337.notion.site/Importing-Games-into-Steam-with-Steam-Rom-Manager-2b757c2edaf680d7a491c92b138f1fcc) for a version of this guide with images & visual elements.**
-
----
-
-### Pre-Requisites
-
-- Steam Deck Set up and Configured
-- Eden set up and Configured
-- Internet Access
-
----
-
-## Steps
-
-1. Press the **STEAM** button and then go to *Power → Switch to Desktop* to enter the Desktop mode.
-
-1. Install ***Steam ROM Manager***, there are 2 ways you can accomplish this, either manually or through [*EmuDeck*](https://www.emudeck.com/#downloads).
-
- ---
-
- ### Manual Installation
-
- 1. Open the *Discover Store* and search for *Steam ROM Manager.*
- 2. Select the **Install** button to install the program.
-
- ---
-
- ### Installing Through *EmuDeck*
-
-
-
- ***NOTE***: This assumes you have already set up EmuDeck, if not - just run through the guided installation and select *Steam ROM Manager* as one of the options.
-
-
-
- 1. Open **EmuDeck**, then navigate to *Manage Emulators.*
- 2. Scroll down to the bottom of the page to the *Manage your Tools & Frontends* section. Click **Steam ROM Manager**.
-
- 3. Click the **Install** button on the right hand side to install it.
-
- ---
-
-2. Open the Start Menu and Launch ***Steam ROM Manager***
-
-1. The program will now launch and show you a window with parsers.
-
-
-
- ***TIP***: Your layout may look different depending on how you installed *Steam ROM Manager*. You may need to go to **Settings → Theme** and change it to *Classic* to follow along.
-
-
-
-2. Switch off all Parsers by hitting the *Toggle Parsers* switch.
-3. Scroll down the list on the left-hand side and look for a parser called *Nintendo Switch - Eden* and switch it on. This parser may not exist depending on how you installed *Steam ROM Manager* (EmuDeck creates it for you). Follow these steps to create it if it is missing.
-
- ---
- ### Creating the Eden Parser
-
- 1. Select Create Parser and in the *Community Presets* option look for **Nintendo Switch - Yuzu**.
- 2. Change the **Parser title** from *Nintendo Switch - Yuzu* to *Nintendo Switch - Eden.*
- 3. Hit the **Browse** option under the *ROMs directory* section. Select the directory containing your Switch ROMs.
- 4. Under *Steam collections*, you can add a Steam category name. This just organizes the games under a common category in your Steam Library, this is optional but recommended.
- 5. Scroll down slightly to the **Executable Configuration → Executable**, select **Browse** and select the Eden AppImage.
- 6. Leave everything else the same and hit **Save** to save the parser.
- ---
-
-4. Click the Eden parser to view the options on the right, select **Test** at the bottom of the screen to ensure that *Steam ROM Manager* detects your games correctly.
-1. *Steam ROM Manager* will start to scan the specified ROMs directory and match them to games. Look over the results to ensure they are accurate. If you do not see any entries - check your parsers ROMs directory field.
-1. When you are happy with the results, click the **Add Games** → **Parse** to start the actual Parsing.
-1. The program will now identify the games and pull artwork from [*SteamGridDB*](https://www.steamgriddb.com/).
-2. Review the game matches and ensure everything is there.
-
- ---
-
- ### Correcting a Mismatch
-
- If the game is not identified correctly, you may need to tell *Steam ROM Manager* what the game is manually.
-
- 1. Hover over the game card and click the magnifying glass icon.
- 2. Search for the game on the *Search SteamGridDB* section and scroll through the results, selecting the one you want.
- 3. Ensure the *Name* and *Game ID* update in the **Per-App Exceptions** and press **Save and close**. The game should now update.
-
- ---
-
- ### Excluding Matches
-
- You may want to tell Steam ROM Manager to ignore some files (updates/DLC/etc.) that it finds in the directory. This is how you do so.
-
- 1. Hit the **Exclude Games** button in the bottom right.
- 2. Deselect the game you want to exclude, the poster artwork should go dim and the **Number Excluded** number should increment up. Repeat with any other exclusions you want to add.
- 3. Hit **Save Excludes** when you are happy with your selections.
- ---
-3. When you are happy with the results, select **Save to Steam** to save the results.
-1. The program will now start writing the entries into the Steam Library. You should get pop up notifications of the progress, but you can monitor the progress by selecting the **Log** on the left-hand side if needed.
-2. Restart Steam to have the changes take effect. Check your library to ensure that your games are there, in a category if you defined one in the parser.
-3. Try to launch a game and ensure everything is working. You are now good to go.
\ No newline at end of file
diff --git a/docs/user/CFW.md b/docs/user/CFW.md
new file mode 100644
index 0000000000..ea224d3d36
--- /dev/null
+++ b/docs/user/CFW.md
@@ -0,0 +1,11 @@
+# User Handbook - Custom Firmware (CFW)
+
+At the moment of writing, we do not support CFW such as Atmosphere, due to:
+
+- Lacking the required LLE emulation capabilities to properly emulate the full firmware.
+- Lack of implementation on some of the key internals.
+- Nobody has bothered to do it (PRs always welcome!)
+
+We do however, maintain HLE compatibility with the former mentioned CFW, applications that require Atmosphere to run will run fine in the emulator without any adjustments.
+
+If they don't run - then that's a bug!
diff --git a/docs/user/Graphics.md b/docs/user/Graphics.md
index e1e13a777d..ad359b9049 100644
--- a/docs/user/Graphics.md
+++ b/docs/user/Graphics.md
@@ -1,5 +1,7 @@
# User Handbook - Graphics
+Graphical enhancements and visual quality improvments. This doesn't cover texture mods.
+
## Visual Enhancements
### Anti-aliasing
@@ -89,7 +91,7 @@ The OpenGL backend would invoke behaviour that would result in swarst/LLVMpipe w
### HaikuOS compatibility
-HaikuOS bundles a Mesa library that doesn't support full core OpenGL 4.6 (required by the emulator). This leads to HaikuOS being one of the few computer platforms where Vulkan is the only available option for users. If OpenGL is desired, Mesa has to be built manually from source. For debugging purpouses `lavapipe` is recommended over the GPU driver; there is in-kernel support for NVIDIA cards through.
+HaikuOS bundles a Mesa library that doesn't support full core OpenGL 4.6 (required by the emulator). This leads to HaikuOS being one of the few computer platforms where Vulkan is the only available option for users. If OpenGL is desired, Mesa has to be built manually from source. For debugging purposes `lavapipe` is recommended over the GPU driver; there is in-kernel support for NVIDIA cards through.
### Fixes for Windows 10 and above having "Device loss"
diff --git a/docs/user/Mods.md b/docs/user/Mods.md
new file mode 100644
index 0000000000..11361d628c
--- /dev/null
+++ b/docs/user/Mods.md
@@ -0,0 +1,206 @@
+# User Handbook - Installing Mods
+
+## General Notes
+
+**Note:** When installing a mod, always read the mod's installation instructions.
+
+This is especially important if a mod uses a framework such as **ARCropolis**, **Skyline**, or **Atmosphere plugins**. In those cases, follow the framework's instructions instead of using Eden's normal mod folder.
+
+For example, **Super Smash Bros. Ultimate** uses such a framework. See the related section below for details.
+
+---
+
+# Installing Mods for Most Games
+
+1. Right click a game in the game list.
+2. Click **"Open Mod Data Location"**.
+3. Extract the mod into that folder.
+
+Each mod should be placed inside **its own subfolder**.
+
+---
+
+# Enabling or Disabling Mods
+
+1. Right click the game in the game list.
+2. Click **Configure Game**.
+3. In the **Add-Ons** tab, enable or disable mods, updates, and DLC by ticking or unticking their boxes.
+
+---
+
+# Important Note About SD Card Paths
+
+Some mods are designed for real Nintendo Switch consoles and refer to the **SD card root**.
+
+The emulated SD card is located at:
+
+```
+%AppData%\eden\sdmc
+```
+
+Example:
+
+```
+Switch instruction: sd:/ultimate/mods
+Eden equivalent: sdmc/ultimate/mods
+```
+
+---
+
+# Framework-Based Mods (Super Smash Bros. Ultimate)
+
+Some games require external mod frameworks instead of the built-in mod loader.
+
+The most common example is **Super Smash Bros. Ultimate**.
+
+These mods are installed directly to the **emulated SD card**, not the normal Eden mod folder.
+
+---
+
+# Installing the ARCropolis Modding Framework
+
+**Note:** Some mod packs bundle ARCropolis with their installer (for example, Smash Ult-S).
+
+---
+
+## 1. Download ARCropolis
+
+Download the latest release:
+
+https://github.com/Raytwo/ARCropolis/releases/
+
+---
+
+## 2. Install ARCropolis
+
+Extract the **`atmosphere`** folder into:
+
+```
+%AppData%\eden\sdmc
+```
+
+This is the **emulated SD card directory**.
+
+Verify installation by checking that the following file exists:
+
+```
+sdmc\atmosphere\contents\01006A800016E000\romfs\skyline\plugins\libarcropolis.nro
+```
+
+---
+
+## 3. Download Skyline
+
+Download the latest Skyline release:
+
+https://github.com/skyline-dev/skyline/releases
+
+Skyline used to be bundled with ARCropolis but is now distributed separately to avoid compatibility issues caused by outdated bundled versions.
+
+---
+
+## 4. Install Skyline
+
+Extract the **`exefs`** folder into:
+
+```
+sdmc\atmosphere\contents\01006A800016E000
+```
+
+The `exefs` folder should be **next to the `romfs` folder**.
+
+Verify installation by checking that the following file exists:
+
+```
+%AppData%\eden\sdmc\atmosphere\contents\01006A800016E000\exefs\subsdk9
+```
+
+---
+
+## 5. Launch the Game Once
+
+Start the game and make sure you see the **ARCropolis version text on the title screen**.
+
+This will also create the folders required for installing mods.
+
+---
+
+## 6. Install Smash Ultimate Mods
+
+Install mods inside:
+
+```
+sdmc\ultimate\mods
+```
+
+Each mod must be placed inside **its own subfolder**.
+
+Example:
+
+```
+sdmc\ultimate\mods\ExampleMod
+```
+
+---
+
+# Troubleshooting
+
+## ARCropolis text does not appear on startup
+
+Check the following:
+
+- `libarcropolis.nro` exists in:
+
+```
+sdmc\atmosphere\contents\01006A800016E000\romfs\skyline\plugins
+```
+
+- `subsdk9` exists in:
+
+```
+sdmc\atmosphere\contents\01006A800016E000\exefs
+```
+
+- Files were extracted to:
+
+```
+%AppData%\eden\sdmc
+```
+
+---
+
+## Mods are not loading
+
+Make sure mods are installed inside:
+
+```
+sdmc\ultimate\mods
+```
+
+Each mod must have its **own subfolder**.
+
+Correct example:
+
+```
+sdmc\ultimate\mods\ExampleMod
+```
+
+Incorrect example:
+
+```
+sdmc\ultimate\mods\ExampleMod\ExampleMod
+```
+
+---
+
+## Installing mods in the wrong folder
+
+ARCropolis mods **do not go in Eden's normal mod folder**.
+
+Do **not** install Smash mods here:
+
+```
+user\load\01006A800016E000
+```
+
+That folder is only used for traditional **RomFS mods**, not ARCropolis.
diff --git a/docs/user/README.md b/docs/user/README.md
index 5fd3a17e51..9804f4d62f 100644
--- a/docs/user/README.md
+++ b/docs/user/README.md
@@ -4,10 +4,14 @@ The "FAQ".
This handbook is primarily aimed at the end-user - baking useful knowledge for enhancing their emulation experience.
+A copy of this handbook is [available online](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/user/README.md).
+
## Basics
- **[The Basics](Basics.md)**
- **[Quickstart](./QuickStart.md)**
+- **[Settings](./Settings.md)**
+- **[Installing Mods](./Mods.md)**
- **[Run On macOS](./RunOnMacOS.md)**
- **[Audio](Audio.md)**
- **[Graphics](Graphics.md)**
@@ -17,22 +21,29 @@ This handbook is primarily aimed at the end-user - baking useful knowledge for e
- **[Using Amiibo](./UsingAmiibo.md)**
- **[Using Cheats](./UsingCheats.md)**
- **[Importing Saves](./ImportingSaves.md)**
-- **[Add Eden to Steam ROM Manager](./AddEdenToSRM.md)**
-- **[Add Games to Steam ROM Manager](./AddGamesToSRM.md)**
- **[Installing Atmosphere Mods](./InstallingAtmosphereMods.md)**
- **[Installing Updates & DLCs](./InstallingUpdatesDLC.md)**
- **[Controller Profiles](./ControllerProfiles.md)**
- **[Alter Date & Time](./AlterDateTime.md)**
+## 3rd-party Integration
+
+- **[Configuring Steam ROM Manager](./SteamROM.md)**
+- **[Server hosting](ServerHosting.md)**
+- **[Syncthing Guide](./SyncthingGuide.md)**
+- **[Third Party](./ThirdParty.md)**
+ - **[Obtainium](./ThirdParty.md#configuring-obtainium)**
+ - **[ES-DE](./ThirdParty.md#configuring-es-de)**
+ - **[Mirrors](./ThirdParty.md#mirrors)**
+
## Advanced
+- **[Custom Firmware](./CFW.md)**
- **[How To Access Logs](./HowToAccessLogs.md)**
- **[Gyro Controls](./GyroControls.md)**
- **[Platforms and Architectures](Architectures.md)**
-- **[Server hosting](ServerHosting.md)**
- **[Command Line](CommandLine.md)**
- **[Native Application Development](Native.md)**
- **[Adding Boolean Settings Toggles](AddingBooleanToggles.md)**
- **[Adding Debug Knobs](./AddingDebugKnobs.md)**
-- **[Syncthing Guide](./SyncthingGuide.md)**
- **[Testing](Testing.md)**
diff --git a/docs/user/Settings.md b/docs/user/Settings.md
new file mode 100644
index 0000000000..35fcd0c9ef
--- /dev/null
+++ b/docs/user/Settings.md
@@ -0,0 +1,54 @@
+# User Handbook - Settings
+
+As the emulator continues to grow, so does the number of settings that come and go.
+
+Most of the development adds new settings that enhance performance/compatibility, only to be removed later in newer versions due to newfound discoveries or because they were "a hacky workaround".
+
+As such, this guide will NOT mention those kind of settings, we'd rather mention settings which have a long shelf time (i.e won't get removed in future releases) and are likely to be unchanged.
+
+Some of the options are self explainatory, and they do exactly what they say they do (i.e "Pause when not in focus"); such options will be also skipped due to triviality.
+
+## Foreword
+
+Before touching the settings, please see the game boots with stock options. We try our best to ensure users can boot any game using the default settings. If they don't work, then you may try fiddling with options - but please, first use stock options.
+
+## General
+
+- `General/Force X11 as Graphics Backend`: Wayland on *NIX has prominent issues that are unlikely to be resolved; the kind that are "not our fault, it's Wayland issue", this "temporary" hack forces X11 as the backend, regardless of the desktop manager's default.
+- `General/Enable Gamemode`: This only does anything when you have Feral Interactive's Gamemode library installed somewhere, if you do, this will help boost FPS by telling the OS to explicitly prioritize *this* application for "gaming" - only for *NIX systems.
+- `Hotkeys`: Deceptively to remove a hotkey you must right click and a menu will appear to remove that specific hotkey.
+- `UI/Language`: Changes language *of the interface* NOT the emulated program!
+- `Debug/Enable Auto Stub`: May help to "fix" some games by just lying and saying that everything they do returns "success" instead of outright crashing for any function/service that is NOT implemented.
+- `Debug/Show log in console`: Does as said, note that the program may need to be reopened (Windows) for changes to take effect.
+- `Debug/Flush log output`: Classically, every write to the log is "buffered", that is, changes aren't written to the disk UNTIL the program has decided it is time to write, until then it keeps data in a buffer which resides on RAM. If the program crashes, the OS will automatically discard said buffer (any RAM associated with a dead process is automatically discarded/reused for some other purpose); this means critical data may not be logged to the disk on time, which may lead to missing log lines. Use this if you're wanting to remove that factor when debugging, sometimes a hard crash may "eat" some of the log lines IF this option isn't enabled.
+- `Debug/Disable Macro HLE:` The emulator has HLE emulation of macro programs for Maxwell, this means that some details are purpousefully skipped; this option forces all macro programs to be ran without skipping anything.
+
+## System
+
+- `System/RNG Seed`: Set to 0 (and uncheck) to disable ASLR systemwide (this makes mods like CTGP to stop working); by default it enables ASLR to replicate console behaviour.
+- `Network/Enable Airplane Mode`: Enable this if a game is crashing before loading AND the logs mention anything related to "web" or "internet" services.
+
+## CPU
+
+- `CPU/Virtual table bouncing`: Some games have the tendency to crash on loading due to an indirect bad jump (Pokemon ZA being the worst offender); this option lies to the game and tells it to just pretend it never executed a given function. This is fine for most casual users, but developers of switch applications **must** disable this. This temporary "hack" should hopefully be gone in 6-7 months from now on.
+- `Fastmem`, aka. `CPU/Enable Host MMU`: Enables "fastmem"; a detailed description of fastmem can be found [here](../dynarmic/Design.md#fast-memory-fastmem).
+- `CPU/Unsafe FMA`: Enables deliberate innacurate FMA behaviour which may affect how FMA returns any given operation - this may introduce tiny floating point errors which can cascade in sensitive code (i.e FFmpeg).
+- `CPU/Faster FRSQRTE and FRECPE`: Introduces accuracy errors on square root and reciprocals in exchange for less checks - this introduces inaccuracies with some cases but it's mostly safe.
+- `CPU/Faster ASIMD Instructions`: Skips rounding mode checks for ARM ASIMD instructions - this means some code dpeending on these rounding modes may misbehave.
+- `CPU/Disable address space checks`: Before each memory access, the emulator checks the address is in range, if not it faults; this option makes it so the emulator skips the check entirely (which may be expensive for a myriad of reasons). However at the same time this allows the guest program to "break out" of the emulation context by writing to arbitrary addresses.
+- `CPU/Ignore global monitor`: This relies on a quirk present on x86 to avoid the ARM global monitor emulation, this may increase performance in mutex-heavy contexts (i.e games waiting for next frames or such); but also can cause deadlocks and fun to debug issues.
+
+It is important to note the majority of precision-reducing instructions do not benefit cases where they are not used, which means the performance gains will vary per game.
+
+# Graphics
+
+See also [an extended breakdown of some options](./Graphics.md).
+
+- `Extras/Extended Dynamic State` and `Extras/Vertex Input Dynamic State`: These Vulkan extensions essentially allow you to reuse the same pipeline but just change the state between calls (so called "dynamic state"); the "extended" levels signifies how much state can be placed on this "dynamic" range, for example the amount of depth culling to use can be placed on the dynamic state, avoiding costly reloads and flushes. While this by itself is a fine option, SOME vendors (notably PowerVR and Mali) have problems with anything related to EDS3. EDS3 contains EDS2, and EDS2 contains EDS1. Essentially this means more extended data the driver has to keep track of, at the benefit of avoiding costly flushes.
+- `Advanced/Use persistent cache`: This saves compiled shaders onto the disk, independent of any driver's own disk saved shaders (yes, some drivers, notably NVIDIA, save a secondary shader cache onto disk) - disable this only if you're debugging or working on the GPU backend. This option is meant to massively help to reduce shader stutters (after playing for one session that compiles them).
+- `Advanced/Use Vulkan pipeline cache`: This is NOT the same as `Use persistent cache`; it's a separate flag that tells the Vulkan backend to create pipeline caches, which are a detail that can be used to massively improve performance and remove pipeline creation overhead. This is a Vulkan feature.
+
+## Controls
+
+Most of the controls should work out of the box. If not, please use a joystick calibrator to ensure it's not an issue with your own controller, for example:
+- https://github.com/dkosmari/calibrate-joystick
diff --git a/docs/user/AddEdenToSRM.md b/docs/user/SteamROM.md
similarity index 50%
rename from docs/user/AddEdenToSRM.md
rename to docs/user/SteamROM.md
index 4658bcf7e0..a782b51969 100644
--- a/docs/user/AddEdenToSRM.md
+++ b/docs/user/SteamROM.md
@@ -1,4 +1,6 @@
-# Importing Eden into Steam with Steam Rom Manager
+# User Handbook - Configuring Steam ROM Manager
+
+## Importing Eden into Steam with Steam Rom Manager
Use this when you want to import the Eden AppImage into your Steam Library along with artwork using *Steam ROM Manager.*
@@ -6,7 +8,7 @@ Use this when you want to import the Eden AppImage into your Steam Library along
---
-### Pre-Requisites
+#### Pre-Requisites
- Eden set up and configured
- Internet Connection
@@ -14,9 +16,9 @@ Use this when you want to import the Eden AppImage into your Steam Library along
---
-## Steps
+### Steps
-### Initial Setup
+#### Initial Setup
1. Press the **STEAM** button and then go to *Power → Switch to Desktop* to enter the Desktop mode.
@@ -24,14 +26,14 @@ Use this when you want to import the Eden AppImage into your Steam Library along
---
- ### Manual Installation
+ #### Manual Installation
1. Open the *Discover Store* and search for *Steam ROM Manager.*
2. Select the **Install** button to install the program.
---
- ### Installing Through *EmuDeck*
+ #### Installing Through *EmuDeck*
@@ -45,9 +47,9 @@ Use this when you want to import the Eden AppImage into your Steam Library along
---
-### Adding Eden into *Steam ROM Manager*
+#### Adding Eden into *Steam ROM Manager*
-### EmuDeck Users
+#### EmuDeck Users
EmuDeck will automatically create an *Emulators - Emulators* parser for ***Steam ROM Manager*** that uses shell scripts to launch them. We will follow this convention.
@@ -87,7 +89,7 @@ EmuDeck will automatically create an *Emulators - Emulators* parser for ***Steam
---
-### Non-EmuDeck Users
+#### Non-EmuDeck Users
We will need to create a new parser for the Emulators. Unlike with the EmuDeck model, we will have the parser look for AppImages.
@@ -126,7 +128,7 @@ We will need to create a new parser for the Emulators. Unlike with the EmuDeck
---
-### Adding Eden to Steam
+#### Adding Eden to Steam
Now that we have the parser or shell script created, we can actually add it to Steam.
@@ -137,7 +139,7 @@ Now that we have the parser or shell script created, we can actually add it to S
---
- ### Correcting a Mismatch
+ #### Correcting a Mismatch
If the emulator is not identified correctly, you may need to tell *Steam ROM Manager* what the game is manually.
@@ -147,7 +149,7 @@ Now that we have the parser or shell script created, we can actually add it to S
---
- ### Excluding Matches
+ #### Excluding Matches
You may want to tell Steam ROM Manager to ignore some files that it finds in the directory. This is how you do so.
@@ -159,4 +161,105 @@ Now that we have the parser or shell script created, we can actually add it to S
5. The program will now start writing the entries into the Steam Library. You should get pop up notifications of the progress, but you can monitor the progress by selecting the **Log** on the left-hand side if needed.
6. Restart Steam to have the changes take effect. Check your library to ensure that your games are there, in a category if you defined one in the parser.
-7. Try to launch the Emulator from Steam and ensure everything is working. You are now good to go.
\ No newline at end of file
+7. Try to launch the Emulator from Steam and ensure everything is working. You are now good to go.
+
+## Importing Games into Steam with Steam Rom Manager
+
+Use this when you want to import your games inside Eden into Steam to launch with artwork from Steam Game Mode without needing to launch Eden first.
+
+**Click [Here](https://evilperson1337.notion.site/Importing-Games-into-Steam-with-Steam-Rom-Manager-2b757c2edaf680d7a491c92b138f1fcc) for a version of this guide with images & visual elements.**
+
+---
+
+#### Pre-Requisites
+
+- Steam Deck Set up and Configured
+- Eden set up and Configured
+- Internet Access
+
+---
+
+### Steps
+
+1. Press the **STEAM** button and then go to *Power → Switch to Desktop* to enter the Desktop mode.
+
+1. Install ***Steam ROM Manager***, there are 2 ways you can accomplish this, either manually or through [*EmuDeck*](https://www.emudeck.com/#downloads).
+
+ ---
+
+ #### Manual Installation
+
+ 1. Open the *Discover Store* and search for *Steam ROM Manager.*
+ 2. Select the **Install** button to install the program.
+
+ ---
+
+ #### Installing Through *EmuDeck*
+
+
+
+ ***NOTE***: This assumes you have already set up EmuDeck, if not - just run through the guided installation and select *Steam ROM Manager* as one of the options.
+
+
+
+ 1. Open **EmuDeck**, then navigate to *Manage Emulators.*
+ 2. Scroll down to the bottom of the page to the *Manage your Tools & Frontends* section. Click **Steam ROM Manager**.
+
+ 3. Click the **Install** button on the right hand side to install it.
+
+ ---
+
+2. Open the Start Menu and Launch ***Steam ROM Manager***
+
+1. The program will now launch and show you a window with parsers.
+
+
+
+ ***TIP***: Your layout may look different depending on how you installed *Steam ROM Manager*. You may need to go to **Settings → Theme** and change it to *Classic* to follow along.
+
+
+
+2. Switch off all Parsers by hitting the *Toggle Parsers* switch.
+3. Scroll down the list on the left-hand side and look for a parser called *Nintendo Switch - Eden* and switch it on. This parser may not exist depending on how you installed *Steam ROM Manager* (EmuDeck creates it for you). Follow these steps to create it if it is missing.
+
+ ---
+ #### Creating the Eden Parser
+
+ 1. Select Create Parser and in the *Community Presets* option look for **Nintendo Switch - Yuzu**.
+ 2. Change the **Parser title** from *Nintendo Switch - Yuzu* to *Nintendo Switch - Eden.*
+ 3. Hit the **Browse** option under the *ROMs directory* section. Select the directory containing your Switch ROMs.
+ 4. Under *Steam collections*, you can add a Steam category name. This just organizes the games under a common category in your Steam Library, this is optional but recommended.
+ 5. Scroll down slightly to the **Executable Configuration → Executable**, select **Browse** and select the Eden AppImage.
+ 6. Leave everything else the same and hit **Save** to save the parser.
+ ---
+
+4. Click the Eden parser to view the options on the right, select **Test** at the bottom of the screen to ensure that *Steam ROM Manager* detects your games correctly.
+1. *Steam ROM Manager* will start to scan the specified ROMs directory and match them to games. Look over the results to ensure they are accurate. If you do not see any entries - check your parsers ROMs directory field.
+1. When you are happy with the results, click the **Add Games** → **Parse** to start the actual Parsing.
+1. The program will now identify the games and pull artwork from [*SteamGridDB*](https://www.steamgriddb.com/).
+2. Review the game matches and ensure everything is there.
+
+ ---
+
+ #### Correcting a Mismatch
+
+ If the game is not identified correctly, you may need to tell *Steam ROM Manager* what the game is manually.
+
+ 1. Hover over the game card and click the magnifying glass icon.
+ 2. Search for the game on the *Search SteamGridDB* section and scroll through the results, selecting the one you want.
+ 3. Ensure the *Name* and *Game ID* update in the **Per-App Exceptions** and press **Save and close**. The game should now update.
+
+ ---
+
+ #### Excluding Matches
+
+ You may want to tell Steam ROM Manager to ignore some files (updates/DLC/etc.) that it finds in the directory. This is how you do so.
+
+ 1. Hit the **Exclude Games** button in the bottom right.
+ 2. Deselect the game you want to exclude, the poster artwork should go dim and the **Number Excluded** number should increment up. Repeat with any other exclusions you want to add.
+ 3. Hit **Save Excludes** when you are happy with your selections.
+ ---
+3. When you are happy with the results, select **Save to Steam** to save the results.
+1. The program will now start writing the entries into the Steam Library. You should get pop up notifications of the progress, but you can monitor the progress by selecting the **Log** on the left-hand side if needed.
+2. Restart Steam to have the changes take effect. Check your library to ensure that your games are there, in a category if you defined one in the parser.
+3. Try to launch a game and ensure everything is working. You are now good to go.
diff --git a/docs/user/ThirdParty.md b/docs/user/ThirdParty.md
index af8942b49c..083542cd3e 100644
--- a/docs/user/ThirdParty.md
+++ b/docs/user/ThirdParty.md
@@ -7,3 +7,62 @@ While most of the links mentioned in this guide are relatively "safe"; we urge u
- [Nightly Eden builds](https://github.com/pflyly/eden-nightly)
- [NixOS Eden Flake](https://github.com/Grantimatter/eden-flake)
- [ES-DE Frontend Support](https://github.com/GlazedBelmont/es-de-android-custom-systems)
+
+## Mirrors
+
+The main origin repository is always at https://git.eden-emu.dev/eden-emu/eden.
+
+- https://github.com/eden-emulator/mirror
+- https://git.crueter.xyz/mirror/eden
+- https://collective.taymaerz.de/eden/eden
+
+Other mirrors obviously exist on the internet, but we can't guarantee their reliability and/or availability.
+
+If you're someone wanting to make a mirror, simply setup forgejo and automatically mirror from the origin repository. Or you could mirror a mirror to save us bandwidth... your choice!
+
+## Configuring Obtainium
+
+Very nice handy app, here's a quick rundown how to configure:
+
+1. Copy the URL: https://git.eden-emu.dev/eden-emu/eden/ (or one of your favourite mirrors)
+2. Open Obtainium and tap `Add App`.
+3. Paste the URL into the `App Source URL` field.
+4. Override Source: Look for the `Override Source` dropdown menu and select `Forgejo (Codeberg)`.
+5. Click `Add:` Obtainium should now be able to parse the releases and find the APK files.
+
+Note: Even though the site isn't Codeberg, it uses the same Forgejo/Gitea backend, and this setting tells Obtainium how to read the release data.
+
+## Configuring ES-DE
+
+### Method 1
+
+1. Download ZIP from [here](https://github.com/GlazedBelmont/es-de-android-custom-systems)
+2. Unzip the file and extract `es_systems.xml` and `es_find_rules.xml` to `\Odin2\Internal shared storage\ES-DE\custom_systems`.
+3. Press `Start -> Other Settings -> Alternative Emulators` and set it to Eden (Standalone).
+
+### Method 2
+
+1. Navigate to `\Odin2\Internal shared storage\ES-DE\custom_systems`.
+2. Add this to your `es_find_rules.xml`:
+
+```xml
+
+
+
+ dev.eden.eden_emulator/org.yuzu.yuzu_emu.activities.EmulationActivity
+
+
+
+
+
+
+ com.miHoYo.Yuanshen/org.yuzu.yuzu_emu.activities.EmulationActivity
+
+
+```
+
+3. Add this line of text to your `es_systems.xml` underneath where the rest of your switch system entries are:
+
+```xml
+%EMULATOR_EDEN% %ACTION%=android.nfc.action.TECH_DISCOVERED %DATA%=%ROMPROVIDER%
+```
diff --git a/shell.nix b/shell.nix
index d835b43ed1..d8257b88d9 100644
--- a/shell.nix
+++ b/shell.nix
@@ -9,7 +9,7 @@ pkgs.mkShellNoCC {
# libraries
openssl boost fmt nlohmann_json lz4 zlib zstd
enet libopus vulkan-headers vulkan-utility-libraries
- spirv-tools spirv-headers vulkan-loader unzip mbedtls
+ spirv-tools spirv-headers vulkan-loader unzip
glslang python3 httplib cpp-jwt ffmpeg-headless
libusb1 cubeb
# eden
diff --git a/src/android/app/build.gradle.kts b/src/android/app/build.gradle.kts
index 622ae53a77..3279a2202f 100644
--- a/src/android/app/build.gradle.kts
+++ b/src/android/app/build.gradle.kts
@@ -80,7 +80,6 @@ android {
listOf(
"-DENABLE_QT=0", // Don't use QT
"-DENABLE_WEB_SERVICE=1", // Enable web service
- "-DENABLE_OPENSSL=ON",
"-DANDROID_ARM_NEON=true", // cryptopp requires Neon to work
"-DYUZU_USE_CPM=ON",
"-DCPMUTIL_FORCE_BUNDLED=ON",
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/NativeLibrary.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/NativeLibrary.kt
index e49f466462..397b44c9f9 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/NativeLibrary.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/NativeLibrary.kt
@@ -152,6 +152,10 @@ object NativeLibrary {
external fun surfaceDestroyed()
+ external fun getAppletCaptureBuffer(): ByteArray
+ external fun getAppletCaptureWidth(): Int
+ external fun getAppletCaptureHeight(): Int
+
/**
* Unpauses emulation from a paused state.
*/
@@ -603,6 +607,12 @@ object NativeLibrary {
*/
external fun addFileToFilesystemProvider(path: String)
+ /**
+ * Adds a game-folder file to the manual filesystem provider, respecting the internal gate for
+ * game-folder external-content mounting.
+ */
+ external fun addGameFolderFileToFilesystemProvider(path: String)
+
/**
* Clears all files added to the manual filesystem provider in our EmulationSession instance
*/
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/activities/EmulationActivity.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/activities/EmulationActivity.kt
index 42d4f687f4..2764d7eac6 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/activities/EmulationActivity.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/activities/EmulationActivity.kt
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: 2023 yuzu Emulator Project
@@ -204,9 +204,9 @@ class EmulationActivity : AppCompatActivity(), SensorEventListener, InputManager
}
override fun onPause() {
- super.onPause()
nfcReader.stopScanning()
stopMotionSensorListener()
+ super.onPause()
}
override fun onDestroy() {
@@ -339,6 +339,10 @@ class EmulationActivity : AppCompatActivity(), SensorEventListener, InputManager
}
override fun onSensorChanged(event: SensorEvent) {
+ if (!NativeLibrary.isRunning() || NativeLibrary.isPaused()) {
+ return
+ }
+
val rotation = this.display?.rotation
if (rotation == Surface.ROTATION_90) {
flipMotionOrientation = true
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/fetcher/SpacingItemDecoration.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/fetcher/SpacingItemDecoration.kt
index f3d000a739..b3ffcc2a35 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/fetcher/SpacingItemDecoration.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/fetcher/SpacingItemDecoration.kt
@@ -1,10 +1,11 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
package org.yuzu.yuzu_emu.features.fetcher
import android.graphics.Rect
import android.view.View
+import androidx.recyclerview.widget.GridLayoutManager
import androidx.recyclerview.widget.RecyclerView
class SpacingItemDecoration(private val spacing: Int) : RecyclerView.ItemDecoration() {
@@ -15,8 +16,20 @@ class SpacingItemDecoration(private val spacing: Int) : RecyclerView.ItemDecorat
state: RecyclerView.State
) {
outRect.bottom = spacing
- if (parent.getChildAdapterPosition(view) == 0) {
+
+ val position = parent.getChildAdapterPosition(view)
+ if (position == RecyclerView.NO_POSITION) return
+
+ if (position == 0) {
outRect.top = spacing
+ return
+ }
+
+ // If the item is in the first row, but NOT in first column add top spacing as well
+ val layoutManager = parent.layoutManager
+ if (layoutManager is GridLayoutManager && layoutManager.spanSizeLookup.getSpanGroupIndex(position, layoutManager.spanCount) == 0) {
+ outRect.top = spacing
+ return
}
}
}
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/model/IntSetting.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/model/IntSetting.kt
index a24a2e1776..4c70d2b35b 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/model/IntSetting.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/model/IntSetting.kt
@@ -34,6 +34,7 @@ enum class IntSetting(override val key: String) : AbstractIntSetting {
MAX_ANISOTROPY("max_anisotropy"),
THEME("theme"),
THEME_MODE("theme_mode"),
+ STATIC_THEME_COLOR("static_theme_color"),
APP_LANGUAGE("app_language"),
OVERLAY_SCALE("control_scale"),
OVERLAY_OPACITY("control_opacity"),
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/ui/SettingsDialogFragment.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/ui/SettingsDialogFragment.kt
index f66f4bac7f..4dcb35c010 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/ui/SettingsDialogFragment.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/ui/SettingsDialogFragment.kt
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: 2023 yuzu Emulator Project
@@ -68,7 +68,9 @@ class SettingsDialogFragment : DialogFragment(), DialogInterface.OnClickListener
MaterialAlertDialogBuilder(requireContext())
.setMessage(R.string.reset_setting_confirmation)
.setPositiveButton(android.R.string.ok) { _: DialogInterface, _: Int ->
- when (val item = settingsViewModel.clickedItem) {
+ val item = settingsViewModel.clickedItem ?: return@setPositiveButton
+ clearDialogState()
+ when (item) {
is AnalogInputSetting -> {
val stickParam = NativeInput.getStickParam(
item.playerIndex,
@@ -107,12 +109,17 @@ class SettingsDialogFragment : DialogFragment(), DialogInterface.OnClickListener
}
else -> {
- settingsViewModel.clickedItem!!.setting.reset()
+ item.setting.reset()
settingsViewModel.setAdapterItemChanged(position)
}
}
}
- .setNegativeButton(android.R.string.cancel, null)
+ .setNegativeButton(android.R.string.cancel) { _: DialogInterface, _: Int ->
+ clearDialogState()
+ }
+ .setOnCancelListener {
+ clearDialogState()
+ }
.create()
}
@@ -186,27 +193,6 @@ class SettingsDialogFragment : DialogFragment(), DialogInterface.OnClickListener
updateButtonState(isValid)
}
- /*
- * xbzk: these two events, along with attachRepeat feature,
- * were causing spinbox buttons to respond twice per press
- * cutting these out to retain accelerated press functionality
- * TODO: clean this out later if no issues arise
- *
- spinboxBinding.buttonDecrement.setOnClickListener {
- val current = spinboxBinding.editValue.text.toString().toIntOrNull() ?: currentValue
- val newValue = current - 1
- spinboxBinding.editValue.setText(newValue.toString())
- updateValidity(newValue)
- }
-
- spinboxBinding.buttonIncrement.setOnClickListener {
- val current = spinboxBinding.editValue.text.toString().toIntOrNull() ?: currentValue
- val newValue = current + 1
- spinboxBinding.editValue.setText(newValue.toString())
- updateValidity(newValue)
- }
- */
-
fun attachRepeat(button: View, delta: Int) {
val handler = Handler(Looper.getMainLooper())
var runnable: Runnable? = null
@@ -439,9 +425,13 @@ class SettingsDialogFragment : DialogFragment(), DialogInterface.OnClickListener
private fun closeDialog() {
settingsViewModel.setAdapterItemChanged(position)
+ clearDialogState()
+ dismiss()
+ }
+
+ private fun clearDialogState() {
settingsViewModel.clickedItem = null
settingsViewModel.setSliderProgress(-1f)
- dismiss()
}
private fun getValueForSingleChoiceSelection(item: SingleChoiceSetting, which: Int): Int {
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/ui/SettingsFragmentPresenter.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/ui/SettingsFragmentPresenter.kt
index 332617804e..77104e0614 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/ui/SettingsFragmentPresenter.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/features/settings/ui/SettingsFragmentPresenter.kt
@@ -1066,7 +1066,10 @@ class SettingsFragmentPresenter(
IntSetting.THEME.getValueAsString()
override val defaultValue: Int = IntSetting.THEME.defaultValue
- override fun reset() = IntSetting.THEME.setInt(defaultValue)
+ override fun reset() {
+ IntSetting.THEME.setInt(defaultValue)
+ settingsViewModel.setShouldRecreate(true)
+ }
}
add(HeaderSetting(R.string.app_settings))
@@ -1124,23 +1127,24 @@ class SettingsFragmentPresenter(
}
val staticThemeColor: AbstractIntSetting = object : AbstractIntSetting {
- val preferences = PreferenceManager.getDefaultSharedPreferences(
- YuzuApplication.appContext
- )
override fun getInt(needsGlobal: Boolean): Int =
- preferences.getInt(Settings.PREF_STATIC_THEME_COLOR, 0)
+ IntSetting.STATIC_THEME_COLOR.getInt(needsGlobal)
+
override fun setInt(value: Int) {
- preferences.edit() { putInt(Settings.PREF_STATIC_THEME_COLOR, value) }
+ IntSetting.STATIC_THEME_COLOR.setInt(value)
settingsViewModel.setShouldRecreate(true)
}
- override val key: String = Settings.PREF_STATIC_THEME_COLOR
+ override val key: String = IntSetting.STATIC_THEME_COLOR.key
override val isRuntimeModifiable: Boolean = true
+
override fun getValueAsString(needsGlobal: Boolean): String =
- preferences.getInt(Settings.PREF_STATIC_THEME_COLOR, 0).toString()
- override val defaultValue: Any = 0
+ IntSetting.STATIC_THEME_COLOR.getValueAsString(needsGlobal)
+
+ override val defaultValue: Any = IntSetting.STATIC_THEME_COLOR.defaultValue
+
override fun reset() {
- preferences.edit() { putInt(Settings.PREF_STATIC_THEME_COLOR, 0) }
+ IntSetting.STATIC_THEME_COLOR.reset()
settingsViewModel.setShouldRecreate(true)
}
}
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/EmulationFragment.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/EmulationFragment.kt
index e8739e2d23..435fe5fe2c 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/EmulationFragment.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/EmulationFragment.kt
@@ -15,6 +15,7 @@ import android.content.Intent
import android.content.IntentFilter
import android.content.pm.ActivityInfo
import android.content.res.Configuration
+import android.graphics.Bitmap
import android.net.Uri
import android.os.BatteryManager
import android.os.BatteryManager.*
@@ -97,6 +98,7 @@ import org.yuzu.yuzu_emu.utils.collect
import org.yuzu.yuzu_emu.utils.CustomSettingsHandler
import java.io.ByteArrayOutputStream
import java.io.File
+import java.nio.ByteBuffer
import kotlin.coroutines.resume
import kotlin.coroutines.suspendCoroutine
import kotlin.or
@@ -141,6 +143,7 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
private var wasInputOverlayAutoHidden = false
private var overlayTouchActive = false
+ private var pausedFrameBitmap: Bitmap? = null
var shouldUseCustom = false
private var isQuickSettingsMenuOpen = false
@@ -703,6 +706,12 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
binding.inGameMenu.menu.findItem(R.id.menu_quick_settings)?.isVisible =
BooleanSetting.ENABLE_QUICK_SETTINGS.getBoolean()
+ binding.pausedIcon.setOnClickListener {
+ if (this::emulationState.isInitialized && emulationState.isPaused) {
+ resumeEmulationFromUi()
+ }
+ }
+
binding.inGameMenu.menu.findItem(R.id.menu_lock_drawer).apply {
val lockMode = IntSetting.LOCK_DRAWER.getInt()
val titleId = if (lockMode == DrawerLayout.LOCK_MODE_LOCKED_CLOSED) {
@@ -728,11 +737,9 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
when (it.itemId) {
R.id.menu_pause_emulation -> {
if (emulationState.isPaused) {
- emulationState.run(false)
- updatePauseMenuEntry(false)
+ resumeEmulationFromUi()
} else {
- emulationState.pause()
- updatePauseMenuEntry(true)
+ pauseEmulationAndCaptureFrame()
}
binding.inGameMenu.requestFocus()
true
@@ -826,6 +833,7 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
}
R.id.menu_exit -> {
+ clearPausedFrame()
emulationState.stop()
NativeConfig.reloadGlobalConfig()
emulationViewModel.setIsEmulationStopping(true)
@@ -1197,6 +1205,71 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
}
}
+ private fun pauseEmulationAndCaptureFrame() {
+ emulationState.pause()
+ updatePauseMenuEntry(true)
+ capturePausedFrameFromCore()
+ updatePausedFrameVisibility()
+ }
+
+ private fun capturePausedFrameFromCore() {
+ lifecycleScope.launch(Dispatchers.Default) {
+ val frameData = NativeLibrary.getAppletCaptureBuffer()
+ val width = NativeLibrary.getAppletCaptureWidth()
+ val height = NativeLibrary.getAppletCaptureHeight()
+ if (frameData.isEmpty() || width <= 0 || height <= 0) {
+ Log.warning(
+ "[EmulationFragment] Paused frame capture returned empty/invalid data. " +
+ "size=${frameData.size}, width=$width, height=$height"
+ )
+ return@launch
+ }
+
+ val expectedSize = width * height * 4
+ if (frameData.size < expectedSize) {
+ Log.warning(
+ "[EmulationFragment] Paused frame buffer smaller than expected. " +
+ "size=${frameData.size}, expected=$expectedSize"
+ )
+ return@launch
+ }
+
+ val bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888)
+ bitmap.copyPixelsFromBuffer(ByteBuffer.wrap(frameData, 0, expectedSize))
+
+ withContext(Dispatchers.Main) {
+ pausedFrameBitmap?.recycle()
+ pausedFrameBitmap = bitmap
+ updatePausedFrameVisibility()
+ }
+ }
+ }
+
+ private fun updatePausedFrameVisibility() {
+ val b = _binding ?: return
+ val showPausedUi = this::emulationState.isInitialized && emulationState.isPaused
+ b.pausedIcon.setVisible(showPausedUi)
+
+ val bitmap = if (showPausedUi) pausedFrameBitmap else null
+ b.pausedFrameImage.setImageBitmap(bitmap)
+ b.pausedFrameImage.setVisible(bitmap != null)
+ }
+
+ private fun resumeEmulationFromUi() {
+ clearPausedFrame()
+ emulationState.resume()
+ updatePauseMenuEntry(emulationState.isPaused)
+ updatePausedFrameVisibility()
+ }
+
+ private fun clearPausedFrame() {
+ val b = _binding
+ b?.pausedFrameImage?.setVisible(false)
+ b?.pausedFrameImage?.setImageDrawable(null)
+ pausedFrameBitmap?.recycle()
+ pausedFrameBitmap = null
+ }
+
private fun handleLoadAmiiboSelection(): Boolean {
val binding = _binding ?: return true
@@ -1290,8 +1363,9 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
override fun onPause() {
if (this::emulationState.isInitialized) {
if (emulationState.isRunning && emulationActivity?.isInPictureInPictureMode != true) {
- emulationState.pause()
- updatePauseMenuEntry(true)
+ pauseEmulationAndCaptureFrame()
+ } else {
+ updatePausedFrameVisibility()
}
}
super.onPause()
@@ -1301,6 +1375,7 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
super.onDestroyView()
amiiboLoadJob?.cancel()
amiiboLoadJob = null
+ clearPausedFrame()
_binding?.surfaceInputOverlay?.touchEventListener = null
_binding = null
isAmiiboPickerOpen = false
@@ -1321,6 +1396,7 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
b.inGameMenu.post {
if (!this::emulationState.isInitialized || _binding == null) return@post
updatePauseMenuEntry(emulationState.isPaused)
+ updatePausedFrameVisibility()
}
}
@@ -1760,6 +1836,7 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
// Only update surface reference, don't trigger state changes
emulationState.updateSurfaceReference(holder.surface)
}
+ updatePausedFrameVisibility()
}
override fun surfaceDestroyed(holder: SurfaceHolder) {
@@ -2090,6 +2167,29 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
}
}
+ @Synchronized
+ fun resume() {
+ if (state != State.PAUSED) {
+ Log.warning("[EmulationFragment] Resume called while emulation is not paused.")
+ return
+ }
+ if (!emulationCanStart.invoke()) {
+ Log.warning("[EmulationFragment] Resume blocked by emulationCanStart check.")
+ return
+ }
+ val currentSurface = surface
+ if (currentSurface == null || !currentSurface.isValid) {
+ Log.debug("[EmulationFragment] Resume requested with invalid surface.")
+ return
+ }
+
+ NativeLibrary.surfaceChanged(currentSurface)
+ Log.debug("[EmulationFragment] Resuming emulation.")
+ NativeLibrary.unpauseEmulation()
+ NativeLibrary.playTimeManagerStart()
+ state = State.RUNNING
+ }
+
@Synchronized
fun changeProgram(programIndex: Int) {
emulationThread.join()
@@ -2111,7 +2211,7 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
@Synchronized
fun updateSurface() {
- if (surface != null) {
+ if (surface != null && state == State.RUNNING) {
NativeLibrary.surfaceChanged(surface)
}
}
@@ -2127,20 +2227,20 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
@Synchronized
fun clearSurface() {
if (surface == null) {
- Log.warning("[EmulationFragment] clearSurface called, but surface already null.")
+ Log.debug("[EmulationFragment] clearSurface called, but surface already null.")
} else {
+ if (state == State.RUNNING) {
+ pause()
+ }
+ NativeLibrary.surfaceDestroyed()
surface = null
Log.debug("[EmulationFragment] Surface destroyed.")
when (state) {
- State.RUNNING -> {
- state = State.PAUSED
- }
-
- State.PAUSED -> Log.warning(
+ State.PAUSED -> Log.debug(
"[EmulationFragment] Surface cleared while emulation paused."
)
- else -> Log.warning(
+ else -> Log.debug(
"[EmulationFragment] Surface cleared while emulation stopped."
)
}
@@ -2148,29 +2248,35 @@ class EmulationFragment : Fragment(), SurfaceHolder.Callback {
}
private fun runWithValidSurface(programIndex: Int = 0) {
- NativeLibrary.surfaceChanged(surface)
if (!emulationCanStart.invoke()) {
return
}
+ val currentSurface = surface
+ if (currentSurface == null || !currentSurface.isValid) {
+ Log.debug("[EmulationFragment] runWithValidSurface called with invalid surface.")
+ return
+ }
when (state) {
State.STOPPED -> {
+ NativeLibrary.surfaceChanged(currentSurface)
emulationThread = Thread({
Log.debug("[EmulationFragment] Starting emulation thread.")
NativeLibrary.run(gamePath, programIndex, true)
}, "NativeEmulation")
emulationThread.start()
+ state = State.RUNNING
}
State.PAUSED -> {
- Log.debug("[EmulationFragment] Resuming emulation.")
- NativeLibrary.unpauseEmulation()
- NativeLibrary.playTimeManagerStart()
+ Log.debug(
+ "[EmulationFragment] Surface restored while emulation paused; " +
+ "waiting for explicit resume."
+ )
}
else -> Log.debug("[EmulationFragment] Bug, run called while already running.")
}
- state = State.RUNNING
}
private enum class State {
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/model/AddonViewModel.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/model/AddonViewModel.kt
index c682a13cfc..2a0e72be26 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/model/AddonViewModel.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/model/AddonViewModel.kt
@@ -127,10 +127,6 @@ class AddonViewModel : ViewModel() {
return
}
- // Check if there are multiple update versions
- val updates = _patchList.value.filter { PatchType.from(it.type) == PatchType.Update }
- val hasMultipleUpdates = updates.size > 1
-
NativeConfig.setDisabledAddons(
game!!.programId,
_patchList.value.mapNotNull {
@@ -140,7 +136,7 @@ class AddonViewModel : ViewModel() {
if (PatchType.from(it.type) == PatchType.Update) {
if (it.name.contains("(NAND)") || it.name.contains("(SDMC)")) {
it.name
- } else if (hasMultipleUpdates) {
+ } else if (it.numericVersion != 0L) {
"Update@${it.numericVersion}"
} else {
it.name
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/overlay/InputOverlay.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/overlay/InputOverlay.kt
index e18077c673..d3b5d86174 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/overlay/InputOverlay.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/overlay/InputOverlay.kt
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
package org.yuzu.yuzu_emu.overlay
@@ -20,7 +20,6 @@ import android.os.Looper
import android.util.AttributeSet
import android.view.HapticFeedbackConstants
import android.view.MotionEvent
-import android.view.SurfaceView
import android.view.View
import android.view.View.OnTouchListener
import android.view.WindowInsets
@@ -42,10 +41,10 @@ import org.yuzu.yuzu_emu.utils.NativeConfig
/**
* Draws the interactive input overlay on top of the
- * [SurfaceView] that is rendering emulation.
+ * emulation rendering surface.
*/
class InputOverlay(context: Context, attrs: AttributeSet?) :
- SurfaceView(context, attrs),
+ View(context, attrs),
OnTouchListener {
private val overlayButtons: MutableSet = HashSet()
private val overlayDpads: MutableSet = HashSet()
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/ui/main/MainActivity.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/ui/main/MainActivity.kt
index 8a4262ebe7..db4cc0f60e 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/ui/main/MainActivity.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/ui/main/MainActivity.kt
@@ -424,7 +424,9 @@ class MainActivity : AppCompatActivity(), ThemeProvider {
)
val uriString = result.toString()
- val folder = gamesViewModel.folders.value.firstOrNull { it.uriString == uriString }
+ val folder = gamesViewModel.folders.value.firstOrNull {
+ it.uriString == uriString && it.type == org.yuzu.yuzu_emu.model.DirectoryType.EXTERNAL_CONTENT
+ }
if (folder != null) {
Toast.makeText(
applicationContext,
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/DirectoryInitialization.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/DirectoryInitialization.kt
index 6318aa71f2..f47c60491b 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/DirectoryInitialization.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/DirectoryInitialization.kt
@@ -61,6 +61,12 @@ object DirectoryInitialization {
saveConfig = true
}
+ val staticThemeColor = preferences.migratePreference(Settings.PREF_STATIC_THEME_COLOR)
+ if (staticThemeColor != null) {
+ IntSetting.STATIC_THEME_COLOR.setInt(staticThemeColor)
+ saveConfig = true
+ }
+
val blackBackgrounds =
preferences.migratePreference(Settings.PREF_BLACK_BACKGROUNDS)
if (blackBackgrounds != null) {
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GameHelper.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GameHelper.kt
index fff5fdfb9b..4a3cf61daa 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GameHelper.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/GameHelper.kt
@@ -51,11 +51,24 @@ object GameHelper {
// Scan External Content directories and register all NSP/XCI files
val externalContentDirs = NativeConfig.getExternalContentDirs()
- for (externalDir in externalContentDirs) {
+ val uniqueExternalContentDirs = linkedSetOf()
+ externalContentDirs.forEach { externalDir ->
+ if (externalDir.isNotEmpty()) {
+ uniqueExternalContentDirs.add(externalDir)
+ }
+ }
+
+ val mountedContainerUris = mutableSetOf()
+ for (externalDir in uniqueExternalContentDirs) {
if (externalDir.isNotEmpty()) {
val externalDirUri = externalDir.toUri()
if (FileUtil.isTreeUriValid(externalDirUri)) {
- scanExternalContentRecursive(FileUtil.listFiles(externalDirUri), 3)
+ scanContentContainersRecursive(FileUtil.listFiles(externalDirUri), 3) {
+ val containerUri = it.uri.toString()
+ if (mountedContainerUris.add(containerUri)) {
+ NativeLibrary.addFileToFilesystemProvider(containerUri)
+ }
+ }
}
}
}
@@ -65,10 +78,13 @@ object GameHelper {
val gameDirUri = gameDir.uriString.toUri()
val isValid = FileUtil.isTreeUriValid(gameDirUri)
if (isValid) {
+ val scanDepth = if (gameDir.deepScan) 3 else 1
+
addGamesRecursive(
games,
FileUtil.listFiles(gameDirUri),
- if (gameDir.deepScan) 3 else 1
+ scanDepth,
+ mountedContainerUris
)
} else {
badDirs.add(index)
@@ -103,9 +119,10 @@ object GameHelper {
// be done better imo.
private val externalContentExtensions = setOf("nsp", "xci")
- private fun scanExternalContentRecursive(
+ private fun scanContentContainersRecursive(
files: Array,
- depth: Int
+ depth: Int,
+ onContainerFound: (MinimalDocumentFile) -> Unit
) {
if (depth <= 0) {
return
@@ -113,14 +130,15 @@ object GameHelper {
files.forEach {
if (it.isDirectory) {
- scanExternalContentRecursive(
+ scanContentContainersRecursive(
FileUtil.listFiles(it.uri),
- depth - 1
+ depth - 1,
+ onContainerFound
)
} else {
val extension = FileUtil.getExtension(it.uri).lowercase()
if (externalContentExtensions.contains(extension)) {
- NativeLibrary.addFileToFilesystemProvider(it.uri.toString())
+ onContainerFound(it)
}
}
}
@@ -129,7 +147,8 @@ object GameHelper {
private fun addGamesRecursive(
games: MutableList,
files: Array,
- depth: Int
+ depth: Int,
+ mountedContainerUris: MutableSet
) {
if (depth <= 0) {
return
@@ -140,11 +159,20 @@ object GameHelper {
addGamesRecursive(
games,
FileUtil.listFiles(it.uri),
- depth - 1
+ depth - 1,
+ mountedContainerUris
)
} else {
- if (Game.extensions.contains(FileUtil.getExtension(it.uri))) {
- val game = getGame(it.uri, true)
+ val extension = FileUtil.getExtension(it.uri).lowercase()
+ val filePath = it.uri.toString()
+
+ if (externalContentExtensions.contains(extension) &&
+ mountedContainerUris.add(filePath)) {
+ NativeLibrary.addGameFolderFileToFilesystemProvider(filePath)
+ }
+
+ if (Game.extensions.contains(extension)) {
+ val game = getGame(it.uri, true, false)
if (game != null) {
games.add(game)
}
@@ -153,14 +181,20 @@ object GameHelper {
}
}
- fun getGame(uri: Uri, addedToLibrary: Boolean): Game? {
+ fun getGame(
+ uri: Uri,
+ addedToLibrary: Boolean,
+ registerFilesystemProvider: Boolean = true
+ ): Game? {
val filePath = uri.toString()
if (!GameMetadata.getIsValid(filePath)) {
return null
}
- // Needed to update installed content information
- NativeLibrary.addFileToFilesystemProvider(filePath)
+ if (registerFilesystemProvider) {
+ // Needed to update installed content information
+ NativeLibrary.addFileToFilesystemProvider(filePath)
+ }
var name = GameMetadata.getTitle(filePath)
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/PathUtil.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/PathUtil.kt
index a840b3b846..744e1d149c 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/PathUtil.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/PathUtil.kt
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
package org.yuzu.yuzu_emu.utils
@@ -80,16 +80,14 @@ object PathUtil {
}
}
- // This really shouldn't be necessary, but the Android API seemingly
- // doesn't have a way of doing this?
- // Apparently, on certain devices the mount location can vary, so add
- // extra cases here if we discover any new ones.
fun getRemovableStoragePath(idString: String): String? {
- var pathFile: File
+ val possibleMountPaths = listOf("/mnt/media_rw/$idString", "/storage/$idString")
- pathFile = File("/mnt/media_rw/$idString");
- if (pathFile.exists()) {
- return pathFile.absolutePath
+ for (mountPath in possibleMountPaths) {
+ val pathFile = File(mountPath);
+ if (pathFile.exists()) {
+ return pathFile.absolutePath
+ }
}
return null
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/ThemeHelper.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/ThemeHelper.kt
index 3e138c0244..83335b5e1c 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/ThemeHelper.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/utils/ThemeHelper.kt
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
package org.yuzu.yuzu_emu.utils
@@ -52,7 +52,7 @@ object ThemeHelper {
}
private fun getSelectedStaticThemeColor(): Int {
- val themeIndex = preferences.getInt(Settings.PREF_STATIC_THEME_COLOR, 0)
+ val themeIndex = IntSetting.STATIC_THEME_COLOR.getInt(false)
val themes = arrayOf(
R.style.Theme_Eden_Main,
R.style.Theme_Yuzu_Main_Violet,
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/views/GradientBorderCardView.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/views/GradientBorderCardView.kt
index 8121cfb6fa..d6c0709d57 100644
--- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/views/GradientBorderCardView.kt
+++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/views/GradientBorderCardView.kt
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: 2023 yuzu Emulator Project
@@ -11,8 +11,7 @@ import android.graphics.*
import android.util.AttributeSet
import com.google.android.material.card.MaterialCardView
import org.yuzu.yuzu_emu.R
-import org.yuzu.yuzu_emu.features.settings.model.Settings
-import androidx.preference.PreferenceManager
+import org.yuzu.yuzu_emu.features.settings.model.IntSetting
class GradientBorderCardView @JvmOverloads constructor(
context: Context,
@@ -44,12 +43,7 @@ class GradientBorderCardView @JvmOverloads constructor(
}
private fun updateThemeState() {
- val prefs = PreferenceManager.getDefaultSharedPreferences(context)
- val themeIndex = try {
- prefs.getInt(Settings.PREF_STATIC_THEME_COLOR, 0)
- } catch (e: Exception) {
- 0 // Default to Eden theme if error
- }
+ val themeIndex = IntSetting.STATIC_THEME_COLOR.getInt(false)
isEdenTheme = themeIndex == 0
invalidate()
}
diff --git a/src/android/app/src/main/jni/CMakeLists.txt b/src/android/app/src/main/jni/CMakeLists.txt
index 6cdacea320..c68e206d24 100644
--- a/src/android/app/src/main/jni/CMakeLists.txt
+++ b/src/android/app/src/main/jni/CMakeLists.txt
@@ -1,4 +1,4 @@
-# SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+# SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
# SPDX-License-Identifier: GPL-3.0-or-later
# SPDX-FileCopyrightText: 2023 yuzu Emulator Project
@@ -27,10 +27,7 @@ if (ARCHITECTURE_arm64)
target_link_libraries(yuzu-android PRIVATE adrenotools)
endif()
-if (ENABLE_OPENSSL OR ENABLE_WEB_SERVICE)
- target_link_libraries(yuzu-android PRIVATE OpenSSL::SSL cpp-jwt::cpp-jwt)
-endif()
-
+target_link_libraries(yuzu-android PRIVATE OpenSSL::SSL cpp-jwt::cpp-jwt)
if (ENABLE_UPDATE_CHECKER)
target_compile_definitions(yuzu-android PUBLIC ENABLE_UPDATE_CHECKER)
endif()
diff --git a/src/android/app/src/main/jni/android_config.cpp b/src/android/app/src/main/jni/android_config.cpp
index 0171e2a7b3..0c5696ef3f 100644
--- a/src/android/app/src/main/jni/android_config.cpp
+++ b/src/android/app/src/main/jni/android_config.cpp
@@ -33,6 +33,12 @@ void AndroidConfig::ReadAndroidValues() {
if (global) {
ReadAndroidUIValues();
ReadUIValues();
+ BeginGroup(Settings::TranslateCategory(Settings::Category::DataStorage));
+ Settings::values.ext_content_from_game_dirs = ReadBooleanSetting(
+ std::string("ext_content_from_game_dirs"),
+ std::make_optional(
+ Settings::values.ext_content_from_game_dirs.GetDefault()));
+ EndGroup();
ReadOverlayValues();
}
ReadDriverValues();
diff --git a/src/android/app/src/main/jni/android_settings.h b/src/android/app/src/main/jni/android_settings.h
index 4090330d78..606ce2ce84 100644
--- a/src/android/app/src/main/jni/android_settings.h
+++ b/src/android/app/src/main/jni/android_settings.h
@@ -56,6 +56,7 @@ namespace AndroidSettings {
Settings::Setting theme{linkage, 0, "theme", Settings::Category::Android};
Settings::Setting theme_mode{linkage, -1, "theme_mode", Settings::Category::Android};
+ Settings::Setting static_theme_color{linkage, 5, "static_theme_color", Settings::Category::Android};
Settings::Setting black_backgrounds{linkage, false, "black_backgrounds",
Settings::Category::Android};
Settings::Setting app_language{linkage, 0, "app_language", Settings::Category::Android};
diff --git a/src/android/app/src/main/jni/emu_window/emu_window.cpp b/src/android/app/src/main/jni/emu_window/emu_window.cpp
index 06db553691..4e90cad570 100644
--- a/src/android/app/src/main/jni/emu_window/emu_window.cpp
+++ b/src/android/app/src/main/jni/emu_window/emu_window.cpp
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: 2023 yuzu Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
@@ -14,6 +17,14 @@
#include "jni/native.h"
void EmuWindow_Android::OnSurfaceChanged(ANativeWindow* surface) {
+ if (!surface) {
+ LOG_INFO(Frontend, "EmuWindow_Android::OnSurfaceChanged received null surface");
+ m_window_width = 0;
+ m_window_height = 0;
+ window_info.render_surface = nullptr;
+ return;
+ }
+
m_window_width = ANativeWindow_getWidth(surface);
m_window_height = ANativeWindow_getHeight(surface);
diff --git a/src/android/app/src/main/jni/game_metadata.cpp b/src/android/app/src/main/jni/game_metadata.cpp
index e9c03b6440..9acba456f1 100644
--- a/src/android/app/src/main/jni/game_metadata.cpp
+++ b/src/android/app/src/main/jni/game_metadata.cpp
@@ -96,6 +96,11 @@ jboolean Java_org_yuzu_yuzu_1emu_utils_GameMetadata_getIsValid(JNIEnv* env, jobj
return false;
}
+ if ((file_type == Loader::FileType::NSP || file_type == Loader::FileType::XCI) &&
+ !Loader::IsBootableGameContainer(file, file_type)) {
+ return false;
+ }
+
u64 program_id = 0;
Loader::ResultStatus res = loader->ReadProgramId(program_id);
if (res != Loader::ResultStatus::Success) {
diff --git a/src/android/app/src/main/jni/native.cpp b/src/android/app/src/main/jni/native.cpp
index 2e50bb1069..3f0029c78a 100644
--- a/src/android/app/src/main/jni/native.cpp
+++ b/src/android/app/src/main/jni/native.cpp
@@ -89,6 +89,8 @@
#include "jni/native.h"
#include "video_core/renderer_base.h"
#include "video_core/renderer_vulkan/renderer_vulkan.h"
+#include "video_core/capture.h"
+#include "video_core/textures/decoders.h"
#include "video_core/vulkan_common/vulkan_instance.h"
#include "video_core/vulkan_common/vulkan_surface.h"
#include "video_core/shader_notify.h"
@@ -215,107 +217,8 @@ void EmulationSession::ConfigureFilesystemProvider(const std::string& filepath)
return;
}
- const auto extension = Common::ToLower(filepath.substr(filepath.find_last_of('.') + 1));
-
- if (extension == "nsp") {
- auto nsp = std::make_shared(file);
- if (nsp->GetStatus() == Loader::ResultStatus::Success) {
- std::map nsp_versions;
- std::map nsp_version_strings;
-
- for (const auto& [title_id, nca_map] : nsp->GetNCAs()) {
- for (const auto& [type_pair, nca] : nca_map) {
- const auto& [title_type, content_type] = type_pair;
-
- if (content_type == FileSys::ContentRecordType::Meta) {
- const auto meta_nca = std::make_shared(nca->GetBaseFile());
- if (meta_nca->GetStatus() == Loader::ResultStatus::Success) {
- const auto section0 = meta_nca->GetSubdirectories();
- if (!section0.empty()) {
- for (const auto& meta_file : section0[0]->GetFiles()) {
- if (meta_file->GetExtension() == "cnmt") {
- FileSys::CNMT cnmt(meta_file);
- nsp_versions[cnmt.GetTitleID()] = cnmt.GetTitleVersion();
- }
- }
- }
- }
- }
-
- if (content_type == FileSys::ContentRecordType::Control &&
- title_type == FileSys::TitleType::Update) {
- auto romfs = nca->GetRomFS();
- if (romfs) {
- auto extracted = FileSys::ExtractRomFS(romfs);
- if (extracted) {
- auto nacp_file = extracted->GetFile("control.nacp");
- if (!nacp_file) {
- nacp_file = extracted->GetFile("Control.nacp");
- }
- if (nacp_file) {
- FileSys::NACP nacp(nacp_file);
- auto ver_str = nacp.GetVersionString();
- if (!ver_str.empty()) {
- nsp_version_strings[title_id] = ver_str;
- }
- }
- }
- }
- }
- }
- }
-
- for (const auto& [title_id, nca_map] : nsp->GetNCAs()) {
- for (const auto& [type_pair, nca] : nca_map) {
- const auto& [title_type, content_type] = type_pair;
-
- if (title_type == FileSys::TitleType::Update) {
- u32 version = 0;
- auto ver_it = nsp_versions.find(title_id);
- if (ver_it != nsp_versions.end()) {
- version = ver_it->second;
- }
-
- std::string version_string;
- auto str_it = nsp_version_strings.find(title_id);
- if (str_it != nsp_version_strings.end()) {
- version_string = str_it->second;
- }
-
- m_manual_provider->AddEntryWithVersion(
- title_type, content_type, title_id, version, version_string,
- nca->GetBaseFile());
-
- LOG_DEBUG(Frontend, "Added NSP update entry - TitleID: {:016X}, Version: {}, VersionStr: {}",
- title_id, version, version_string);
- } else {
- // Use regular AddEntry for non-updates
- m_manual_provider->AddEntry(title_type, content_type, title_id,
- nca->GetBaseFile());
- LOG_DEBUG(Frontend, "Added NSP entry - TitleID: {:016X}, TitleType: {}, ContentType: {}",
- title_id, static_cast(title_type), static_cast(content_type));
- }
- }
- }
- return;
- }
- }
-
- // Handle XCI files
- if (extension == "xci") {
- FileSys::XCI xci{file};
- if (xci.GetStatus() == Loader::ResultStatus::Success) {
- const auto nsp = xci.GetSecurePartitionNSP();
- if (nsp) {
- for (const auto& title : nsp->GetNCAs()) {
- for (const auto& entry : title.second) {
- m_manual_provider->AddEntry(entry.first.first, entry.first.second, title.first,
- entry.second->GetBaseFile());
- }
- }
- }
- return;
- }
+ if (m_manual_provider->AddEntriesFromContainer(file)) {
+ return;
}
auto loader = Loader::GetLoader(m_system, file);
@@ -337,6 +240,13 @@ void EmulationSession::ConfigureFilesystemProvider(const std::string& filepath)
}
}
+void EmulationSession::ConfigureFilesystemProviderFromGameFolder(const std::string& filepath) {
+ if (!Settings::values.ext_content_from_game_dirs.GetValue()) {
+ return;
+ }
+ ConfigureFilesystemProvider(filepath);
+}
+
void EmulationSession::InitializeSystem(bool reload) {
if (!reload) {
// Initialize logging system
@@ -780,9 +690,10 @@ void Java_org_yuzu_yuzu_1emu_NativeLibrary_surfaceChanged(JNIEnv* env, jobject i
}
void Java_org_yuzu_yuzu_1emu_NativeLibrary_surfaceDestroyed(JNIEnv* env, jobject instance) {
- ANativeWindow_release(EmulationSession::GetInstance().NativeWindow());
+ if (auto* native_window = EmulationSession::GetInstance().NativeWindow(); native_window) {
+ ANativeWindow_release(native_window);
+ }
EmulationSession::GetInstance().SetNativeWindow(nullptr);
- EmulationSession::GetInstance().SurfaceChanged();
}
void Java_org_yuzu_yuzu_1emu_NativeLibrary_setAppDirectory(JNIEnv* env, jobject instance,
@@ -969,6 +880,40 @@ jboolean Java_org_yuzu_yuzu_1emu_NativeLibrary_isPaused(JNIEnv* env, jclass claz
return static_cast(EmulationSession::GetInstance().IsPaused());
}
+jbyteArray Java_org_yuzu_yuzu_1emu_NativeLibrary_getAppletCaptureBuffer(JNIEnv* env, jclass clazz) {
+ using namespace VideoCore::Capture;
+
+ if (!EmulationSession::GetInstance().IsRunning()) {
+ return env->NewByteArray(0);
+ }
+
+ const auto tiled = EmulationSession::GetInstance().System().GPU().GetAppletCaptureBuffer();
+ if (tiled.size() < TiledSize) {
+ return env->NewByteArray(0);
+ }
+
+ std::vector linear(LinearWidth * LinearHeight * BytesPerPixel);
+ Tegra::Texture::UnswizzleTexture(linear, tiled, BytesPerPixel, LinearWidth, LinearHeight,
+ LinearDepth, BlockHeight, BlockDepth);
+
+ auto buffer = env->NewByteArray(static_cast(linear.size()));
+ if (!buffer) {
+ return env->NewByteArray(0);
+ }
+
+ env->SetByteArrayRegion(buffer, 0, static_cast(linear.size()),
+ reinterpret_cast(linear.data()));
+ return buffer;
+}
+
+jint Java_org_yuzu_yuzu_1emu_NativeLibrary_getAppletCaptureWidth(JNIEnv* env, jclass clazz) {
+ return static_cast(VideoCore::Capture::LinearWidth);
+}
+
+jint Java_org_yuzu_yuzu_1emu_NativeLibrary_getAppletCaptureHeight(JNIEnv* env, jclass clazz) {
+ return static_cast(VideoCore::Capture::LinearHeight);
+}
+
void Java_org_yuzu_yuzu_1emu_NativeLibrary_initializeSystem(JNIEnv* env, jclass clazz,
jboolean reload) {
// Initialize the emulated system.
@@ -1572,6 +1517,12 @@ void Java_org_yuzu_yuzu_1emu_NativeLibrary_addFileToFilesystemProvider(JNIEnv* e
Common::Android::GetJString(env, jpath));
}
+void Java_org_yuzu_yuzu_1emu_NativeLibrary_addGameFolderFileToFilesystemProvider(
+ JNIEnv* env, jobject jobj, jstring jpath) {
+ EmulationSession::GetInstance().ConfigureFilesystemProviderFromGameFolder(
+ Common::Android::GetJString(env, jpath));
+}
+
void Java_org_yuzu_yuzu_1emu_NativeLibrary_clearFilesystemProvider(JNIEnv* env, jobject jobj) {
EmulationSession::GetInstance().GetContentProvider()->ClearAllEntries();
}
diff --git a/src/android/app/src/main/jni/native.h b/src/android/app/src/main/jni/native.h
index dfbc8b2943..f2e5c2cfd6 100644
--- a/src/android/app/src/main/jni/native.h
+++ b/src/android/app/src/main/jni/native.h
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project
// SPDX-License-Identifier: GPL-2.0-or-later
@@ -46,6 +49,7 @@ public:
const Core::PerfStatsResults& PerfStats();
int ShadersBuilding();
void ConfigureFilesystemProvider(const std::string& filepath);
+ void ConfigureFilesystemProviderFromGameFolder(const std::string& filepath);
void InitializeSystem(bool reload);
void SetAppletId(int applet_id);
Core::SystemResultStatus InitializeEmulation(const std::string& filepath,
diff --git a/src/android/app/src/main/res/drawable/circle_white.xml b/src/android/app/src/main/res/drawable/circle_white.xml
new file mode 100644
index 0000000000..c94e68679a
--- /dev/null
+++ b/src/android/app/src/main/res/drawable/circle_white.xml
@@ -0,0 +1,4 @@
+
+
+
+
diff --git a/src/android/app/src/main/res/layout/fragment_emulation.xml b/src/android/app/src/main/res/layout/fragment_emulation.xml
index 7f5f039d5e..db363bc723 100644
--- a/src/android/app/src/main/res/layout/fragment_emulation.xml
+++ b/src/android/app/src/main/res/layout/fragment_emulation.xml
@@ -108,6 +108,22 @@
+
+
+
+
+
+
+
+
Theme Color
- Eden (Default)
+ Eden
Violet
Blue
Cyan
Red
- Green
+ Green (Default)
Yellow
Orange
Pink
diff --git a/src/common/settings.h b/src/common/settings.h
index 7ea4136576..7c6c0d062f 100644
--- a/src/common/settings.h
+++ b/src/common/settings.h
@@ -756,6 +756,8 @@ struct Values {
Category::DataStorage};
Setting gamecard_path{linkage, std::string(), "gamecard_path",
Category::DataStorage};
+ Setting ext_content_from_game_dirs{linkage, true, "ext_content_from_game_dirs",
+ Category::DataStorage};
std::vector external_content_dirs;
// Debugging
diff --git a/src/core/crypto/aes_util.cpp b/src/core/crypto/aes_util.cpp
index 1189e45bd8..55f436f532 100644
--- a/src/core/crypto/aes_util.cpp
+++ b/src/core/crypto/aes_util.cpp
@@ -38,7 +38,6 @@ struct CipherContext {
static inline const std::string GetCipherName(Mode mode, u32 key_size) {
std::string cipher;
std::size_t effective_bits = key_size * 8;
-
switch (mode) {
case Mode::CTR:
cipher = "CTR";
@@ -53,7 +52,6 @@ static inline const std::string GetCipherName(Mode mode, u32 key_size) {
default:
UNREACHABLE();
}
-
return fmt::format("AES-{}-{}", effective_bits, cipher);
};
@@ -87,8 +85,7 @@ static EVP_CIPHER *GetCipher(Mode mode, u32 key_size) {
// TODO: WHY TEMPLATE???????
template
-Crypto::AESCipher::AESCipher(Key key, Mode mode)
- : ctx(std::make_unique()) {
+Crypto::AESCipher::AESCipher(Key key, Mode mode) : ctx(std::make_unique()) {
ctx->encryption_context = EVP_CIPHER_CTX_new();
ctx->decryption_context = EVP_CIPHER_CTX_new();
@@ -99,9 +96,7 @@ Crypto::AESCipher::AESCipher(Key key, Mode mode)
UNIMPLEMENTED();
}
- ASSERT_MSG(ctx->encryption_context && ctx->decryption_context && ctx->cipher,
- "OpenSSL cipher context failed init!");
-
+ ASSERT(ctx->encryption_context && ctx->decryption_context && ctx->cipher && "OpenSSL cipher context failed init!");
// now init ciphers
ASSERT(EVP_CipherInit_ex2(ctx->encryption_context, ctx->cipher, key.data(), NULL, 1, NULL));
ASSERT(EVP_CipherInit_ex2(ctx->decryption_context, ctx->cipher, key.data(), NULL, 0, NULL));
@@ -165,8 +160,7 @@ void AESCipher::Transcode(const u8* src, std::size_t size, u8* des
template
void AESCipher::XTSTranscode(const u8* src, std::size_t size, u8* dest,
std::size_t sector_id, std::size_t sector_size, Op op) {
- ASSERT_MSG(size % sector_size == 0, "XTS decryption size must be a multiple of sector size.");
-
+ ASSERT(size % sector_size == 0 && "XTS decryption size must be a multiple of sector size.");
for (std::size_t i = 0; i < size; i += sector_size) {
SetIV(CalculateNintendoTweak(sector_id++));
Transcode(src + i, sector_size, dest + i, op);
@@ -177,8 +171,7 @@ template
void AESCipher::SetIV(std::span data) {
const int ret_enc = EVP_CipherInit_ex(ctx->encryption_context, nullptr, nullptr, nullptr, data.data(), -1);
const int ret_dec = EVP_CipherInit_ex(ctx->decryption_context, nullptr, nullptr, nullptr, data.data(), -1);
-
- ASSERT_MSG(ret_enc == 1 && ret_dec == 1, "Failed to set IV on OpenSSL contexts");
+ ASSERT(ret_enc == 1 && ret_dec == 1 && "Failed to set IV on OpenSSL contexts");
}
template class AESCipher;
diff --git a/src/core/crypto/sha_util.cpp b/src/core/crypto/sha_util.cpp
deleted file mode 100644
index 7a2c048389..0000000000
--- a/src/core/crypto/sha_util.cpp
+++ /dev/null
@@ -1,4 +0,0 @@
-// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project
-// SPDX-License-Identifier: GPL-2.0-or-later
-
-namespace Crypto {} // namespace Crypto
diff --git a/src/core/crypto/sha_util.h b/src/core/crypto/sha_util.h
deleted file mode 100644
index 5c2c43dbdb..0000000000
--- a/src/core/crypto/sha_util.h
+++ /dev/null
@@ -1,19 +0,0 @@
-// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project
-// SPDX-License-Identifier: GPL-2.0-or-later
-
-#pragma once
-
-#include "common/assert.h"
-#include "core/file_sys/vfs.h"
-#include "key_manager.h"
-#include "mbedtls/cipher.h"
-
-namespace Crypto {
-typedef std::array SHA256Hash;
-
-inline SHA256Hash operator"" _HASH(const char* data, size_t len) {
- if (len != 0x40)
- return {};
-}
-
-} // namespace Crypto
diff --git a/src/core/file_sys/patch_manager.cpp b/src/core/file_sys/patch_manager.cpp
index 82944ceceb..e9c3bb75c2 100644
--- a/src/core/file_sys/patch_manager.cpp
+++ b/src/core/file_sys/patch_manager.cpp
@@ -117,6 +117,12 @@ void AppendCommaIfNotEmpty(std::string& to, std::string_view with) {
bool IsDirValidAndNonEmpty(const VirtualDir& dir) {
return dir != nullptr && (!dir->GetFiles().empty() || !dir->GetSubdirectories().empty());
}
+
+bool IsVersionedExternalUpdateDisabled(const std::vector& disabled, u32 version) {
+ const std::string disabled_key = fmt::format("Update@{}", version);
+ return std::find(disabled.cbegin(), disabled.cend(), disabled_key) != disabled.cend() ||
+ std::find(disabled.cbegin(), disabled.cend(), "Update") != disabled.cend();
+}
} // Anonymous namespace
PatchManager::PatchManager(u64 title_id_,
@@ -155,8 +161,7 @@ VirtualDir PatchManager::PatchExeFS(VirtualDir exefs) const {
if (!update_versions.empty()) {
checked_external = true;
for (const auto& update_entry : update_versions) {
- std::string disabled_key = fmt::format("Update@{}", update_entry.version);
- if (std::find(disabled.cbegin(), disabled.cend(), disabled_key) == disabled.cend()) {
+ if (!IsVersionedExternalUpdateDisabled(disabled, update_entry.version)) {
update_disabled = false;
enabled_version = update_entry.version;
break;
@@ -175,8 +180,7 @@ VirtualDir PatchManager::PatchExeFS(VirtualDir exefs) const {
if (!manual_update_versions.empty()) {
checked_manual = true;
for (const auto& update_entry : manual_update_versions) {
- std::string disabled_key = fmt::format("Update@{}", update_entry.version);
- if (std::find(disabled.cbegin(), disabled.cend(), disabled_key) == disabled.cend()) {
+ if (!IsVersionedExternalUpdateDisabled(disabled, update_entry.version)) {
update_disabled = false;
enabled_version = update_entry.version;
break;
@@ -580,8 +584,7 @@ VirtualFile PatchManager::PatchRomFS(const NCA* base_nca, VirtualFile base_romfs
if (!update_versions.empty()) {
checked_external = true;
for (const auto& update_entry : update_versions) {
- std::string disabled_key = fmt::format("Update@{}", update_entry.version);
- if (std::find(disabled.cbegin(), disabled.cend(), disabled_key) == disabled.cend()) {
+ if (!IsVersionedExternalUpdateDisabled(disabled, update_entry.version)) {
update_disabled = false;
enabled_version = update_entry.version;
update_raw = external_provider->GetEntryForVersion(update_tid, type, update_entry.version);
@@ -600,8 +603,7 @@ VirtualFile PatchManager::PatchRomFS(const NCA* base_nca, VirtualFile base_romfs
if (!manual_update_versions.empty()) {
checked_manual = true;
for (const auto& update_entry : manual_update_versions) {
- std::string disabled_key = fmt::format("Update@{}", update_entry.version);
- if (std::find(disabled.cbegin(), disabled.cend(), disabled_key) == disabled.cend()) {
+ if (!IsVersionedExternalUpdateDisabled(disabled, update_entry.version)) {
update_disabled = false;
enabled_version = update_entry.version;
update_raw = manual_provider->GetEntryForVersion(update_tid, type, update_entry.version);
@@ -704,9 +706,8 @@ std::vector PatchManager::GetPatches(VirtualFile update_raw) const {
version_str = FormatTitleVersion(update_entry.version);
}
- std::string disabled_key = fmt::format("Update@{}", update_entry.version);
const auto update_disabled =
- std::find(disabled.cbegin(), disabled.cend(), disabled_key) != disabled.cend();
+ IsVersionedExternalUpdateDisabled(disabled, update_entry.version);
Patch update_patch = {.enabled = !update_disabled,
.name = "Update",
@@ -732,9 +733,8 @@ std::vector PatchManager::GetPatches(VirtualFile update_raw) const {
version_str = FormatTitleVersion(update_entry.version);
}
- std::string disabled_key = fmt::format("Update@{}", update_entry.version);
const auto update_disabled =
- std::find(disabled.cbegin(), disabled.cend(), disabled_key) != disabled.cend();
+ IsVersionedExternalUpdateDisabled(disabled, update_entry.version);
Patch update_patch = {.enabled = !update_disabled,
@@ -771,7 +771,8 @@ std::vector PatchManager::GetPatches(VirtualFile update_raw) const {
std::nullopt, std::nullopt, ContentRecordType::Program, update_tid);
for (const auto& [slot, entry] : all_updates) {
- if (slot == ContentProviderUnionSlot::External) {
+ if (slot == ContentProviderUnionSlot::External ||
+ slot == ContentProviderUnionSlot::FrontendManual) {
continue;
}
diff --git a/src/core/file_sys/registered_cache.cpp b/src/core/file_sys/registered_cache.cpp
index 7bf2ad8fcd..020d403c95 100644
--- a/src/core/file_sys/registered_cache.cpp
+++ b/src/core/file_sys/registered_cache.cpp
@@ -104,6 +104,206 @@ static std::string GetCNMTName(TitleType type, u64 title_id) {
return fmt::format("{}_{:016x}.cnmt", TITLE_TYPE_NAMES[index], title_id);
}
+static std::shared_ptr OpenContainerAsNsp(const VirtualFile& file, Loader::FileType type) {
+ if (!file) {
+ return nullptr;
+ }
+
+ if (type == Loader::FileType::Unknown || type == Loader::FileType::Error) {
+ type = Loader::IdentifyFile(file);
+ if (type == Loader::FileType::Unknown) {
+ type = Loader::GuessFromFilename(file->GetName());
+ }
+ }
+
+ if (type == Loader::FileType::NSP) {
+ auto nsp = std::make_shared(file);
+ return nsp->GetStatus() == Loader::ResultStatus::Success ? nsp : nullptr;
+ }
+
+ if (type == Loader::FileType::XCI) {
+ XCI xci(file);
+ if (xci.GetStatus() != Loader::ResultStatus::Success) {
+ return nullptr;
+ }
+
+ auto secure_partition = xci.GetSecurePartitionNSP();
+ if (secure_partition == nullptr) {
+ return nullptr;
+ }
+
+ return secure_partition;
+ }
+
+ // SAF-backed files can occasionally fail type-guessing despite being valid NSP/XCI.
+ // As a last resort, probe both container parsers directly.
+ {
+ auto nsp = std::make_shared(file);
+ if (nsp->GetStatus() == Loader::ResultStatus::Success) {
+ return nsp;
+ }
+ }
+ {
+ XCI xci(file);
+ if (xci.GetStatus() == Loader::ResultStatus::Success) {
+ auto secure_partition = xci.GetSecurePartitionNSP();
+ if (secure_partition != nullptr) {
+ return secure_partition;
+ }
+ }
+ }
+
+ return nullptr;
+}
+
+template
+bool ForEachContainerEntry(const std::shared_ptr& nsp, bool only_content,
+ std::optional base_program_id, Callback&& on_entry) {
+ if (!nsp) {
+ return false;
+ }
+
+ const auto& ncas = nsp->GetNCAs();
+ if (ncas.empty()) {
+ return false;
+ }
+
+ std::map versions;
+ std::map version_strings;
+
+ for (const auto& [title_id, nca_map] : ncas) {
+ for (const auto& [type_pair, nca] : nca_map) {
+ if (!nca) {
+ continue;
+ }
+
+ const auto& [title_type, content_type] = type_pair;
+
+ if (content_type == ContentRecordType::Meta) {
+ const auto subdirs = nca->GetSubdirectories();
+ if (!subdirs.empty()) {
+ for (const auto& inner_file : subdirs[0]->GetFiles()) {
+ if (inner_file->GetExtension() == "cnmt") {
+ const CNMT cnmt(inner_file);
+ versions[cnmt.GetTitleID()] = cnmt.GetTitleVersion();
+ break;
+ }
+ }
+ }
+ }
+
+ if (title_type == TitleType::Update && content_type == ContentRecordType::Control) {
+ const auto romfs = nca->GetRomFS();
+ if (!romfs) {
+ continue;
+ }
+
+ const auto extracted = ExtractRomFS(romfs);
+ if (!extracted) {
+ continue;
+ }
+
+ auto nacp_file = extracted->GetFile("control.nacp");
+ if (!nacp_file) {
+ nacp_file = extracted->GetFile("Control.nacp");
+ }
+ if (!nacp_file) {
+ continue;
+ }
+
+ const NACP nacp(nacp_file);
+ auto version_string = nacp.GetVersionString();
+ if (!version_string.empty()) {
+ version_strings[title_id] = std::move(version_string);
+ }
+ }
+ }
+ }
+
+ bool added_entries = false;
+ for (const auto& [title_id, nca_map] : ncas) {
+ if (base_program_id.has_value() && GetBaseTitleID(title_id) != *base_program_id) {
+ continue;
+ }
+
+ for (const auto& [type_pair, nca] : nca_map) {
+ const auto& [title_type, content_type] = type_pair;
+ if (only_content && title_type != TitleType::Update && title_type != TitleType::AOC) {
+ continue;
+ }
+
+ auto entry_file = nca ? nca->GetBaseFile() : nullptr;
+ if (!entry_file) {
+ continue;
+ }
+
+ u32 version = 0;
+ std::string version_string;
+
+ if (title_type == TitleType::Update) {
+ if (const auto version_it = versions.find(title_id); version_it != versions.end()) {
+ version = version_it->second;
+ }
+
+ if (const auto version_str_it = version_strings.find(title_id);
+ version_str_it != version_strings.end()) {
+ version_string = version_str_it->second;
+ }
+ }
+
+ on_entry(title_type, content_type, title_id, entry_file, version, version_string);
+ added_entries = true;
+ }
+ }
+
+ return added_entries;
+}
+
+static void UpsertExternalVersionEntry(std::vector& multi_version_entries,
+ u64 title_id, u32 version,
+ const std::string& version_string,
+ ContentRecordType content_type, const VirtualFile& file) {
+ auto it = std::find_if(multi_version_entries.begin(), multi_version_entries.end(),
+ [title_id, version](const ExternalUpdateEntry& entry) {
+ return entry.title_id == title_id && entry.version == version;
+ });
+
+ if (it == multi_version_entries.end()) {
+ ExternalUpdateEntry update_entry;
+ update_entry.title_id = title_id;
+ update_entry.version = version;
+ update_entry.version_string = version_string;
+ update_entry.files[static_cast(content_type)] = file;
+ multi_version_entries.push_back(std::move(update_entry));
+ return;
+ }
+
+ it->files[static_cast(content_type)] = file;
+ if (it->version_string.empty() && !version_string.empty()) {
+ it->version_string = version_string;
+ }
+}
+
+template
+static bool AddExternalEntriesFromContainer(const std::shared_ptr& nsp, EntryMap& entries,
+ VersionMap& versions,
+ std::vector& multi_version_entries) {
+ return ForEachContainerEntry(
+ nsp, true, std::nullopt,
+ [&entries, &versions,
+ &multi_version_entries](TitleType title_type, ContentRecordType content_type, u64 title_id,
+ const VirtualFile& file, u32 version,
+ const std::string& version_string) {
+ entries[{title_id, content_type, title_type}] = file;
+
+ if (title_type == TitleType::Update) {
+ versions[title_id] = version;
+ UpsertExternalVersionEntry(multi_version_entries, title_id, version, version_string,
+ content_type, file);
+ }
+ });
+}
+
ContentRecordType GetCRTypeFromNCAType(NCAContentType type) {
switch (type) {
case NCAContentType::Program:
@@ -1008,6 +1208,26 @@ void ManualContentProvider::AddEntryWithVersion(TitleType title_type, ContentRec
}
}
+bool ManualContentProvider::AddEntriesFromContainer(VirtualFile file, bool only_content,
+ std::optional base_program_id) {
+ const auto nsp = OpenContainerAsNsp(file, Loader::FileType::Unknown);
+ if (!nsp) {
+ return false;
+ }
+
+ return ForEachContainerEntry(
+ nsp, only_content, base_program_id,
+ [this](TitleType title_type, ContentRecordType content_type, u64 title_id,
+ const VirtualFile& entry_file, u32 version, const std::string& version_string) {
+ if (title_type == TitleType::Update) {
+ AddEntryWithVersion(title_type, content_type, title_id, version, version_string,
+ entry_file);
+ } else {
+ AddEntry(title_type, content_type, title_id, entry_file);
+ }
+ });
+}
+
void ManualContentProvider::ClearAllEntries() {
entries.clear();
multi_version_entries.clear();
@@ -1091,14 +1311,6 @@ VirtualFile ManualContentProvider::GetEntryForVersion(u64 title_id, ContentRecor
return nullptr;
}
-bool ManualContentProvider::HasMultipleVersions(u64 title_id, ContentRecordType type) const {
- size_t count = 0;
- for (const auto& entry : multi_version_entries)
- if (entry.title_id == title_id && entry.files[size_t(type)])
- ++count;
- return count > 0;
-}
-
ExternalContentProvider::ExternalContentProvider(std::vector load_directories)
: load_dirs(std::move(load_directories)) {
ExternalContentProvider::Refresh();
@@ -1159,247 +1371,22 @@ void ExternalContentProvider::ScanDirectory(const VirtualDir& dir) {
}
void ExternalContentProvider::ProcessNSP(const VirtualFile& file) {
- auto nsp = NSP(file);
- if (nsp.GetStatus() != Loader::ResultStatus::Success) {
+ const auto nsp = OpenContainerAsNsp(file, Loader::FileType::NSP);
+ if (!nsp) {
return;
}
LOG_DEBUG(Service_FS, "Processing NSP file: {}", file->GetName());
-
- const auto ncas = nsp.GetNCAs();
-
- std::map nsp_versions;
- std::map nsp_version_strings; // title_id -> NACP version string
-
- for (const auto& [title_id, nca_map] : ncas) {
- for (const auto& [type_pair, nca] : nca_map) {
- const auto& [title_type, content_type] = type_pair;
-
- if (content_type == ContentRecordType::Meta) {
- const auto subdirs = nca->GetSubdirectories();
- if (!subdirs.empty()) {
- const auto section0 = subdirs[0];
- const auto files = section0->GetFiles();
- for (const auto& inner_file : files) {
- if (inner_file->GetExtension() == "cnmt") {
- const CNMT cnmt(inner_file);
- const auto cnmt_title_id = cnmt.GetTitleID();
- const auto version = cnmt.GetTitleVersion();
- nsp_versions[cnmt_title_id] = version;
- versions[cnmt_title_id] = version;
- break;
- }
- }
- }
- }
-
- if (content_type == ContentRecordType::Control && title_type == TitleType::Update) {
- auto romfs = nca->GetRomFS();
- if (romfs) {
- auto extracted = ExtractRomFS(romfs);
- if (extracted) {
- auto nacp_file = extracted->GetFile("control.nacp");
- if (!nacp_file) {
- nacp_file = extracted->GetFile("Control.nacp");
- }
- if (nacp_file) {
- NACP nacp(nacp_file);
- auto ver_str = nacp.GetVersionString();
- if (!ver_str.empty()) {
- nsp_version_strings[title_id] = ver_str;
- }
- }
- }
- }
- }
- }
- }
-
- std::map, std::array> version_files;
-
- for (const auto& [title_id, nca_map] : ncas) {
- for (const auto& [type_pair, nca] : nca_map) {
- const auto& [title_type, content_type] = type_pair;
-
- if (title_type != TitleType::AOC && title_type != TitleType::Update) {
- continue;
- }
-
- auto nca_file = nsp.GetNCAFile(title_id, content_type, title_type);
- if (nca_file != nullptr) {
- entries[{title_id, content_type, title_type}] = nca_file;
-
- if (title_type == TitleType::Update) {
- u32 version = 0;
- auto ver_it = nsp_versions.find(title_id);
- if (ver_it != nsp_versions.end()) {
- version = ver_it->second;
- }
-
- version_files[{title_id, version}][size_t(content_type)] = nca_file;
- }
-
- LOG_DEBUG(Service_FS, "Added entry - Title ID: {:016X}, Type: {}, Content: {}",
- title_id, static_cast(title_type), static_cast(content_type));
- }
- }
- }
-
- for (const auto& [key, files_map] : version_files) {
- const auto& [title_id, version] = key;
-
- std::string ver_str;
- auto str_it = nsp_version_strings.find(title_id);
- if (str_it != nsp_version_strings.end()) {
- ver_str = str_it->second;
- }
-
- bool version_exists = false;
- for (auto& existing : multi_version_entries) {
- if (existing.title_id == title_id && existing.version == version) {
- existing.files = files_map;
- if (existing.version_string.empty() && !ver_str.empty()) {
- existing.version_string = ver_str;
- }
- version_exists = true;
- break;
- }
- }
-
- if (!version_exists && !files_map.empty()) {
- ExternalUpdateEntry update_entry{
- .title_id = title_id,
- .version = version,
- .version_string = ver_str,
- .files = files_map
- };
- multi_version_entries.push_back(update_entry);
- LOG_DEBUG(Service_FS, "Added multi-version update - Title ID: {:016X}, Version: {}, VersionStr: {}, Content types: {}",
- title_id, version, ver_str, files_map.size());
- }
- }
+ AddExternalEntriesFromContainer(nsp, entries, versions, multi_version_entries);
}
void ExternalContentProvider::ProcessXCI(const VirtualFile& file) {
- auto xci = XCI(file);
- if (xci.GetStatus() != Loader::ResultStatus::Success) {
+ const auto nsp = OpenContainerAsNsp(file, Loader::FileType::XCI);
+ if (!nsp) {
return;
}
- auto nsp = xci.GetSecurePartitionNSP();
- if (nsp == nullptr) {
- return;
- }
-
- const auto ncas = nsp->GetNCAs();
-
- std::map xci_versions;
- std::map xci_version_strings;
-
- for (const auto& [title_id, nca_map] : ncas) {
- for (const auto& [type_pair, nca] : nca_map) {
- const auto& [title_type, content_type] = type_pair;
-
- if (content_type == ContentRecordType::Meta) {
- const auto subdirs = nca->GetSubdirectories();
- if (!subdirs.empty()) {
- const auto section0 = subdirs[0];
- const auto files = section0->GetFiles();
- for (const auto& inner_file : files) {
- if (inner_file->GetExtension() == "cnmt") {
- const CNMT cnmt(inner_file);
- const auto cnmt_title_id = cnmt.GetTitleID();
- const auto version = cnmt.GetTitleVersion();
- xci_versions[cnmt_title_id] = version;
- versions[cnmt_title_id] = version;
- break;
- }
- }
- }
- }
-
- if (content_type == ContentRecordType::Control && title_type == TitleType::Update) {
- auto romfs = nca->GetRomFS();
- if (romfs) {
- auto extracted = ExtractRomFS(romfs);
- if (extracted) {
- auto nacp_file = extracted->GetFile("control.nacp");
- if (!nacp_file) {
- nacp_file = extracted->GetFile("Control.nacp");
- }
- if (nacp_file) {
- NACP nacp(nacp_file);
- auto ver_str = nacp.GetVersionString();
- if (!ver_str.empty()) {
- xci_version_strings[title_id] = ver_str;
- }
- }
- }
- }
- }
- }
- }
-
- std::map, std::array> version_files;
-
- for (const auto& [title_id, nca_map] : ncas) {
- for (const auto& [type_pair, nca] : nca_map) {
- const auto& [title_type, content_type] = type_pair;
-
- if (title_type != TitleType::AOC && title_type != TitleType::Update) {
- continue;
- }
-
- auto nca_file = nsp->GetNCAFile(title_id, content_type, title_type);
- if (nca_file != nullptr) {
- entries[{title_id, content_type, title_type}] = nca_file;
-
- if (title_type == TitleType::Update) {
- u32 version = 0;
- auto ver_it = xci_versions.find(title_id);
- if (ver_it != xci_versions.end()) {
- version = ver_it->second;
- }
-
- version_files[{title_id, version}][size_t(content_type)] = nca_file;
- }
- }
- }
- }
-
- for (const auto& [key, files_map] : version_files) {
- const auto& [title_id, version] = key;
-
- std::string ver_str;
- auto str_it = xci_version_strings.find(title_id);
- if (str_it != xci_version_strings.end()) {
- ver_str = str_it->second;
- }
-
- bool version_exists = false;
- for (auto& existing : multi_version_entries) {
- if (existing.title_id == title_id && existing.version == version) {
- existing.files = files_map;
- if (existing.version_string.empty() && !ver_str.empty()) {
- existing.version_string = ver_str;
- }
- version_exists = true;
- break;
- }
- }
-
- if (!version_exists && !files_map.empty()) {
- ExternalUpdateEntry update_entry{
- .title_id = title_id,
- .version = version,
- .version_string = ver_str,
- .files = files_map
- };
- multi_version_entries.push_back(update_entry);
- LOG_DEBUG(Service_FS, "Added multi-version update from XCI - Title ID: {:016X}, Version: {}, VersionStr: {}, Content types: {}",
- title_id, version, ver_str, files_map.size());
- }
- }
+ AddExternalEntriesFromContainer(nsp, entries, versions, multi_version_entries);
}
bool ExternalContentProvider::HasEntry(u64 title_id, ContentRecordType type) const {
@@ -1491,12 +1478,4 @@ VirtualFile ExternalContentProvider::GetEntryForVersion(u64 title_id, ContentRec
return nullptr;
}
-bool ExternalContentProvider::HasMultipleVersions(u64 title_id, ContentRecordType type) const {
- size_t count = 0;
- for (const auto& entry : multi_version_entries)
- if (entry.title_id == title_id && entry.files[size_t(type)])
- ++count;
- return count > 1;
-}
-
} // namespace FileSys
diff --git a/src/core/file_sys/registered_cache.h b/src/core/file_sys/registered_cache.h
index 2e39f74db8..32134d1c48 100644
--- a/src/core/file_sys/registered_cache.h
+++ b/src/core/file_sys/registered_cache.h
@@ -9,6 +9,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -262,6 +263,8 @@ public:
VirtualFile file);
void AddEntryWithVersion(TitleType title_type, ContentRecordType content_type, u64 title_id,
u32 version, const std::string& version_string, VirtualFile file);
+ bool AddEntriesFromContainer(VirtualFile file, bool only_content = false,
+ std::optional base_program_id = std::nullopt);
void ClearAllEntries();
void Refresh() override;
@@ -276,7 +279,6 @@ public:
std::vector ListUpdateVersions(u64 title_id) const;
VirtualFile GetEntryForVersion(u64 title_id, ContentRecordType type, u32 version) const;
- bool HasMultipleVersions(u64 title_id, ContentRecordType type) const;
private:
std::map, VirtualFile> entries;
@@ -303,7 +305,6 @@ public:
std::vector ListUpdateVersions(u64 title_id) const;
VirtualFile GetEntryForVersion(u64 title_id, ContentRecordType type, u32 version) const;
- bool HasMultipleVersions(u64 title_id, ContentRecordType type) const;
private:
void ScanDirectory(const VirtualDir& dir);
diff --git a/src/core/hle/service/prepo/prepo.cpp b/src/core/hle/service/prepo/prepo.cpp
index 4fc59d0e10..bfc5539903 100644
--- a/src/core/hle/service/prepo/prepo.cpp
+++ b/src/core/hle/service/prepo/prepo.cpp
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project
@@ -28,8 +28,10 @@ public:
{10101, &PlayReport::SaveReportWithUser, "SaveReportWithUserOld"},
{10102, &PlayReport::SaveReport, "SaveReportOld2"},
{10103, &PlayReport::SaveReportWithUser, "SaveReportWithUserOld2"},
- {10104, &PlayReport::SaveReport, "SaveReport"},
- {10105, &PlayReport::SaveReportWithUser, "SaveReportWithUser"},
+ {10104, &PlayReport::SaveReport, "SaveReportOld3"},
+ {10105, &PlayReport::SaveReportWithUser, "SaveReportWithUserOld3"},
+ {10106, &PlayReport::SaveReport, "SaveReport"},
+ {10107, &PlayReport::SaveReportWithUser, "SaveReportWithUser"},
{10200, &PlayReport::RequestImmediateTransmission, "RequestImmediateTransmission"},
{10300, &PlayReport::GetTransmissionStatus, "GetTransmissionStatus"},
{10400, &PlayReport::GetSystemSessionId, "GetSystemSessionId"},
diff --git a/src/core/loader/loader.cpp b/src/core/loader/loader.cpp
index 4379634d03..b4d50227d3 100644
--- a/src/core/loader/loader.cpp
+++ b/src/core/loader/loader.cpp
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project
@@ -9,11 +9,15 @@
#include
#include
#include
+#include
#include "common/concepts.h"
#include "common/fs/path_util.h"
#include "common/logging/log.h"
#include "common/string_util.h"
#include "core/core.h"
+#include "core/file_sys/card_image.h"
+#include "core/file_sys/common_funcs.h"
+#include "core/file_sys/submission_package.h"
#include "core/hle/kernel/k_process.h"
#include "core/loader/deconstructed_rom_directory.h"
#include "core/loader/kip.h"
@@ -37,6 +41,49 @@ std::optional IdentifyFileLoader(FileSys::VirtualFile file) {
return std::nullopt;
}
+std::shared_ptr OpenContainerAsNsp(FileSys::VirtualFile file, FileType type,
+ u64 program_id = 0,
+ std::size_t program_index = 0) {
+ if (!file) {
+ return nullptr;
+ }
+
+ if (type == FileType::NSP) {
+ auto nsp = std::make_shared(file, program_id, program_index);
+ return nsp->GetStatus() == ResultStatus::Success ? nsp : nullptr;
+ }
+
+ if (type == FileType::XCI) {
+ FileSys::XCI xci{file, program_id, program_index};
+ if (xci.GetStatus() != ResultStatus::Success) {
+ return nullptr;
+ }
+
+ auto secure_nsp = xci.GetSecurePartitionNSP();
+ if (secure_nsp == nullptr || secure_nsp->GetStatus() != ResultStatus::Success) {
+ return nullptr;
+ }
+
+ return secure_nsp;
+ }
+
+ return nullptr;
+}
+
+bool HasApplicationProgramContent(const std::shared_ptr& nsp) {
+ if (!nsp) {
+ return false;
+ }
+
+ const auto& ncas = nsp->GetNCAs();
+ return std::any_of(ncas.cbegin(), ncas.cend(), [](const auto& title_entry) {
+ const auto& nca_map = title_entry.second;
+ return nca_map.find(
+ {FileSys::TitleType::Application, FileSys::ContentRecordType::Program}) !=
+ nca_map.end();
+ });
+}
+
} // namespace
FileType IdentifyFile(FileSys::VirtualFile file) {
@@ -62,6 +109,27 @@ FileType IdentifyFile(FileSys::VirtualFile file) {
}
}
+bool IsContainerType(FileType type) {
+ return type == FileType::NSP || type == FileType::XCI;
+}
+
+bool IsBootableGameContainer(FileSys::VirtualFile file, FileType type, u64 program_id,
+ std::size_t program_index) {
+ if (!file) {
+ return false;
+ }
+
+ if (type == FileType::Unknown) {
+ type = IdentifyFile(file);
+ }
+
+ if (!IsContainerType(type)) {
+ return false;
+ }
+
+ return HasApplicationProgramContent(OpenContainerAsNsp(file, type, program_id, program_index));
+}
+
FileType GuessFromFilename(const std::string& name) {
if (name == "main")
return FileType::DeconstructedRomDirectory;
diff --git a/src/core/loader/loader.h b/src/core/loader/loader.h
index f4e932cec9..95ce638da0 100644
--- a/src/core/loader/loader.h
+++ b/src/core/loader/loader.h
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project
// SPDX-License-Identifier: GPL-2.0-or-later
@@ -46,12 +49,29 @@ enum class FileType {
};
/**
- * Identifies the type of a bootable file based on the magic value in its header.
+ * Identifies the type of a supported file/container based on its structure.
* @param file open file
* @return FileType of file
*/
FileType IdentifyFile(FileSys::VirtualFile file);
+/**
+ * Returns whether the file type represents a container format that can bundle multiple titles
+ * (currently NSP/XCI).
+ */
+bool IsContainerType(FileType type);
+
+/**
+ * Returns whether a container file is bootable as a game (has Application/Program content).
+ *
+ * @param file open file
+ * @param type optional file type; if Unknown it is auto-detected.
+ * @param program_id optional program id hint for multi-program containers.
+ * @param program_index optional program index hint for multi-program containers.
+ */
+bool IsBootableGameContainer(FileSys::VirtualFile file, FileType type = FileType::Unknown,
+ u64 program_id = 0, std::size_t program_index = 0);
+
/**
* Guess the type of a bootable file from its name
* @param name String name of bootable file
diff --git a/src/core/loader/nsp.cpp b/src/core/loader/nsp.cpp
index 3016d5f25f..4333acb70c 100644
--- a/src/core/loader/nsp.cpp
+++ b/src/core/loader/nsp.cpp
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project
// SPDX-License-Identifier: GPL-2.0-or-later
@@ -55,19 +58,30 @@ AppLoader_NSP::~AppLoader_NSP() = default;
FileType AppLoader_NSP::IdentifyType(const FileSys::VirtualFile& nsp_file) {
const FileSys::NSP nsp(nsp_file);
- if (nsp.GetStatus() == ResultStatus::Success) {
- // Extracted Type case
- if (nsp.IsExtractedType() && nsp.GetExeFS() != nullptr &&
- FileSys::IsDirectoryExeFS(nsp.GetExeFS())) {
- return FileType::NSP;
+ if (nsp.GetStatus() != ResultStatus::Success) {
+ return FileType::Error;
+ }
+
+ // Extracted Type case
+ if (nsp.IsExtractedType() && nsp.GetExeFS() != nullptr &&
+ FileSys::IsDirectoryExeFS(nsp.GetExeFS())) {
+ return FileType::NSP;
+ }
+
+ // Non-extracted NSPs can legitimately contain only update/DLC content.
+ // Identify the container format itself; bootability is validated by Load().
+ if (!nsp.GetNCAs().empty()) {
+ return FileType::NSP;
+ }
+
+ // Fallback when NCAs couldn't be parsed (e.g. missing keys) but the PFS still contains NCAs.
+ for (const auto& entry : nsp.GetFiles()) {
+ if (entry == nullptr) {
+ continue;
}
- // Non-Extracted Type case
- const auto program_id = nsp.GetProgramTitleID();
- if (!nsp.IsExtractedType() &&
- nsp.GetNCA(program_id, FileSys::ContentRecordType::Program) != nullptr &&
- AppLoader_NCA::IdentifyType(
- nsp.GetNCAFile(program_id, FileSys::ContentRecordType::Program)) == FileType::NCA) {
+ const auto& name = entry->GetName();
+ if (name.size() >= 4 && name.substr(name.size() - 4) == ".nca") {
return FileType::NSP;
}
}
diff --git a/src/core/loader/xci.cpp b/src/core/loader/xci.cpp
index e9abb199a1..983184a226 100644
--- a/src/core/loader/xci.cpp
+++ b/src/core/loader/xci.cpp
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project
// SPDX-License-Identifier: GPL-2.0-or-later
@@ -44,10 +47,13 @@ AppLoader_XCI::~AppLoader_XCI() = default;
FileType AppLoader_XCI::IdentifyType(const FileSys::VirtualFile& xci_file) {
const FileSys::XCI xci(xci_file);
- if (xci.GetStatus() == ResultStatus::Success &&
- xci.GetNCAByType(FileSys::NCAContentType::Program) != nullptr &&
- AppLoader_NCA::IdentifyType(xci.GetNCAFileByType(FileSys::NCAContentType::Program)) ==
- FileType::NCA) {
+ if (xci.GetStatus() != ResultStatus::Success) {
+ return FileType::Error;
+ }
+
+ // Identify XCI as a valid container even when it does not include a bootable Program NCA.
+ // Bootability is handled by AppLoader_XCI::Load().
+ if (xci.GetSecurePartitionNSP() != nullptr) {
return FileType::XCI;
}
diff --git a/src/core/reporter.h b/src/core/reporter.h
index db1ca3ba0c..1eee8da31f 100644
--- a/src/core/reporter.h
+++ b/src/core/reporter.h
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: Copyright 2019 yuzu Emulator Project
// SPDX-License-Identifier: GPL-2.0-or-later
@@ -53,6 +56,7 @@ public:
enum class PlayReportType {
Old,
Old2,
+ Old3,
New,
System,
};
diff --git a/src/qt_common/config/shared_translation.cpp b/src/qt_common/config/shared_translation.cpp
index f49c43ee2a..d1ed32134c 100644
--- a/src/qt_common/config/shared_translation.cpp
+++ b/src/qt_common/config/shared_translation.cpp
@@ -425,6 +425,9 @@ std::unique_ptr InitializeTranslations(QObject* parent)
"their resolution, details and supported controllers and depending on this setting.\n"
"Setting to Handheld can help improve performance for low end systems."));
INSERT(Settings, current_user, QString(), QString());
+ INSERT(Settings, serial_unit, tr("Unit Serial"), QString());
+ INSERT(Settings, serial_battery, tr("Battery Serial"), QString());
+ INSERT(Settings, debug_knobs, tr("Debug knobs"), QString());
// Controls
diff --git a/src/shader_recompiler/backend/spirv/emit_spirv_special.cpp b/src/shader_recompiler/backend/spirv/emit_spirv_special.cpp
index fe5e70a63b..8eca1fac29 100644
--- a/src/shader_recompiler/backend/spirv/emit_spirv_special.cpp
+++ b/src/shader_recompiler/backend/spirv/emit_spirv_special.cpp
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project
// SPDX-License-Identifier: GPL-2.0-or-later
@@ -91,6 +94,17 @@ void AlphaTest(EmitContext& ctx) {
} // Anonymous namespace
void EmitPrologue(EmitContext& ctx) {
+ if (ctx.stage == Stage::Fragment && ctx.runtime_info.dual_source_blend) {
+ // Initialize dual-source blending outputs - prevents MoltenVK crash.
+ const Id zero{ctx.Const(0.0f)};
+ const Id one{ctx.Const(1.0f)};
+ const Id default_color{ctx.ConstantComposite(ctx.F32[4], zero, zero, zero, one)};
+ for (u32 i = 0; i < 2; ++i) {
+ if (Sirit::ValidId(ctx.frag_color[i])) {
+ ctx.OpStore(ctx.frag_color[i], default_color);
+ }
+ }
+ }
if (ctx.stage == Stage::VertexB) {
const Id zero{ctx.Const(0.0f)};
const Id one{ctx.Const(1.0f)};
diff --git a/src/shader_recompiler/backend/spirv/spirv_emit_context.cpp b/src/shader_recompiler/backend/spirv/spirv_emit_context.cpp
index cd3394bdf0..b9a24496c9 100644
--- a/src/shader_recompiler/backend/spirv/spirv_emit_context.cpp
+++ b/src/shader_recompiler/backend/spirv/spirv_emit_context.cpp
@@ -1670,13 +1670,22 @@ void EmitContext::DefineOutputs(const IR::Program& program) {
break;
case Stage::Fragment:
for (u32 index = 0; index < 8; ++index) {
- if (!info.stores_frag_color[index] && !profile.need_declared_frag_colors) {
+ const bool need_dual_source = runtime_info.dual_source_blend && index <= 1;
+ if (!need_dual_source && !info.stores_frag_color[index] &&
+ !profile.need_declared_frag_colors) {
continue;
}
const Id type{GetAttributeType(*this, runtime_info.color_output_types[index])};
frag_color[index] = DefineOutput(*this, type, std::nullopt);
- Decorate(frag_color[index], spv::Decoration::Location, index);
- Name(frag_color[index], fmt::format("frag_color{}", index));
+ // Correct mapping for dual-source blending
+ if (runtime_info.dual_source_blend && index <= 1) {
+ Decorate(frag_color[index], spv::Decoration::Location, 0u);
+ Decorate(frag_color[index], spv::Decoration::Index, index);
+ Name(frag_color[index], index == 0 ? "frag_color0" : "frag_color0_secondary");
+ } else {
+ Decorate(frag_color[index], spv::Decoration::Location, index);
+ Name(frag_color[index], fmt::format("frag_color{}", index));
+ }
}
if (info.stores_frag_depth) {
frag_depth = DefineOutput(*this, F32[1], std::nullopt);
diff --git a/src/shader_recompiler/runtime_info.h b/src/shader_recompiler/runtime_info.h
index 613c598d0c..be10a9bb08 100644
--- a/src/shader_recompiler/runtime_info.h
+++ b/src/shader_recompiler/runtime_info.h
@@ -110,6 +110,9 @@ struct RuntimeInfo {
/// Output types for each color attachment
std::array color_output_types{};
+
+ /// Dual source blending
+ bool dual_source_blend{};
};
} // namespace Shader
diff --git a/src/video_core/buffer_cache/buffer_cache_base.h b/src/video_core/buffer_cache/buffer_cache_base.h
index 0596329392..08524bd854 100644
--- a/src/video_core/buffer_cache/buffer_cache_base.h
+++ b/src/video_core/buffer_cache/buffer_cache_base.h
@@ -14,9 +14,12 @@
#include
#include
#include
-#include
#include
+#include
+#include
+#include
+
#include "common/common_types.h"
#include "common/div_ceil.h"
#include "common/literals.h"
@@ -94,10 +97,10 @@ static constexpr Binding NULL_BINDING{
template
struct HostBindings {
- boost::container::small_vector buffers;
- boost::container::small_vector offsets;
- boost::container::small_vector sizes;
- boost::container::small_vector strides;
+ boost::container::static_vector buffers;
+ boost::container::static_vector offsets;
+ boost::container::static_vector sizes;
+ boost::container::static_vector strides;
u32 min_index{NUM_VERTEX_BUFFERS};
u32 max_index{0};
};
diff --git a/src/video_core/control/channel_state.cpp b/src/video_core/control/channel_state.cpp
index 2539997d53..d07c7e2a83 100644
--- a/src/video_core/control/channel_state.cpp
+++ b/src/video_core/control/channel_state.cpp
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: 2022 yuzu Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
@@ -19,12 +22,12 @@ ChannelState::ChannelState(s32 bind_id_) : bind_id{bind_id_}, initialized{} {}
void ChannelState::Init(Core::System& system, GPU& gpu, u64 program_id_) {
ASSERT(memory_manager);
program_id = program_id_;
- dma_pusher = std::make_unique(system, gpu, *memory_manager, *this);
- maxwell_3d = std::make_unique(system, *memory_manager);
- fermi_2d = std::make_unique(*memory_manager);
- kepler_compute = std::make_unique(system, *memory_manager);
- maxwell_dma = std::make_unique(system, *memory_manager);
- kepler_memory = std::make_unique(system, *memory_manager);
+ dma_pusher.emplace(system, gpu, *memory_manager, *this);
+ maxwell_3d.emplace(system, *memory_manager);
+ fermi_2d.emplace(*memory_manager);
+ kepler_compute.emplace(system, *memory_manager);
+ maxwell_dma.emplace(system, *memory_manager);
+ kepler_memory.emplace(system, *memory_manager);
initialized = true;
}
diff --git a/src/video_core/control/channel_state.h b/src/video_core/control/channel_state.h
index b385f4939f..2984d2e09e 100644
--- a/src/video_core/control/channel_state.h
+++ b/src/video_core/control/channel_state.h
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: 2022 yuzu Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
@@ -6,6 +9,12 @@
#include
#include "common/common_types.h"
+#include "video_core/engines/fermi_2d.h"
+#include "video_core/engines/kepler_memory.h"
+#include "video_core/engines/kepler_compute.h"
+#include "video_core/engines/maxwell_3d.h"
+#include "video_core/engines/maxwell_dma.h"
+#include "video_core/dma_pusher.h"
namespace Core {
class System;
@@ -18,49 +27,34 @@ class RasterizerInterface;
namespace Tegra {
class GPU;
-
-namespace Engines {
-class Puller;
-class Fermi2D;
-class Maxwell3D;
-class MaxwellDMA;
-class KeplerCompute;
-class KeplerMemory;
-} // namespace Engines
-
class MemoryManager;
-class DmaPusher;
namespace Control {
struct ChannelState {
explicit ChannelState(s32 bind_id);
- ChannelState(const ChannelState& state) = delete;
- ChannelState& operator=(const ChannelState&) = delete;
- ChannelState(ChannelState&& other) noexcept = default;
- ChannelState& operator=(ChannelState&& other) noexcept = default;
void Init(Core::System& system, GPU& gpu, u64 program_id);
void BindRasterizer(VideoCore::RasterizerInterface* rasterizer);
- s32 bind_id = -1;
- u64 program_id = 0;
/// 3D engine
- std::unique_ptr maxwell_3d;
+ std::optional maxwell_3d;
/// 2D engine
- std::unique_ptr fermi_2d;
+ std::optional fermi_2d;
/// Compute engine
- std::unique_ptr kepler_compute;
+ std::optional kepler_compute;
/// DMA engine
- std::unique_ptr maxwell_dma;
+ std::optional maxwell_dma;
/// Inline memory engine
- std::unique_ptr kepler_memory;
-
+ std::optional kepler_memory;
+ /// NV01 Timer
+ std::optional nv01_timer;
+ std::optional dma_pusher;
std::shared_ptr memory_manager;
- std::unique_ptr dma_pusher;
-
+ s32 bind_id = -1;
+ u64 program_id = 0;
bool initialized{};
};
diff --git a/src/video_core/engines/engine_interface.h b/src/video_core/engines/engine_interface.h
index e271ecab59..bf3bd66aca 100644
--- a/src/video_core/engines/engine_interface.h
+++ b/src/video_core/engines/engine_interface.h
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project
@@ -15,6 +15,7 @@
namespace Tegra::Engines {
enum class EngineTypes : u32 {
+ Nv01Timer,
KeplerCompute,
Maxwell3D,
Fermi2D,
diff --git a/src/video_core/engines/maxwell_3d.cpp b/src/video_core/engines/maxwell_3d.cpp
index 7dbb8f6617..e48f294a5a 100644
--- a/src/video_core/engines/maxwell_3d.cpp
+++ b/src/video_core/engines/maxwell_3d.cpp
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project
@@ -26,8 +26,15 @@ namespace Tegra::Engines {
constexpr u32 MacroRegistersStart = 0xE00;
Maxwell3D::Maxwell3D(Core::System& system_, MemoryManager& memory_manager_)
- : draw_manager{std::make_unique(this)}, system{system_},
- memory_manager{memory_manager_}, macro_engine{GetMacroEngine(*this)}, upload_state{memory_manager, regs.upload} {
+ : draw_manager{std::make_unique(this)}, system{system_}
+ , memory_manager{memory_manager_}
+#ifdef ARCHITECTURE_x86_64
+ , macro_engine(bool(Settings::values.disable_macro_jit))
+#else
+ , macro_engine(true)
+#endif
+ , upload_state{memory_manager, regs.upload}
+{
dirty.flags.flip();
InitializeRegisterDefaults();
execution_mask.reset();
@@ -328,9 +335,9 @@ void Maxwell3D::ProcessMethodCall(u32 method, u32 argument, u32 nonshadow_argume
shadow_state.shadow_ram_control = static_cast(nonshadow_argument);
return;
case MAXWELL3D_REG_INDEX(load_mme.instruction_ptr):
- return macro_engine->ClearCode(regs.load_mme.instruction_ptr);
+ return macro_engine.ClearCode(regs.load_mme.instruction_ptr);
case MAXWELL3D_REG_INDEX(load_mme.instruction):
- return macro_engine->AddCode(regs.load_mme.instruction_ptr, argument);
+ return macro_engine.AddCode(regs.load_mme.instruction_ptr, argument);
case MAXWELL3D_REG_INDEX(load_mme.start_address):
return ProcessMacroBind(argument);
case MAXWELL3D_REG_INDEX(falcon[4]):
@@ -398,7 +405,7 @@ void Maxwell3D::CallMacroMethod(u32 method, const std::vector& parameters)
((method - MacroRegistersStart) >> 1) % static_cast(macro_positions.size());
// Execute the current macro.
- macro_engine->Execute(macro_positions[entry], parameters);
+ macro_engine.Execute(*this, macro_positions[entry], parameters);
draw_manager->DrawDeferred();
}
@@ -464,7 +471,7 @@ void Maxwell3D::CallMultiMethod(u32 method, const u32* base_start, u32 amount,
}
void Maxwell3D::ProcessMacroUpload(u32 data) {
- macro_engine->AddCode(regs.load_mme.instruction_ptr++, data);
+ macro_engine.AddCode(regs.load_mme.instruction_ptr++, data);
}
void Maxwell3D::ProcessMacroBind(u32 data) {
diff --git a/src/video_core/engines/maxwell_3d.h b/src/video_core/engines/maxwell_3d.h
index 5312c04b6f..b73082b7ef 100644
--- a/src/video_core/engines/maxwell_3d.h
+++ b/src/video_core/engines/maxwell_3d.h
@@ -2258,7 +2258,7 @@ public:
/// Returns whether the vertex array specified by index is supposed to be
/// accessed per instance or not.
bool IsInstancingEnabled(std::size_t index) const {
- return is_instanced[index];
+ return bool(is_instanced[index]); //FUCK YOU MSVC
}
};
@@ -3203,7 +3203,7 @@ private:
std::vector macro_params;
/// Interpreter for the macro codes uploaded to the GPU.
- std::optional macro_engine;
+ MacroEngine macro_engine;
Upload::State upload_state;
diff --git a/src/video_core/engines/nv01_timer.h b/src/video_core/engines/nv01_timer.h
new file mode 100644
index 0000000000..a8e60f9f53
--- /dev/null
+++ b/src/video_core/engines/nv01_timer.h
@@ -0,0 +1,52 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+#pragma once
+
+#include
+#include
+#include "common/bit_field.h"
+#include "common/common_funcs.h"
+#include "common/common_types.h"
+#include "common/logging/log.h"
+#include "video_core/engines/engine_interface.h"
+#include "video_core/engines/engine_upload.h"
+
+namespace Core {
+class System;
+}
+
+namespace Tegra {
+class MemoryManager;
+}
+
+namespace Tegra::Engines {
+class Nv01Timer final : public EngineInterface {
+public:
+ explicit Nv01Timer(Core::System& system_, MemoryManager& memory_manager)
+ : system{system_}
+ {}
+ ~Nv01Timer() override;
+
+ /// Write the value to the register identified by method.
+ void CallMethod(u32 method, u32 method_argument, bool is_last_call) override {
+ LOG_DEBUG(HW_GPU, "method={}, argument={}, is_last_call={}", method, method_argument, is_last_call);
+ }
+
+ /// Write multiple values to the register identified by method.
+ void CallMultiMethod(u32 method, const u32* base_start, u32 amount, u32 methods_pending) override {
+ LOG_DEBUG(HW_GPU, "method={}, base_start={}, amount={}, pending={}", method, fmt::ptr(base_start), amount, methods_pending);
+ }
+
+ struct Regs {
+ // No fucking idea
+ INSERT_PADDING_BYTES_NOINIT(0x48);
+ } regs{};
+private:
+ void ConsumeSinkImpl() override {}
+ Core::System& system;
+};
+}
diff --git a/src/video_core/engines/puller.cpp b/src/video_core/engines/puller.cpp
index 8dd34c04ab..b5b4e5d7fa 100644
--- a/src/video_core/engines/puller.cpp
+++ b/src/video_core/engines/puller.cpp
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: 2022 yuzu Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
@@ -34,24 +37,22 @@ void Puller::ProcessBindMethod(const MethodCall& method_call) {
bound_engines[method_call.subchannel] = engine_id;
switch (engine_id) {
case EngineID::FERMI_TWOD_A:
- dma_pusher.BindSubchannel(channel_state.fermi_2d.get(), method_call.subchannel,
- EngineTypes::Fermi2D);
+ dma_pusher.BindSubchannel(&*channel_state.fermi_2d, method_call.subchannel, EngineTypes::Fermi2D);
break;
case EngineID::MAXWELL_B:
- dma_pusher.BindSubchannel(channel_state.maxwell_3d.get(), method_call.subchannel,
- EngineTypes::Maxwell3D);
+ dma_pusher.BindSubchannel(&*channel_state.maxwell_3d, method_call.subchannel, EngineTypes::Maxwell3D);
break;
case EngineID::KEPLER_COMPUTE_B:
- dma_pusher.BindSubchannel(channel_state.kepler_compute.get(), method_call.subchannel,
- EngineTypes::KeplerCompute);
+ dma_pusher.BindSubchannel(&*channel_state.kepler_compute, method_call.subchannel, EngineTypes::KeplerCompute);
break;
case EngineID::MAXWELL_DMA_COPY_A:
- dma_pusher.BindSubchannel(channel_state.maxwell_dma.get(), method_call.subchannel,
- EngineTypes::MaxwellDMA);
+ dma_pusher.BindSubchannel(&*channel_state.maxwell_dma, method_call.subchannel, EngineTypes::MaxwellDMA);
break;
case EngineID::KEPLER_INLINE_TO_MEMORY_B:
- dma_pusher.BindSubchannel(channel_state.kepler_memory.get(), method_call.subchannel,
- EngineTypes::KeplerMemory);
+ dma_pusher.BindSubchannel(&*channel_state.kepler_memory, method_call.subchannel, EngineTypes::KeplerMemory);
+ break;
+ case EngineID::NV01_TIMER:
+ dma_pusher.BindSubchannel(&*channel_state.nv01_timer, method_call.subchannel, EngineTypes::Nv01Timer);
break;
default:
UNIMPLEMENTED_MSG("Unimplemented engine {:04X}", engine_id);
@@ -209,24 +210,22 @@ void Puller::CallEngineMethod(const MethodCall& method_call) {
switch (engine) {
case EngineID::FERMI_TWOD_A:
- channel_state.fermi_2d->CallMethod(method_call.method, method_call.argument,
- method_call.IsLastCall());
+ channel_state.fermi_2d->CallMethod(method_call.method, method_call.argument, method_call.IsLastCall());
break;
case EngineID::MAXWELL_B:
- channel_state.maxwell_3d->CallMethod(method_call.method, method_call.argument,
- method_call.IsLastCall());
+ channel_state.maxwell_3d->CallMethod(method_call.method, method_call.argument, method_call.IsLastCall());
break;
case EngineID::KEPLER_COMPUTE_B:
- channel_state.kepler_compute->CallMethod(method_call.method, method_call.argument,
- method_call.IsLastCall());
+ channel_state.kepler_compute->CallMethod(method_call.method, method_call.argument, method_call.IsLastCall());
break;
case EngineID::MAXWELL_DMA_COPY_A:
- channel_state.maxwell_dma->CallMethod(method_call.method, method_call.argument,
- method_call.IsLastCall());
+ channel_state.maxwell_dma->CallMethod(method_call.method, method_call.argument, method_call.IsLastCall());
break;
case EngineID::KEPLER_INLINE_TO_MEMORY_B:
- channel_state.kepler_memory->CallMethod(method_call.method, method_call.argument,
- method_call.IsLastCall());
+ channel_state.kepler_memory->CallMethod(method_call.method, method_call.argument, method_call.IsLastCall());
+ break;
+ case EngineID::NV01_TIMER:
+ channel_state.nv01_timer->CallMethod(method_call.method, method_call.argument, method_call.IsLastCall());
break;
default:
UNIMPLEMENTED_MSG("Unimplemented engine");
@@ -255,6 +254,9 @@ void Puller::CallEngineMultiMethod(u32 method, u32 subchannel, const u32* base_s
case EngineID::KEPLER_INLINE_TO_MEMORY_B:
channel_state.kepler_memory->CallMultiMethod(method, base_start, amount, methods_pending);
break;
+ case EngineID::NV01_TIMER:
+ channel_state.nv01_timer->CallMultiMethod(method, base_start, amount, methods_pending);
+ break;
default:
UNIMPLEMENTED_MSG("Unimplemented engine");
break;
diff --git a/src/video_core/engines/puller.h b/src/video_core/engines/puller.h
index d4175ee945..fe5102e3ed 100644
--- a/src/video_core/engines/puller.h
+++ b/src/video_core/engines/puller.h
@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
// SPDX-FileCopyrightText: 2022 yuzu Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
@@ -20,6 +23,7 @@ class MemoryManager;
class DmaPusher;
enum class EngineID {
+ NV01_TIMER = 0x0004,
FERMI_TWOD_A = 0x902D, // 2D Engine
MAXWELL_B = 0xB197, // 3D Engine
KEPLER_COMPUTE_B = 0xB1C0,
diff --git a/src/video_core/macro.cpp b/src/video_core/macro.cpp
index 3fe69be4dd..0d1fe0a52b 100644
--- a/src/video_core/macro.cpp
+++ b/src/video_core/macro.cpp
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project
@@ -10,6 +10,7 @@
#include
#include
+#include
#ifdef ARCHITECTURE_x86_64
// xbyak hates human beings
#ifdef __GNUC__
@@ -73,601 +74,411 @@ bool IsTopologySafe(Maxwell3D::Regs::PrimitiveTopology topology) {
}
}
-class HLEMacroImpl : public CachedMacro {
-public:
- explicit HLEMacroImpl(Maxwell3D& maxwell3d_)
- : CachedMacro(maxwell3d_)
- {}
-};
+} // Anonymous namespace
-/// @note: these macros have two versions, a normal and extended version, with the extended version
-/// also assigning the base vertex/instance.
-template
-class HLE_DrawArraysIndirect final : public HLEMacroImpl {
-public:
- explicit HLE_DrawArraysIndirect(Maxwell3D& maxwell3d_)
- : HLEMacroImpl(maxwell3d_)
- {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- auto topology = static_cast(parameters[0]);
- if (!maxwell3d.AnyParametersDirty() || !IsTopologySafe(topology)) {
- Fallback(parameters);
- return;
- }
-
- auto& params = maxwell3d.draw_manager->GetIndirectParams();
- params.is_byte_count = false;
- params.is_indexed = false;
- params.include_count = false;
- params.count_start_address = 0;
- params.indirect_start_address = maxwell3d.GetMacroAddress(1);
- params.buffer_size = 4 * sizeof(u32);
- params.max_draw_counts = 1;
- params.stride = 0;
-
- if (extended) {
- maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
- maxwell3d.SetHLEReplacementAttributeType(0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
- }
-
- maxwell3d.draw_manager->DrawArrayIndirect(topology);
-
- if (extended) {
- maxwell3d.engine_state = Maxwell3D::EngineHint::None;
- maxwell3d.replace_table.clear();
- }
+void HLE_DrawArraysIndirect::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ auto topology = static_cast(parameters[0]);
+ if (!maxwell3d.AnyParametersDirty() || !IsTopologySafe(topology)) {
+ Fallback(maxwell3d, parameters);
+ return;
}
-private:
- void Fallback(const std::vector& parameters) {
- SCOPE_EXIT {
- if (extended) {
- maxwell3d.engine_state = Maxwell3D::EngineHint::None;
- maxwell3d.replace_table.clear();
- }
- };
- maxwell3d.RefreshParameters();
- const u32 instance_count = (maxwell3d.GetRegisterValue(0xD1B) & parameters[2]);
+ auto& params = maxwell3d.draw_manager->GetIndirectParams();
+ params.is_byte_count = false;
+ params.is_indexed = false;
+ params.include_count = false;
+ params.count_start_address = 0;
+ params.indirect_start_address = maxwell3d.GetMacroAddress(1);
+ params.buffer_size = 4 * sizeof(u32);
+ params.max_draw_counts = 1;
+ params.stride = 0;
- auto topology = static_cast(parameters[0]);
- const u32 vertex_first = parameters[3];
- const u32 vertex_count = parameters[1];
-
- if (!IsTopologySafe(topology) && size_t(maxwell3d.GetMaxCurrentVertices()) < size_t(vertex_first) + size_t(vertex_count)) {
- ASSERT(false && "Faulty draw!");
- return;
- }
-
- const u32 base_instance = parameters[4];
- if (extended) {
- maxwell3d.regs.global_base_instance_index = base_instance;
- maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
- maxwell3d.SetHLEReplacementAttributeType(
- 0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
- }
-
- maxwell3d.draw_manager->DrawArray(topology, vertex_first, vertex_count, base_instance,
- instance_count);
-
- if (extended) {
- maxwell3d.regs.global_base_instance_index = 0;
- maxwell3d.engine_state = Maxwell3D::EngineHint::None;
- maxwell3d.replace_table.clear();
- }
- }
-};
-
-/*
- * @note: these macros have two versions, a normal and extended version, with the extended version
- * also assigning the base vertex/instance.
- */
-template
-class HLE_DrawIndexedIndirect final : public HLEMacroImpl {
-public:
- explicit HLE_DrawIndexedIndirect(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- auto topology = static_cast(parameters[0]);
- if (!maxwell3d.AnyParametersDirty() || !IsTopologySafe(topology)) {
- Fallback(parameters);
- return;
- }
-
- const u32 estimate = static_cast(maxwell3d.EstimateIndexBufferSize());
- const u32 element_base = parameters[4];
- const u32 base_instance = parameters[5];
- maxwell3d.regs.vertex_id_base = element_base;
- maxwell3d.regs.global_base_vertex_index = element_base;
- maxwell3d.regs.global_base_instance_index = base_instance;
- maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
- if (extended) {
- maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
- maxwell3d.SetHLEReplacementAttributeType(0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseVertex);
- maxwell3d.SetHLEReplacementAttributeType(0, 0x644, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
- }
- auto& params = maxwell3d.draw_manager->GetIndirectParams();
- params.is_byte_count = false;
- params.is_indexed = true;
- params.include_count = false;
- params.count_start_address = 0;
- params.indirect_start_address = maxwell3d.GetMacroAddress(1);
- params.buffer_size = 5 * sizeof(u32);
- params.max_draw_counts = 1;
- params.stride = 0;
- maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
- maxwell3d.draw_manager->DrawIndexedIndirect(topology, 0, estimate);
- maxwell3d.regs.vertex_id_base = 0x0;
- maxwell3d.regs.global_base_vertex_index = 0x0;
- maxwell3d.regs.global_base_instance_index = 0x0;
- if (extended) {
- maxwell3d.engine_state = Maxwell3D::EngineHint::None;
- maxwell3d.replace_table.clear();
- }
- }
-
-private:
- void Fallback(const std::vector& parameters) {
- maxwell3d.RefreshParameters();
- const u32 instance_count = (maxwell3d.GetRegisterValue(0xD1B) & parameters[2]);
- const u32 element_base = parameters[4];
- const u32 base_instance = parameters[5];
- maxwell3d.regs.vertex_id_base = element_base;
- maxwell3d.regs.global_base_vertex_index = element_base;
- maxwell3d.regs.global_base_instance_index = base_instance;
- maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
- if (extended) {
- maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
- maxwell3d.SetHLEReplacementAttributeType(0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseVertex);
- maxwell3d.SetHLEReplacementAttributeType(0, 0x644, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
- }
-
- maxwell3d.draw_manager->DrawIndex(Tegra::Maxwell3D::Regs::PrimitiveTopology(parameters[0]), parameters[3], parameters[1], element_base, base_instance, instance_count);
-
- maxwell3d.regs.vertex_id_base = 0x0;
- maxwell3d.regs.global_base_vertex_index = 0x0;
- maxwell3d.regs.global_base_instance_index = 0x0;
- if (extended) {
- maxwell3d.engine_state = Maxwell3D::EngineHint::None;
- maxwell3d.replace_table.clear();
- }
- }
-};
-
-class HLE_MultiLayerClear final : public HLEMacroImpl {
-public:
- explicit HLE_MultiLayerClear(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- maxwell3d.RefreshParameters();
- ASSERT(parameters.size() == 1);
-
- const Maxwell3D::Regs::ClearSurface clear_params{parameters[0]};
- const u32 rt_index = clear_params.RT;
- const u32 num_layers = maxwell3d.regs.rt[rt_index].depth;
- ASSERT(clear_params.layer == 0);
-
- maxwell3d.regs.clear_surface.raw = clear_params.raw;
- maxwell3d.draw_manager->Clear(num_layers);
- }
-};
-
-class HLE_MultiDrawIndexedIndirectCount final : public HLEMacroImpl {
-public:
- explicit HLE_MultiDrawIndexedIndirectCount(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- const auto topology = Maxwell3D::Regs::PrimitiveTopology(parameters[2]);
- if (!IsTopologySafe(topology)) {
- Fallback(parameters);
- return;
- }
-
- const u32 start_indirect = parameters[0];
- const u32 end_indirect = parameters[1];
- if (start_indirect >= end_indirect) {
- // Nothing to do.
- return;
- }
-
- const u32 padding = parameters[3]; // padding is in words
-
- // size of each indirect segment
- const u32 indirect_words = 5 + padding;
- const u32 stride = indirect_words * sizeof(u32);
- const std::size_t draw_count = end_indirect - start_indirect;
- const u32 estimate = static_cast(maxwell3d.EstimateIndexBufferSize());
- maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
- auto& params = maxwell3d.draw_manager->GetIndirectParams();
- params.is_byte_count = false;
- params.is_indexed = true;
- params.include_count = true;
- params.count_start_address = maxwell3d.GetMacroAddress(4);
- params.indirect_start_address = maxwell3d.GetMacroAddress(5);
- params.buffer_size = stride * draw_count;
- params.max_draw_counts = draw_count;
- params.stride = stride;
- maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
+ if (extended) {
maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
- maxwell3d.SetHLEReplacementAttributeType(
- 0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseVertex);
- maxwell3d.SetHLEReplacementAttributeType(
- 0, 0x644, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
- maxwell3d.SetHLEReplacementAttributeType(0, 0x648,
- Maxwell3D::HLEReplacementAttributeType::DrawID);
- maxwell3d.draw_manager->DrawIndexedIndirect(topology, 0, estimate);
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
+ }
+
+ maxwell3d.draw_manager->DrawArrayIndirect(topology);
+
+ if (extended) {
maxwell3d.engine_state = Maxwell3D::EngineHint::None;
maxwell3d.replace_table.clear();
}
-
-private:
- void Fallback(const std::vector& parameters) {
- SCOPE_EXIT {
- // Clean everything.
- maxwell3d.regs.vertex_id_base = 0x0;
+}
+void HLE_DrawArraysIndirect::Fallback(Engines::Maxwell3D& maxwell3d, std::span parameters) {
+ SCOPE_EXIT {
+ if (extended) {
maxwell3d.engine_state = Maxwell3D::EngineHint::None;
maxwell3d.replace_table.clear();
- };
- maxwell3d.RefreshParameters();
- const u32 start_indirect = parameters[0];
- const u32 end_indirect = parameters[1];
- if (start_indirect >= end_indirect) {
- // Nothing to do.
- return;
- }
- const auto topology = static_cast(parameters[2]);
- const u32 padding = parameters[3];
- const std::size_t max_draws = parameters[4];
-
- const u32 indirect_words = 5 + padding;
- const std::size_t first_draw = start_indirect;
- const std::size_t effective_draws = end_indirect - start_indirect;
- const std::size_t last_draw = start_indirect + (std::min)(effective_draws, max_draws);
-
- for (std::size_t index = first_draw; index < last_draw; index++) {
- const std::size_t base = index * indirect_words + 5;
- const u32 base_vertex = parameters[base + 3];
- const u32 base_instance = parameters[base + 4];
- maxwell3d.regs.vertex_id_base = base_vertex;
- maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
- maxwell3d.SetHLEReplacementAttributeType(
- 0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseVertex);
- maxwell3d.SetHLEReplacementAttributeType(
- 0, 0x644, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
- maxwell3d.CallMethod(0x8e3, 0x648, true);
- maxwell3d.CallMethod(0x8e4, static_cast(index), true);
- maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
- maxwell3d.draw_manager->DrawIndex(topology, parameters[base + 2], parameters[base],
- base_vertex, base_instance, parameters[base + 1]);
}
+ };
+ maxwell3d.RefreshParameters();
+ const u32 instance_count = (maxwell3d.GetRegisterValue(0xD1B) & parameters[2]);
+ auto topology = Maxwell3D::Regs::PrimitiveTopology(parameters[0]);
+ const u32 vertex_first = parameters[3];
+ const u32 vertex_count = parameters[1];
+ if (!IsTopologySafe(topology) && size_t(maxwell3d.GetMaxCurrentVertices()) < size_t(vertex_first) + size_t(vertex_count)) {
+ ASSERT(false && "Faulty draw!");
+ return;
}
-};
-
-class HLE_DrawIndirectByteCount final : public HLEMacroImpl {
-public:
- explicit HLE_DrawIndirectByteCount(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- const bool force = maxwell3d.Rasterizer().HasDrawTransformFeedback();
-
- auto topology = static_cast(parameters[0] & 0xFFFFU);
- if (!force && (!maxwell3d.AnyParametersDirty() || !IsTopologySafe(topology))) {
- Fallback(parameters);
- return;
- }
- auto& params = maxwell3d.draw_manager->GetIndirectParams();
- params.is_byte_count = true;
- params.is_indexed = false;
- params.include_count = false;
- params.count_start_address = 0;
- params.indirect_start_address = maxwell3d.GetMacroAddress(2);
- params.buffer_size = 4;
- params.max_draw_counts = 1;
- params.stride = parameters[1];
- maxwell3d.regs.draw.begin = parameters[0];
- maxwell3d.regs.draw_auto_stride = parameters[1];
- maxwell3d.regs.draw_auto_byte_count = parameters[2];
-
- maxwell3d.draw_manager->DrawArrayIndirect(topology);
+ const u32 base_instance = parameters[4];
+ if (extended) {
+ maxwell3d.regs.global_base_instance_index = base_instance;
+ maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
}
-
-private:
- void Fallback(const std::vector& parameters) {
- maxwell3d.RefreshParameters();
-
- maxwell3d.regs.draw.begin = parameters[0];
- maxwell3d.regs.draw_auto_stride = parameters[1];
- maxwell3d.regs.draw_auto_byte_count = parameters[2];
-
- maxwell3d.draw_manager->DrawArray(
- maxwell3d.regs.draw.topology, 0,
- maxwell3d.regs.draw_auto_byte_count / maxwell3d.regs.draw_auto_stride, 0, 1);
- }
-};
-
-class HLE_C713C83D8F63CCF3 final : public HLEMacroImpl {
-public:
- explicit HLE_C713C83D8F63CCF3(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- maxwell3d.RefreshParameters();
- const u32 offset = (parameters[0] & 0x3FFFFFFF) << 2;
- const u32 address = maxwell3d.regs.shadow_scratch[24];
- auto& const_buffer = maxwell3d.regs.const_buffer;
- const_buffer.size = 0x7000;
- const_buffer.address_high = (address >> 24) & 0xFF;
- const_buffer.address_low = address << 8;
- const_buffer.offset = offset;
- }
-};
-
-class HLE_D7333D26E0A93EDE final : public HLEMacroImpl {
-public:
- explicit HLE_D7333D26E0A93EDE(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- maxwell3d.RefreshParameters();
- const size_t index = parameters[0];
- const u32 address = maxwell3d.regs.shadow_scratch[42 + index];
- const u32 size = maxwell3d.regs.shadow_scratch[47 + index];
- auto& const_buffer = maxwell3d.regs.const_buffer;
- const_buffer.size = size;
- const_buffer.address_high = (address >> 24) & 0xFF;
- const_buffer.address_low = address << 8;
- }
-};
-
-class HLE_BindShader final : public HLEMacroImpl {
-public:
- explicit HLE_BindShader(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- maxwell3d.RefreshParameters();
- auto& regs = maxwell3d.regs;
- const u32 index = parameters[0];
- if ((parameters[1] - regs.shadow_scratch[28 + index]) == 0) {
- return;
- }
-
- regs.pipelines[index & 0xF].offset = parameters[2];
- maxwell3d.dirty.flags[VideoCommon::Dirty::Shaders] = true;
- regs.shadow_scratch[28 + index] = parameters[1];
- regs.shadow_scratch[34 + index] = parameters[2];
-
- const u32 address = parameters[4];
- auto& const_buffer = regs.const_buffer;
- const_buffer.size = 0x10000;
- const_buffer.address_high = (address >> 24) & 0xFF;
- const_buffer.address_low = address << 8;
-
- const size_t bind_group_id = parameters[3] & 0x7F;
- auto& bind_group = regs.bind_groups[bind_group_id];
- bind_group.raw_config = 0x11;
- maxwell3d.ProcessCBBind(bind_group_id);
- }
-};
-
-class HLE_SetRasterBoundingBox final : public HLEMacroImpl {
-public:
- explicit HLE_SetRasterBoundingBox(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- maxwell3d.RefreshParameters();
- const u32 raster_mode = parameters[0];
- auto& regs = maxwell3d.regs;
- const u32 raster_enabled = maxwell3d.regs.conservative_raster_enable;
- const u32 scratch_data = maxwell3d.regs.shadow_scratch[52];
- regs.raster_bounding_box.raw = raster_mode & 0xFFFFF00F;
- regs.raster_bounding_box.pad.Assign(scratch_data & raster_enabled);
- }
-};
-
-template
-class HLE_ClearConstBuffer final : public HLEMacroImpl {
-public:
- explicit HLE_ClearConstBuffer(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- maxwell3d.RefreshParameters();
- static constexpr std::array zeroes{};
- auto& regs = maxwell3d.regs;
- regs.const_buffer.size = u32(base_size);
- regs.const_buffer.address_high = parameters[0];
- regs.const_buffer.address_low = parameters[1];
- regs.const_buffer.offset = 0;
- maxwell3d.ProcessCBMultiData(zeroes.data(), parameters[2] * 4);
- }
-};
-
-class HLE_ClearMemory final : public HLEMacroImpl {
-public:
- explicit HLE_ClearMemory(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- maxwell3d.RefreshParameters();
-
- const u32 needed_memory = parameters[2] / sizeof(u32);
- if (needed_memory > zero_memory.size()) {
- zero_memory.resize(needed_memory, 0);
- }
- auto& regs = maxwell3d.regs;
- regs.upload.line_length_in = parameters[2];
- regs.upload.line_count = 1;
- regs.upload.dest.address_high = parameters[0];
- regs.upload.dest.address_low = parameters[1];
- maxwell3d.CallMethod(size_t(MAXWELL3D_REG_INDEX(launch_dma)), 0x1011, true);
- maxwell3d.CallMultiMethod(size_t(MAXWELL3D_REG_INDEX(inline_data)), zero_memory.data(), needed_memory, needed_memory);
- }
-
-private:
- std::vector zero_memory;
-};
-
-class HLE_TransformFeedbackSetup final : public HLEMacroImpl {
-public:
- explicit HLE_TransformFeedbackSetup(Maxwell3D& maxwell3d_) : HLEMacroImpl(maxwell3d_) {}
-
- void Execute(const std::vector& parameters, [[maybe_unused]] u32 method) override {
- maxwell3d.RefreshParameters();
-
- auto& regs = maxwell3d.regs;
- regs.transform_feedback_enabled = 1;
- regs.transform_feedback.buffers[0].start_offset = 0;
- regs.transform_feedback.buffers[1].start_offset = 0;
- regs.transform_feedback.buffers[2].start_offset = 0;
- regs.transform_feedback.buffers[3].start_offset = 0;
-
- regs.upload.line_length_in = 4;
- regs.upload.line_count = 1;
- regs.upload.dest.address_high = parameters[0];
- regs.upload.dest.address_low = parameters[1];
- maxwell3d.CallMethod(size_t(MAXWELL3D_REG_INDEX(launch_dma)), 0x1011, true);
- maxwell3d.CallMethod(size_t(MAXWELL3D_REG_INDEX(inline_data)), regs.transform_feedback.controls[0].stride, true);
-
- maxwell3d.Rasterizer().RegisterTransformFeedback(regs.upload.dest.Address());
- }
-};
-
-} // Anonymous namespace
-
-HLEMacro::HLEMacro(Maxwell3D& maxwell3d_) : maxwell3d{maxwell3d_} {}
-
-HLEMacro::~HLEMacro() = default;
-
-std::unique_ptr HLEMacro::GetHLEProgram(u64 hash) const {
- // Compiler will make you a GREAT job at making an ad-hoc hash table :)
- switch (hash) {
- case 0x0D61FC9FAAC9FCADULL: return std::make_unique>(maxwell3d);
- case 0x8A4D173EB99A8603ULL: return std::make_unique>(maxwell3d);
- case 0x771BB18C62444DA0ULL: return std::make_unique>(maxwell3d);
- case 0x0217920100488FF7ULL: return std::make_unique>(maxwell3d);
- case 0x3F5E74B9C9A50164ULL: return std::make_unique(maxwell3d);
- case 0xEAD26C3E2109B06BULL: return std::make_unique(maxwell3d);
- case 0xC713C83D8F63CCF3ULL: return std::make_unique(maxwell3d);
- case 0xD7333D26E0A93EDEULL: return std::make_unique(maxwell3d);
- case 0xEB29B2A09AA06D38ULL: return std::make_unique(maxwell3d);
- case 0xDB1341DBEB4C8AF7ULL: return std::make_unique(maxwell3d);
- case 0x6C97861D891EDf7EULL: return std::make_unique>(maxwell3d);
- case 0xD246FDDF3A6173D7ULL: return std::make_unique>(maxwell3d);
- case 0xEE4D0004BEC8ECF4ULL: return std::make_unique(maxwell3d);
- case 0xFC0CF27F5FFAA661ULL: return std::make_unique(maxwell3d);
- case 0xB5F74EDB717278ECULL: return std::make_unique(maxwell3d);
- default:
- return nullptr;
+ maxwell3d.draw_manager->DrawArray(topology, vertex_first, vertex_count, base_instance, instance_count);
+ if (extended) {
+ maxwell3d.regs.global_base_instance_index = 0;
+ maxwell3d.engine_state = Maxwell3D::EngineHint::None;
+ maxwell3d.replace_table.clear();
}
}
-namespace {
-class MacroInterpreterImpl final : public CachedMacro {
-public:
- explicit MacroInterpreterImpl(Engines::Maxwell3D& maxwell3d_, const std::vector& code_)
- : CachedMacro(maxwell3d_)
- , code{code_}
- {}
+void HLE_DrawIndexedIndirect::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ auto topology = static_cast(parameters[0]);
+ if (!maxwell3d.AnyParametersDirty() || !IsTopologySafe(topology)) {
+ Fallback(maxwell3d, parameters);
+ return;
+ }
- void Execute(const std::vector& params, u32 method) override;
+ const u32 estimate = u32(maxwell3d.EstimateIndexBufferSize());
+ const u32 element_base = parameters[4];
+ const u32 base_instance = parameters[5];
+ maxwell3d.regs.vertex_id_base = element_base;
+ maxwell3d.regs.global_base_vertex_index = element_base;
+ maxwell3d.regs.global_base_instance_index = base_instance;
+ maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
+ if (extended) {
+ maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseVertex);
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x644, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
+ }
+ auto& params = maxwell3d.draw_manager->GetIndirectParams();
+ params.is_byte_count = false;
+ params.is_indexed = true;
+ params.include_count = false;
+ params.count_start_address = 0;
+ params.indirect_start_address = maxwell3d.GetMacroAddress(1);
+ params.buffer_size = 5 * sizeof(u32);
+ params.max_draw_counts = 1;
+ params.stride = 0;
+ maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
+ maxwell3d.draw_manager->DrawIndexedIndirect(topology, 0, estimate);
+ maxwell3d.regs.vertex_id_base = 0x0;
+ maxwell3d.regs.global_base_vertex_index = 0x0;
+ maxwell3d.regs.global_base_instance_index = 0x0;
+ if (extended) {
+ maxwell3d.engine_state = Maxwell3D::EngineHint::None;
+ maxwell3d.replace_table.clear();
+ }
+}
+void HLE_DrawIndexedIndirect::Fallback(Engines::Maxwell3D& maxwell3d, std::span parameters) {
+ maxwell3d.RefreshParameters();
+ const u32 instance_count = (maxwell3d.GetRegisterValue(0xD1B) & parameters[2]);
+ const u32 element_base = parameters[4];
+ const u32 base_instance = parameters[5];
+ maxwell3d.regs.vertex_id_base = element_base;
+ maxwell3d.regs.global_base_vertex_index = element_base;
+ maxwell3d.regs.global_base_instance_index = base_instance;
+ maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
+ if (extended) {
+ maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseVertex);
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x644, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
+ }
+ maxwell3d.draw_manager->DrawIndex(Tegra::Maxwell3D::Regs::PrimitiveTopology(parameters[0]), parameters[3], parameters[1], element_base, base_instance, instance_count);
+ maxwell3d.regs.vertex_id_base = 0x0;
+ maxwell3d.regs.global_base_vertex_index = 0x0;
+ maxwell3d.regs.global_base_instance_index = 0x0;
+ if (extended) {
+ maxwell3d.engine_state = Maxwell3D::EngineHint::None;
+ maxwell3d.replace_table.clear();
+ }
+}
+void HLE_MultiLayerClear::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ maxwell3d.RefreshParameters();
+ ASSERT(parameters.size() == 1);
-private:
- /// Resets the execution engine state, zeroing registers, etc.
- void Reset();
+ const Maxwell3D::Regs::ClearSurface clear_params{parameters[0]};
+ const u32 rt_index = clear_params.RT;
+ const u32 num_layers = maxwell3d.regs.rt[rt_index].depth;
+ ASSERT(clear_params.layer == 0);
- /**
- * Executes a single macro instruction located at the current program counter. Returns whether
- * the interpreter should keep running.
- *
- * @param is_delay_slot Whether the current step is being executed due to a delay slot in a
- * previous instruction.
- */
- bool Step(bool is_delay_slot);
+ maxwell3d.regs.clear_surface.raw = clear_params.raw;
+ maxwell3d.draw_manager->Clear(num_layers);
+}
+void HLE_MultiDrawIndexedIndirectCount::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ const auto topology = Maxwell3D::Regs::PrimitiveTopology(parameters[2]);
+ if (!IsTopologySafe(topology)) {
+ Fallback(maxwell3d, parameters);
+ return;
+ }
- /// Calculates the result of an ALU operation. src_a OP src_b;
- u32 GetALUResult(Macro::ALUOperation operation, u32 src_a, u32 src_b);
+ const u32 start_indirect = parameters[0];
+ const u32 end_indirect = parameters[1];
+ if (start_indirect >= end_indirect) {
+ // Nothing to do.
+ return;
+ }
- /// Performs the result operation on the input result and stores it in the specified register
- /// (if necessary).
- void ProcessResult(Macro::ResultOperation operation, u32 reg, u32 result);
+ const u32 padding = parameters[3]; // padding is in words
- /// Evaluates the branch condition and returns whether the branch should be taken or not.
- bool EvaluateBranchCondition(Macro::BranchCondition cond, u32 value) const;
+ // size of each indirect segment
+ const u32 indirect_words = 5 + padding;
+ const u32 stride = indirect_words * sizeof(u32);
+ const std::size_t draw_count = end_indirect - start_indirect;
+ const u32 estimate = static_cast(maxwell3d.EstimateIndexBufferSize());
+ maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
+ auto& params = maxwell3d.draw_manager->GetIndirectParams();
+ params.is_byte_count = false;
+ params.is_indexed = true;
+ params.include_count = true;
+ params.count_start_address = maxwell3d.GetMacroAddress(4);
+ params.indirect_start_address = maxwell3d.GetMacroAddress(5);
+ params.buffer_size = stride * draw_count;
+ params.max_draw_counts = draw_count;
+ params.stride = stride;
+ maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
+ maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseVertex);
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x644, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x648, Maxwell3D::HLEReplacementAttributeType::DrawID);
+ maxwell3d.draw_manager->DrawIndexedIndirect(topology, 0, estimate);
+ maxwell3d.engine_state = Maxwell3D::EngineHint::None;
+ maxwell3d.replace_table.clear();
+}
+void HLE_MultiDrawIndexedIndirectCount::Fallback(Engines::Maxwell3D& maxwell3d, std::span parameters) {
+ SCOPE_EXIT {
+ // Clean everything.
+ maxwell3d.regs.vertex_id_base = 0x0;
+ maxwell3d.engine_state = Maxwell3D::EngineHint::None;
+ maxwell3d.replace_table.clear();
+ };
+ maxwell3d.RefreshParameters();
+ const u32 start_indirect = parameters[0];
+ const u32 end_indirect = parameters[1];
+ if (start_indirect >= end_indirect) {
+ // Nothing to do.
+ return;
+ }
+ const auto topology = static_cast(parameters[2]);
+ const u32 padding = parameters[3];
+ const std::size_t max_draws = parameters[4];
+ const u32 indirect_words = 5 + padding;
+ const std::size_t first_draw = start_indirect;
+ const std::size_t effective_draws = end_indirect - start_indirect;
+ const std::size_t last_draw = start_indirect + (std::min)(effective_draws, max_draws);
+ for (std::size_t index = first_draw; index < last_draw; index++) {
+ const std::size_t base = index * indirect_words + 5;
+ const u32 base_vertex = parameters[base + 3];
+ const u32 base_instance = parameters[base + 4];
+ maxwell3d.regs.vertex_id_base = base_vertex;
+ maxwell3d.engine_state = Maxwell3D::EngineHint::OnHLEMacro;
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x640, Maxwell3D::HLEReplacementAttributeType::BaseVertex);
+ maxwell3d.SetHLEReplacementAttributeType(0, 0x644, Maxwell3D::HLEReplacementAttributeType::BaseInstance);
+ maxwell3d.CallMethod(0x8e3, 0x648, true);
+ maxwell3d.CallMethod(0x8e4, static_cast(index), true);
+ maxwell3d.dirty.flags[VideoCommon::Dirty::IndexBuffer] = true;
+ maxwell3d.draw_manager->DrawIndex(topology, parameters[base + 2], parameters[base], base_vertex, base_instance, parameters[base + 1]);
+ }
+}
+void HLE_DrawIndirectByteCount::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ const bool force = maxwell3d.Rasterizer().HasDrawTransformFeedback();
+ auto topology = Maxwell3D::Regs::PrimitiveTopology(parameters[0] & 0xFFFFU);
+ if (!force && (!maxwell3d.AnyParametersDirty() || !IsTopologySafe(topology))) {
+ Fallback(maxwell3d, parameters);
+ return;
+ }
+ auto& params = maxwell3d.draw_manager->GetIndirectParams();
+ params.is_byte_count = true;
+ params.is_indexed = false;
+ params.include_count = false;
+ params.count_start_address = 0;
+ params.indirect_start_address = maxwell3d.GetMacroAddress(2);
+ params.buffer_size = 4;
+ params.max_draw_counts = 1;
+ params.stride = parameters[1];
+ maxwell3d.regs.draw.begin = parameters[0];
+ maxwell3d.regs.draw_auto_stride = parameters[1];
+ maxwell3d.regs.draw_auto_byte_count = parameters[2];
+ maxwell3d.draw_manager->DrawArrayIndirect(topology);
+}
+void HLE_DrawIndirectByteCount::Fallback(Engines::Maxwell3D& maxwell3d, std::span parameters) {
+ maxwell3d.RefreshParameters();
- /// Reads an opcode at the current program counter location.
- Macro::Opcode GetOpcode() const;
+ maxwell3d.regs.draw.begin = parameters[0];
+ maxwell3d.regs.draw_auto_stride = parameters[1];
+ maxwell3d.regs.draw_auto_byte_count = parameters[2];
- /// Returns the specified register's value. Register 0 is hardcoded to always return 0.
- u32 GetRegister(u32 register_id) const;
+ maxwell3d.draw_manager->DrawArray(
+ maxwell3d.regs.draw.topology, 0,
+ maxwell3d.regs.draw_auto_byte_count / maxwell3d.regs.draw_auto_stride, 0, 1);
+}
+void HLE_C713C83D8F63CCF3::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ maxwell3d.RefreshParameters();
+ const u32 offset = (parameters[0] & 0x3FFFFFFF) << 2;
+ const u32 address = maxwell3d.regs.shadow_scratch[24];
+ auto& const_buffer = maxwell3d.regs.const_buffer;
+ const_buffer.size = 0x7000;
+ const_buffer.address_high = (address >> 24) & 0xFF;
+ const_buffer.address_low = address << 8;
+ const_buffer.offset = offset;
+}
+void HLE_D7333D26E0A93EDE::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ maxwell3d.RefreshParameters();
+ const size_t index = parameters[0];
+ const u32 address = maxwell3d.regs.shadow_scratch[42 + index];
+ const u32 size = maxwell3d.regs.shadow_scratch[47 + index];
+ auto& const_buffer = maxwell3d.regs.const_buffer;
+ const_buffer.size = size;
+ const_buffer.address_high = (address >> 24) & 0xFF;
+ const_buffer.address_low = address << 8;
+}
+void HLE_BindShader::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ maxwell3d.RefreshParameters();
+ auto& regs = maxwell3d.regs;
+ const u32 index = parameters[0];
+ if ((parameters[1] - regs.shadow_scratch[28 + index]) == 0) {
+ return;
+ }
- /// Sets the register to the input value.
- void SetRegister(u32 register_id, u32 value);
+ regs.pipelines[index & 0xF].offset = parameters[2];
+ maxwell3d.dirty.flags[VideoCommon::Dirty::Shaders] = true;
+ regs.shadow_scratch[28 + index] = parameters[1];
+ regs.shadow_scratch[34 + index] = parameters[2];
- /// Sets the method address to use for the next Send instruction.
- void SetMethodAddress(u32 address);
+ const u32 address = parameters[4];
+ auto& const_buffer = regs.const_buffer;
+ const_buffer.size = 0x10000;
+ const_buffer.address_high = (address >> 24) & 0xFF;
+ const_buffer.address_low = address << 8;
- /// Calls a GPU Engine method with the input parameter.
- void Send(u32 value);
+ const size_t bind_group_id = parameters[3] & 0x7F;
+ auto& bind_group = regs.bind_groups[bind_group_id];
+ bind_group.raw_config = 0x11;
+ maxwell3d.ProcessCBBind(bind_group_id);
+}
+void HLE_SetRasterBoundingBox::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ maxwell3d.RefreshParameters();
+ const u32 raster_mode = parameters[0];
+ auto& regs = maxwell3d.regs;
+ const u32 raster_enabled = maxwell3d.regs.conservative_raster_enable;
+ const u32 scratch_data = maxwell3d.regs.shadow_scratch[52];
+ regs.raster_bounding_box.raw = raster_mode & 0xFFFFF00F;
+ regs.raster_bounding_box.pad.Assign(scratch_data & raster_enabled);
+}
+void HLE_ClearConstBuffer::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ static constexpr std::array zeroes{}; //must be bigger than either 7000 or 5F00
+ maxwell3d.RefreshParameters();
+ auto& regs = maxwell3d.regs;
+ regs.const_buffer.size = u32(base_size);
+ regs.const_buffer.address_high = parameters[0];
+ regs.const_buffer.address_low = parameters[1];
+ regs.const_buffer.offset = 0;
+ maxwell3d.ProcessCBMultiData(zeroes.data(), parameters[2] * 4);
+}
+void HLE_ClearMemory::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ maxwell3d.RefreshParameters();
+ const u32 needed_memory = parameters[2] / sizeof(u32);
+ if (needed_memory > zero_memory.size()) {
+ zero_memory.resize(needed_memory, 0);
+ }
+ auto& regs = maxwell3d.regs;
+ regs.upload.line_length_in = parameters[2];
+ regs.upload.line_count = 1;
+ regs.upload.dest.address_high = parameters[0];
+ regs.upload.dest.address_low = parameters[1];
+ maxwell3d.CallMethod(size_t(MAXWELL3D_REG_INDEX(launch_dma)), 0x1011, true);
+ maxwell3d.CallMultiMethod(size_t(MAXWELL3D_REG_INDEX(inline_data)), zero_memory.data(), needed_memory, needed_memory);
+}
+void HLE_TransformFeedbackSetup::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, [[maybe_unused]] u32 method) {
+ maxwell3d.RefreshParameters();
+ auto& regs = maxwell3d.regs;
+ regs.transform_feedback_enabled = 1;
+ regs.transform_feedback.buffers[0].start_offset = 0;
+ regs.transform_feedback.buffers[1].start_offset = 0;
+ regs.transform_feedback.buffers[2].start_offset = 0;
+ regs.transform_feedback.buffers[3].start_offset = 0;
+ regs.upload.line_length_in = 4;
+ regs.upload.line_count = 1;
+ regs.upload.dest.address_high = parameters[0];
+ regs.upload.dest.address_low = parameters[1];
+ maxwell3d.CallMethod(size_t(MAXWELL3D_REG_INDEX(launch_dma)), 0x1011, true);
+ maxwell3d.CallMethod(size_t(MAXWELL3D_REG_INDEX(inline_data)), regs.transform_feedback.controls[0].stride, true);
+ maxwell3d.Rasterizer().RegisterTransformFeedback(regs.upload.dest.Address());
+}
- /// Reads a GPU register located at the method address.
- u32 Read(u32 method) const;
+#define HLE_MACRO_LIST \
+ HLE_MACRO_ELEM(0x0D61FC9FAAC9FCADULL, HLE_DrawArraysIndirect, (false)) \
+ HLE_MACRO_ELEM(0x8A4D173EB99A8603ULL, HLE_DrawArraysIndirect, (true)) \
+ HLE_MACRO_ELEM(0x771BB18C62444DA0ULL, HLE_DrawIndexedIndirect, (false)) \
+ HLE_MACRO_ELEM(0x0217920100488FF7ULL, HLE_DrawIndexedIndirect, (true)) \
+ HLE_MACRO_ELEM(0x3F5E74B9C9A50164ULL, HLE_MultiDrawIndexedIndirectCount, ()) \
+ HLE_MACRO_ELEM(0xEAD26C3E2109B06BULL, HLE_MultiLayerClear, ()) \
+ HLE_MACRO_ELEM(0xC713C83D8F63CCF3ULL, HLE_C713C83D8F63CCF3, ()) \
+ HLE_MACRO_ELEM(0xD7333D26E0A93EDEULL, HLE_D7333D26E0A93EDE, ()) \
+ HLE_MACRO_ELEM(0xEB29B2A09AA06D38ULL, HLE_BindShader, ()) \
+ HLE_MACRO_ELEM(0xDB1341DBEB4C8AF7ULL, HLE_SetRasterBoundingBox, ()) \
+ HLE_MACRO_ELEM(0x6C97861D891EDf7EULL, HLE_ClearConstBuffer, (0x5F00)) \
+ HLE_MACRO_ELEM(0xD246FDDF3A6173D7ULL, HLE_ClearConstBuffer, (0x7000)) \
+ HLE_MACRO_ELEM(0xEE4D0004BEC8ECF4ULL, HLE_ClearMemory, ()) \
+ HLE_MACRO_ELEM(0xFC0CF27F5FFAA661ULL, HLE_TransformFeedbackSetup, ()) \
+ HLE_MACRO_ELEM(0xB5F74EDB717278ECULL, HLE_DrawIndirectByteCount, ()) \
- /// Returns the next parameter in the parameter queue.
- u32 FetchParameter();
+// Allocates and returns a cached macro if the hash matches a known function.
+[[nodiscard]] inline AnyCachedMacro GetHLEProgram(u64 hash) noexcept {
+ // Compiler will make you a GREAT job at making an ad-hoc hash table :)
+ switch (hash) {
+#define HLE_MACRO_ELEM(HASH, TY, VAL) case HASH: return TY VAL;
+ HLE_MACRO_LIST
+#undef HLE_MACRO_ELEM
+ default: return std::monostate{};
+ }
+}
+[[nodiscard]] inline bool CanBeHLEProgram(u64 hash) noexcept {
+ switch (hash) {
+#define HLE_MACRO_ELEM(HASH, TY, VAL) case HASH: return true;
+ HLE_MACRO_LIST
+#undef HLE_MACRO_ELEM
+ default: return false;
+ }
+}
- /// Current program counter
- u32 pc{};
- /// Program counter to execute at after the delay slot is executed.
- std::optional delayed_pc;
-
- /// General purpose macro registers.
- std::array registers = {};
-
- /// Method address to use for the next Send instruction.
- Macro::MethodAddress method_address = {};
-
- /// Input parameters of the current macro.
- std::unique_ptr parameters;
- std::size_t num_parameters = 0;
- std::size_t parameters_capacity = 0;
- /// Index of the next parameter that will be fetched by the 'parm' instruction.
- u32 next_parameter_index = 0;
-
- bool carry_flag = false;
- const std::vector& code;
-};
-
-void MacroInterpreterImpl::Execute(const std::vector& params, u32 method) {
+void MacroInterpreterImpl::Execute(Engines::Maxwell3D& maxwell3d, std::span params, u32 method) {
Reset();
registers[1] = params[0];
- num_parameters = params.size();
-
- if (num_parameters > parameters_capacity) {
- parameters_capacity = num_parameters;
- parameters = std::make_unique(num_parameters);
- }
- std::memcpy(parameters.get(), params.data(), num_parameters * sizeof(u32));
+ parameters.resize(params.size());
+ std::memcpy(parameters.data(), params.data(), params.size() * sizeof(u32));
// Execute the code until we hit an exit condition.
bool keep_executing = true;
while (keep_executing) {
- keep_executing = Step(false);
+ keep_executing = Step(maxwell3d, false);
}
// Assert the the macro used all the input parameters
- ASSERT(next_parameter_index == num_parameters);
+ ASSERT(next_parameter_index == parameters.size());
}
+/// Resets the execution engine state, zeroing registers, etc.
void MacroInterpreterImpl::Reset() {
registers = {};
pc = 0;
delayed_pc = {};
method_address.raw = 0;
- num_parameters = 0;
+ // Vector must hold its last indices otherwise wonky shit will happen
// The next parameter index starts at 1, because $r1 already has the value of the first
// parameter.
next_parameter_index = 1;
carry_flag = false;
}
-bool MacroInterpreterImpl::Step(bool is_delay_slot) {
+/// @brief Executes a single macro instruction located at the current program counter. Returns whether
+/// the interpreter should keep running.
+/// @param is_delay_slot Whether the current step is being executed due to a delay slot in a previous instruction.
+bool MacroInterpreterImpl::Step(Engines::Maxwell3D& maxwell3d, bool is_delay_slot) {
u32 base_address = pc;
Macro::Opcode opcode = GetOpcode();
@@ -682,14 +493,12 @@ bool MacroInterpreterImpl::Step(bool is_delay_slot) {
switch (opcode.operation) {
case Macro::Operation::ALU: {
- u32 result = GetALUResult(opcode.alu_operation, GetRegister(opcode.src_a),
- GetRegister(opcode.src_b));
- ProcessResult(opcode.result_operation, opcode.dst, result);
+ u32 result = GetALUResult(opcode.alu_operation, GetRegister(opcode.src_a), GetRegister(opcode.src_b));
+ ProcessResult(maxwell3d, opcode.result_operation, opcode.dst, result);
break;
}
case Macro::Operation::AddImmediate: {
- ProcessResult(opcode.result_operation, opcode.dst,
- GetRegister(opcode.src_a) + opcode.immediate);
+ ProcessResult(maxwell3d, opcode.result_operation, opcode.dst, GetRegister(opcode.src_a) + opcode.immediate);
break;
}
case Macro::Operation::ExtractInsert: {
@@ -699,7 +508,7 @@ bool MacroInterpreterImpl::Step(bool is_delay_slot) {
src = (src >> opcode.bf_src_bit) & opcode.GetBitfieldMask();
dst &= ~(opcode.GetBitfieldMask() << opcode.bf_dst_bit);
dst |= src << opcode.bf_dst_bit;
- ProcessResult(opcode.result_operation, opcode.dst, dst);
+ ProcessResult(maxwell3d, opcode.result_operation, opcode.dst, dst);
break;
}
case Macro::Operation::ExtractShiftLeftImmediate: {
@@ -708,7 +517,7 @@ bool MacroInterpreterImpl::Step(bool is_delay_slot) {
u32 result = ((src >> dst) & opcode.GetBitfieldMask()) << opcode.bf_dst_bit;
- ProcessResult(opcode.result_operation, opcode.dst, result);
+ ProcessResult(maxwell3d, opcode.result_operation, opcode.dst, result);
break;
}
case Macro::Operation::ExtractShiftLeftRegister: {
@@ -717,12 +526,12 @@ bool MacroInterpreterImpl::Step(bool is_delay_slot) {
u32 result = ((src >> opcode.bf_src_bit) & opcode.GetBitfieldMask()) << dst;
- ProcessResult(opcode.result_operation, opcode.dst, result);
+ ProcessResult(maxwell3d, opcode.result_operation, opcode.dst, result);
break;
}
case Macro::Operation::Read: {
- u32 result = Read(GetRegister(opcode.src_a) + opcode.immediate);
- ProcessResult(opcode.result_operation, opcode.dst, result);
+ u32 result = Read(maxwell3d, GetRegister(opcode.src_a) + opcode.immediate);
+ ProcessResult(maxwell3d, opcode.result_operation, opcode.dst, result);
break;
}
case Macro::Operation::Branch: {
@@ -738,7 +547,7 @@ bool MacroInterpreterImpl::Step(bool is_delay_slot) {
delayed_pc = base_address + opcode.GetBranchTarget();
// Execute one more instruction due to the delay slot.
- return Step(true);
+ return Step(maxwell3d, true);
}
break;
}
@@ -751,13 +560,13 @@ bool MacroInterpreterImpl::Step(bool is_delay_slot) {
// cause an exit if it's executed inside a delay slot.
if (opcode.is_exit && !is_delay_slot) {
// Exit has a delay slot, execute the next instruction
- Step(true);
+ Step(maxwell3d, true);
return false;
}
-
return true;
}
+/// Calculates the result of an ALU operation. src_a OP src_b;
u32 MacroInterpreterImpl::GetALUResult(Macro::ALUOperation operation, u32 src_a, u32 src_b) {
switch (operation) {
case Macro::ALUOperation::Add: {
@@ -797,7 +606,8 @@ u32 MacroInterpreterImpl::GetALUResult(Macro::ALUOperation operation, u32 src_a,
}
}
-void MacroInterpreterImpl::ProcessResult(Macro::ResultOperation operation, u32 reg, u32 result) {
+/// Performs the result operation on the input result and stores it in the specified register (if necessary).
+void MacroInterpreterImpl::ProcessResult(Engines::Maxwell3D& maxwell3d, Macro::ResultOperation operation, u32 reg, u32 result) {
switch (operation) {
case Macro::ResultOperation::IgnoreAndFetch:
// Fetch parameter and ignore result.
@@ -815,12 +625,12 @@ void MacroInterpreterImpl::ProcessResult(Macro::ResultOperation operation, u32 r
case Macro::ResultOperation::FetchAndSend:
// Fetch parameter and send result.
SetRegister(reg, FetchParameter());
- Send(result);
+ Send(maxwell3d, result);
break;
case Macro::ResultOperation::MoveAndSend:
// Move and send result.
SetRegister(reg, result);
- Send(result);
+ Send(maxwell3d, result);
break;
case Macro::ResultOperation::FetchAndSetMethod:
// Fetch parameter and use result as Method Address.
@@ -831,13 +641,13 @@ void MacroInterpreterImpl::ProcessResult(Macro::ResultOperation operation, u32 r
// Move result and use as Method Address, then fetch and send parameter.
SetRegister(reg, result);
SetMethodAddress(result);
- Send(FetchParameter());
+ Send(maxwell3d, FetchParameter());
break;
case Macro::ResultOperation::MoveAndSetMethodSend:
// Move result and use as Method Address, then send bits 12:17 of result.
SetRegister(reg, result);
SetMethodAddress(result);
- Send((result >> 12) & 0b111111);
+ Send(maxwell3d, (result >> 12) & 0b111111);
break;
default:
UNIMPLEMENTED_MSG("Unimplemented result operation {}", operation);
@@ -845,6 +655,7 @@ void MacroInterpreterImpl::ProcessResult(Macro::ResultOperation operation, u32 r
}
}
+/// Evaluates the branch condition and returns whether the branch should be taken or not.
bool MacroInterpreterImpl::EvaluateBranchCondition(Macro::BranchCondition cond, u32 value) const {
switch (cond) {
case Macro::BranchCondition::Zero:
@@ -855,46 +666,44 @@ bool MacroInterpreterImpl::EvaluateBranchCondition(Macro::BranchCondition cond,
UNREACHABLE();
}
+/// Reads an opcode at the current program counter location.
Macro::Opcode MacroInterpreterImpl::GetOpcode() const {
ASSERT((pc % sizeof(u32)) == 0);
ASSERT(pc < code.size() * sizeof(u32));
return {code[pc / sizeof(u32)]};
}
+/// Returns the specified register's value. Register 0 is hardcoded to always return 0.
u32 MacroInterpreterImpl::GetRegister(u32 register_id) const {
- return registers.at(register_id);
+ return registers[register_id];
}
+/// Sets the register to the input value.
void MacroInterpreterImpl::SetRegister(u32 register_id, u32 value) {
// Register 0 is hardwired as the zero register.
// Ensure no writes to it actually occur.
- if (register_id == 0) {
+ if (register_id == 0)
return;
- }
-
- registers.at(register_id) = value;
+ registers[register_id] = value;
}
-void MacroInterpreterImpl::SetMethodAddress(u32 address) {
- method_address.raw = address;
-}
-
-void MacroInterpreterImpl::Send(u32 value) {
+/// Calls a GPU Engine method with the input parameter.
+void MacroInterpreterImpl::Send(Engines::Maxwell3D& maxwell3d, u32 value) {
maxwell3d.CallMethod(method_address.address, value, true);
// Increment the method address by the method increment.
- method_address.address.Assign(method_address.address.Value() +
- method_address.increment.Value());
+ method_address.address.Assign(method_address.address.Value() + method_address.increment.Value());
}
-u32 MacroInterpreterImpl::Read(u32 method) const {
+/// Reads a GPU register located at the method address.
+u32 MacroInterpreterImpl::Read(Engines::Maxwell3D& maxwell3d, u32 method) const {
return maxwell3d.GetRegisterValue(method);
}
+/// Returns the next parameter in the parameter queue.
u32 MacroInterpreterImpl::FetchParameter() {
- ASSERT(next_parameter_index < num_parameters);
+ ASSERT(next_parameter_index < parameters.size());
return parameters[next_parameter_index++];
}
-} // Anonymous namespace
#ifdef ARCHITECTURE_x86_64
namespace {
@@ -930,17 +739,15 @@ static const auto default_cg_mode = Xbyak::DontSetProtectRWE;
static const auto default_cg_mode = nullptr; //Allow RWE
#endif
-class MacroJITx64Impl final : public Xbyak::CodeGenerator, public CachedMacro {
-public:
- explicit MacroJITx64Impl(Engines::Maxwell3D& maxwell3d_, const std::vector& code_)
+struct MacroJITx64Impl final : public Xbyak::CodeGenerator, public DynamicCachedMacro {
+ explicit MacroJITx64Impl(std::span code_)
: Xbyak::CodeGenerator(MAX_CODE_SIZE, default_cg_mode)
- , CachedMacro(maxwell3d_)
, code{code_}
{
Compile();
}
- void Execute(const std::vector& parameters, u32 method) override;
+ void Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, u32 method) override;
void Compile_ALU(Macro::Opcode opcode);
void Compile_AddImmediate(Macro::Opcode opcode);
@@ -950,18 +757,13 @@ public:
void Compile_Read(Macro::Opcode opcode);
void Compile_Branch(Macro::Opcode opcode);
-private:
void Optimizer_ScanFlags();
-
void Compile();
bool Compile_NextInstruction();
-
Xbyak::Reg32 Compile_FetchParameter();
Xbyak::Reg32 Compile_GetRegister(u32 index, Xbyak::Reg32 dst);
-
void Compile_ProcessResult(Macro::ResultOperation operation, u32 reg);
void Compile_Send(Xbyak::Reg32 value);
-
Macro::Opcode GetOpCode() const;
struct JITState {
@@ -981,21 +783,17 @@ private:
bool enable_asserts{};
};
OptimizerState optimizer{};
-
std::optional next_opcode{};
ProgramType program{nullptr};
-
std::array labels;
std::array delay_skip;
Xbyak::Label end_of_code{};
-
bool is_delay_slot{};
u32 pc{};
-
- const std::vector& code;
+ std::span code;
};
-void MacroJITx64Impl::Execute(const std::vector& parameters, u32 method) {
+void MacroJITx64Impl::Execute(Engines::Maxwell3D& maxwell3d, std::span parameters, u32 method) {
ASSERT_OR_EXECUTE(program != nullptr, { return; });
JITState state{};
state.maxwell3d = &maxwell3d;
@@ -1231,7 +1029,7 @@ void MacroJITx64Impl::Compile_Read(Macro::Opcode opcode) {
Compile_ProcessResult(opcode.result_operation, opcode.dst);
}
-void Send(Engines::Maxwell3D* maxwell3d, Macro::MethodAddress method_address, u32 value) {
+static void MacroJIT_SendThunk(Engines::Maxwell3D* maxwell3d, Macro::MethodAddress method_address, u32 value) {
maxwell3d->CallMethod(method_address.address, value, true);
}
@@ -1240,7 +1038,7 @@ void MacroJITx64Impl::Compile_Send(Xbyak::Reg32 value) {
mov(Common::X64::ABI_PARAM1, qword[STATE]);
mov(Common::X64::ABI_PARAM2.cvt32(), METHOD_ADDRESS);
mov(Common::X64::ABI_PARAM3.cvt32(), value);
- Common::X64::CallFarFunction(*this, &Send);
+ Common::X64::CallFarFunction(*this, &MacroJIT_SendThunk);
Common::X64::ABI_PopRegistersAndAdjustStack(*this, PersistentCallerSavedRegs(), 0);
Xbyak::Label dont_process{};
@@ -1452,10 +1250,8 @@ bool MacroJITx64Impl::Compile_NextInstruction() {
return true;
}
-static void WarnInvalidParameter(uintptr_t parameter, uintptr_t max_parameter) {
- LOG_CRITICAL(HW_GPU,
- "Macro JIT: invalid parameter access 0x{:x} (0x{:x} is the last parameter)",
- parameter, max_parameter - sizeof(u32));
+static void MacroJIT_ErrorThunk(uintptr_t parameter, uintptr_t max_parameter) {
+ LOG_CRITICAL(HW_GPU, "Macro JIT: invalid parameter access 0x{:x} (0x{:x} is the last parameter)", parameter, max_parameter - sizeof(u32));
}
Xbyak::Reg32 MacroJITx64Impl::Compile_FetchParameter() {
@@ -1465,7 +1261,7 @@ Xbyak::Reg32 MacroJITx64Impl::Compile_FetchParameter() {
Common::X64::ABI_PushRegistersAndAdjustStack(*this, PersistentCallerSavedRegs(), 0);
mov(Common::X64::ABI_PARAM1, PARAMETERS);
mov(Common::X64::ABI_PARAM2, MAX_PARAMETER);
- Common::X64::CallFarFunction(*this, &WarnInvalidParameter);
+ Common::X64::CallFarFunction(*this, &MacroJIT_ErrorThunk);
Common::X64::ABI_PopRegistersAndAdjustStack(*this, PersistentCallerSavedRegs(), 0);
L(parameter_ok);
mov(eax, dword[PARAMETERS]);
@@ -1574,33 +1370,42 @@ static void Dump(u64 hash, std::span code, bool decompiled = false) {
macro_file.write(reinterpret_cast(code.data()), code.size_bytes());
}
-MacroEngine::MacroEngine(Engines::Maxwell3D& maxwell3d_, bool is_interpreted_)
- : hle_macros{std::make_optional(maxwell3d_)}
- , maxwell3d{maxwell3d_}
- , is_interpreted{is_interpreted_}
-{}
-
-MacroEngine::~MacroEngine() = default;
-
-void MacroEngine::AddCode(u32 method, u32 data) {
- uploaded_macro_code[method].push_back(data);
-}
-
-void MacroEngine::ClearCode(u32 method) {
- macro_cache.erase(method);
- uploaded_macro_code.erase(method);
-}
-
-void MacroEngine::Execute(u32 method, const std::vector& parameters) {
- auto compiled_macro = macro_cache.find(method);
- if (compiled_macro != macro_cache.end()) {
- const auto& cache_info = compiled_macro->second;
- if (cache_info.has_hle_program) {
- cache_info.hle_program->Execute(parameters, method);
- } else {
- maxwell3d.RefreshParameters();
- cache_info.lle_program->Execute(parameters, method);
- }
+void MacroEngine::Execute(Engines::Maxwell3D& maxwell3d, u32 method, std::span parameters) {
+ auto const execute_variant = [&maxwell3d, ¶meters, method](AnyCachedMacro& acm) {
+ if (auto a = std::get_if(&acm))
+ a->Execute(maxwell3d, parameters, method);
+ if (auto a = std::get_if(&acm))
+ a->Execute(maxwell3d, parameters, method);
+ if (auto a = std::get_if(&acm))
+ a->Execute(maxwell3d, parameters, method);
+ if (auto a = std::get_if(&acm))
+ a->Execute(maxwell3d, parameters, method);
+ if (auto a = std::get_if