From e4fcc1555057f2b1c30a988c32d6606d8ad8715b Mon Sep 17 00:00:00 2001 From: lizzie Date: Mon, 27 Apr 2026 16:52:28 +0000 Subject: [PATCH] demangling disabled for windows since windows sucks --- src/common/CMakeLists.txt | 2 +- src/common/demangle.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/common/CMakeLists.txt b/src/common/CMakeLists.txt index acd4c1b6b1..8bdbcb823f 100644 --- a/src/common/CMakeLists.txt +++ b/src/common/CMakeLists.txt @@ -255,7 +255,7 @@ target_link_libraries(common PUBLIC fmt::fmt stb::headers Threads::Threads unord target_link_libraries(common PRIVATE lz4::lz4 zstd::zstd) # Please refer to src/common/demangle.cpp -if (MSVC) +if (WIN32) target_link_libraries(common PRIVATE LLVM::Demangle) endif() diff --git a/src/common/demangle.cpp b/src/common/demangle.cpp index 87a3834180..8f76a884a8 100644 --- a/src/common/demangle.cpp +++ b/src/common/demangle.cpp @@ -6,7 +6,7 @@ #include #include -#ifdef _MSC_VER +#ifdef _WIN32 #include #else #include @@ -23,7 +23,7 @@ namespace Common { std::string DemangleSymbol(const std::string& mangled) { if (mangled.size() > 0) { if (IsItanium(mangled)) { -#ifdef _MSC_VER +#ifdef _WIN32 // requires the use of llvm if (char* p = llvm::itaniumDemangle(mangled); p != nullptr) { std::string ret = std::string{p};