Plexi09/eden-miror
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden synced 2026-10-20 18:59:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Revert "quick test to add pointer range management on buffer binding from indirect draws"

Browse source
This commit is contained in:
CamilleLaVey 2026-09-29 23:54:21 -04:00
parent bdc890f647
commit 8040f06c87
1 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/video_core/buffer_cache/buffer_cache.h
View file

@ -123,6 +123,8 @@ void BufferCache<P>::TickFrame() {
if (total_used_memory >= minimum_memory || heap_pressure) { if (total_used_memory >= minimum_memory || heap_pressure) {
RunGarbageCollector(); RunGarbageCollector();
} }
std::erase_if(pointer_ranges,
[this](const PointerRange& range) { return range.frame + 2 < frame_tick; });
++frame_tick; ++frame_tick;
delayed_destruction_ring.Tick(); delayed_destruction_ring.Tick();
@ -956,7 +958,6 @@ void BufferCache<P>::BindHostDrawIndirectBuffers() {
Buffer& buffer = slot_buffers[binding.buffer_id]; Buffer& buffer = slot_buffers[binding.buffer_id];
TouchBuffer(buffer, binding.buffer_id); TouchBuffer(buffer, binding.buffer_id);
SynchronizeBuffer(buffer, binding.device_addr, binding.size); SynchronizeBuffer(buffer, binding.device_addr, binding.size);
RecordPointerRange(binding);
}; };
if (current_draw_indirect->include_count) { if (current_draw_indirect->include_count) {
bind_buffer(channel_state->count_buffer_binding); bind_buffer(channel_state->count_buffer_binding);
@ -1458,7 +1459,6 @@ void BufferCache<P>::UpdateDrawIndirect() {
} }
binding = Binding{ binding = Binding{
.device_addr = *device_addr, .device_addr = *device_addr,
.gpu_addr = gpu_addr,
.size = static_cast<u32>(size), .size = static_cast<u32>(size),
.buffer_id = FindBuffer(*device_addr, static_cast<u32>(size), false), .buffer_id = FindBuffer(*device_addr, static_cast<u32>(size), false),
}; };
@ -1517,7 +1517,7 @@ void BufferCache<P>::UpdatePointerRanges() {
template <class P> template <class P>
void BufferCache<P>::RecordPointerRange(const Binding& binding) { void BufferCache<P>::RecordPointerRange(const Binding& binding) {
if (!record_pointer_ranges || binding.size == 0) { if (!record_pointer_ranges) {
return; return;
} }
const auto it = std::ranges::find(pointer_ranges, binding.gpu_addr, &PointerRange::gpu_addr); const auto it = std::ranges::find(pointer_ranges, binding.gpu_addr, &PointerRange::gpu_addr);
@ -1527,13 +1527,10 @@ void BufferCache<P>::RecordPointerRange(const Binding& binding) {
it->frame = frame_tick; it->frame = frame_tick;
return; return;
} }
const PointerRange range{binding.gpu_addr, binding.device_addr, binding.size, frame_tick,
NULL_BUFFER_ID};
if (pointer_ranges.size() < MAX_POINTER_RANGES) { if (pointer_ranges.size() < MAX_POINTER_RANGES) {
pointer_ranges.push_back(range); pointer_ranges.push_back({binding.gpu_addr, binding.device_addr, binding.size, frame_tick,
return; NULL_BUFFER_ID});
} }
*std::ranges::min_element(pointer_ranges, {}, &PointerRange::frame) = range;
} }
template <class P> template <class P>