Plexi09/eden-miror
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden synced 2026-05-18 20:57:00 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

suboptimal cgen for windows

Browse source
This commit is contained in:
lizzie 2026-04-27 23:42:29 +00:00
parent f10deb0d6b
commit 617dccdf64
1 changed files with 25 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

27
src/dynarmic/src/dynarmic/common/spin_lock_x64.cpp
View file

@ -27,6 +27,7 @@ namespace Dynarmic {
/// @arg waitpkg Whetever or not the "UMWAIT" instruction can be used /// @arg waitpkg Whetever or not the "UMWAIT" instruction can be used
void EmitSpinLockLock(Xbyak::CodeGenerator& code, Xbyak::Address ptr, Xbyak::Reg32 tmp, bool waitpkg) { void EmitSpinLockLock(Xbyak::CodeGenerator& code, Xbyak::Address ptr, Xbyak::Reg32 tmp, bool waitpkg) {
// TODO: this is because we lack regalloc - so better to be safe :( // TODO: this is because we lack regalloc - so better to be safe :(
// TODO: really involve regalloc when we require a 64 bit disp temporal... aside from the one we got handed of course
if (waitpkg) { if (waitpkg) {
Xbyak::Label start, loop; Xbyak::Label start, loop;
code.jmp(start, code.T_NEAR); code.jmp(start, code.T_NEAR);
@ -62,7 +63,18 @@ void EmitSpinLockLock(Xbyak::CodeGenerator& code, Xbyak::Address ptr, Xbyak::Reg
code.pop(Xbyak::util::eax); code.pop(Xbyak::util::eax);
code.L(start); code.L(start);
code.mov(tmp, 1); code.mov(tmp, 1);
/*code.lock();*/ code.xchg(ptr, tmp); if (ptr.is64bitDisp()) {
// if tmp is on eax, use ebx, otherwise use eax!
auto const other_tmp = tmp == Xbyak::util::eax
? Xbyak::util::ebx
: Xbyak::util::eax;
code.push(other_tmp);
code.mov(other_tmp, ptr.getDisp());
/*code.lock();*/ code.xchg(other_tmp, tmp);
code.pop(other_tmp);
} else {
/*code.lock();*/ code.xchg(ptr, tmp);
}
code.test(tmp, tmp); code.test(tmp, tmp);
code.jnz(loop, code.T_NEAR); code.jnz(loop, code.T_NEAR);
} else { } else {
@ -72,7 +84,18 @@ void EmitSpinLockLock(Xbyak::CodeGenerator& code, Xbyak::Address ptr, Xbyak::Reg
code.pause(); code.pause();
code.L(start); code.L(start);
code.mov(tmp, 1); code.mov(tmp, 1);
/*code.lock();*/ code.xchg(ptr, tmp); if (ptr.is64bitDisp()) {
// if tmp is on eax, use ebx, otherwise use eax!
auto const other_tmp = tmp == Xbyak::util::eax
? Xbyak::util::ebx
: Xbyak::util::eax;
code.push(other_tmp);
code.mov(other_tmp, ptr.getDisp());
/*code.lock();*/ code.xchg(other_tmp, tmp);
code.pop(other_tmp);
} else {
/*code.lock();*/ code.xchg(ptr, tmp);
}
code.test(tmp, tmp); code.test(tmp, tmp);
code.jnz(loop, code.T_NEAR); code.jnz(loop, code.T_NEAR);
} }