Plexi09/eden-miror
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden synced 2026-04-23 05:38:59 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

[dynarmic] restore proper backtraces for A64

Browse source 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
This commit is contained in:
lizzie 2026-03-28 05:42:54 +00:00 • committed by crueter
parent 9a3af3a6a3
commit 5b23d5766c
2 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/dynarmic/src/dynarmic/frontend/A64/decoder/a64.h
View file

@ -70,14 +70,15 @@ constexpr DecodeTable<V> GetDecodeTable() {
/// In practice it must always suceed, otherwise something else unrelated would have gone awry /// In practice it must always suceed, otherwise something else unrelated would have gone awry
template<typename V> template<typename V>
std::reference_wrapper<const Matcher<V>> Decode(u32 instruction) { std::optional<std::reference_wrapper<const Matcher<V>>> Decode(u32 instruction) {
alignas(64) static const auto table = GetDecodeTable<V>(); alignas(64) static const auto table = GetDecodeTable<V>();
const auto& subtable = table[detail::ToFastLookupIndex(instruction)]; const auto& subtable = table[detail::ToFastLookupIndex(instruction)];
auto iter = std::find_if(subtable.begin(), subtable.end(), [instruction](const auto& matcher) { auto iter = std::find_if(subtable.begin(), subtable.end(), [instruction](const auto& matcher) {
return matcher.Matches(instruction); return matcher.Matches(instruction);
}); });
DEBUG_ASSERT(iter != subtable.end()); return iter != subtable.end()
return std::reference_wrapper<const Matcher<V>>(*iter); ? std::optional{ std::reference_wrapper<const Matcher<V>>(*iter) }
: std::nullopt;
} }
template<typename V> template<typename V>

14
src/dynarmic/src/dynarmic/frontend/A64/translate/a64_translate.cpp
View file

@ -25,7 +25,11 @@ void Translate(IR::Block& block, LocationDescriptor descriptor, MemoryReadCodeFu
const u64 pc = visitor.ir.current_location->PC(); const u64 pc = visitor.ir.current_location->PC();
if (const auto instruction = memory_read_code(pc)) { if (const auto instruction = memory_read_code(pc)) {
auto decoder = Decode<TranslatorVisitor>(*instruction); auto decoder = Decode<TranslatorVisitor>(*instruction);
should_continue = decoder.get().call(visitor, *instruction); if (decoder) {
should_continue = decoder->get().call(visitor, *instruction);
} else {
should_continue = visitor.RaiseException(Exception::UnallocatedEncoding);
}
} else { } else {
should_continue = visitor.RaiseException(Exception::NoExecuteFault); should_continue = visitor.RaiseException(Exception::NoExecuteFault);
} }
@ -45,13 +49,15 @@ bool TranslateSingleInstruction(IR::Block& block, LocationDescriptor descriptor,
bool should_continue = true; bool should_continue = true;
auto const decoder = Decode<TranslatorVisitor>(instruction); auto const decoder = Decode<TranslatorVisitor>(instruction);
should_continue = decoder.get().call(visitor, instruction); if (decoder) {
should_continue = decoder->get().call(visitor, instruction);
} else {
should_continue = false;
}
visitor.ir.current_location = visitor.ir.current_location->AdvancePC(4); visitor.ir.current_location = visitor.ir.current_location->AdvancePC(4);
block.CycleCount()++; block.CycleCount()++;
block.SetEndLocation(*visitor.ir.current_location); block.SetEndLocation(*visitor.ir.current_location);
return should_continue; return should_continue;
} }